Skip to content

Instantly share code, notes, and snippets.

@irfansharif
Created June 11, 2020 15:18
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save irfansharif/e5325c294ac7273aa7cc376e3b98d6b1 to your computer and use it in GitHub Desktop.
Save irfansharif/e5325c294ac7273aa7cc376e3b98d6b1 to your computer and use it in GitHub Desktop.
$ git show HEAD
commit 49339fef48f4165a4e7471290bb08d422cf835a9 (HEAD -> master, upstream/staging, upstream/master, origin/master)
Merge: 0c2f0d2a64 fcb4a0102e
Author: craig[bot] <bors@cockroachlabs.com>
Date: Thu Jun 11 04:08:00 2020 +0000
Merge #50016
50016: importccl: Improve PGCOPY import peformance by using parallelImporter r=miretskiy a=adityamaru
This change parallelizes PGCOPY import by switching to the
`parallelImporter` which is currently used by mysqlout, csv and avro
imports. Benchmark runs show a ~3.5x improvement in performance as a
result of this change.
Release note (performance improvement): PGCOPY import was made ~3.5x
faster by parallelizing the conversion of raw input data to Datums.
Co-authored-by: Aditya Maru <adityamaru@gmail.com>
$ make build
Running make with -j16
GOPATH set to /Users/irfansharif/Software
find ./pkg -name node_modules -prune -o -type f -name '*.pb.go' -exec rm {} +
find ./pkg -name node_modules -prune -o -type f -name '*.pb.gw.go' -exec rm {} +
build/werror.sh /Users/irfansharif/Software/native/x86_64-apple-darwin19.5.0/protobuf/protoc -Ipkg:./vendor/github.com:./vendor/github.com/gogo/protobuf:./vendor/github.com/gogo/protobuf/protobuf:./vendor/github.com/cockroachdb/errors:./vendor/go.etcd.io:./vendor/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis --grpc-gateway_out=logtostderr=true,request_context=true:./pkg ./pkg/server/serverpb/admin.proto ./pkg/server/serverpb/status.proto ./pkg/server/serverpb/authentication.proto
set -e; for dir in ./pkg/acceptance/cluster/ ./pkg/blobs/blobspb/ ./pkg/build/ ./pkg/ccl/backupccl/ ./pkg/ccl/baseccl/ ./pkg/ccl/storageccl/engineccl/enginepbccl/ ./pkg/ccl/utilccl/licenseccl/ ./pkg/cli/systembench/systembenchpb/ ./pkg/clusterversion/ ./pkg/config/ ./pkg/config/zonepb/ ./pkg/geo/geoindex/ ./pkg/geo/geopb/ ./pkg/gossip/ ./pkg/jobs/jobspb/ ./pkg/kv/kvnemesis/ ./pkg/kv/kvserver/ ./pkg/kv/kvserver/closedts/ctpb/ ./pkg/kv/kvserver/concurrency/lock/ ./pkg/kv/kvserver/kvserverpb/ ./pkg/kv/kvserver/protectedts/ptpb/ ./pkg/kv/kvserver/protectedts/ptstorage/ ./pkg/roachpb/ ./pkg/rpc/ ./pkg/server/diagnosticspb/ ./pkg/server/serverpb/ ./pkg/server/status/statuspb/ ./pkg/sql/colexec/execpb/ ./pkg/sql/execinfrapb/ ./pkg/sql/flowinfra/ ./pkg/sql/opt/invertedexpr/ ./pkg/sql/pgwire/pgerror/ ./pkg/sql/rowexec/ ./pkg/sql/rowflow/ ./pkg/sql/sqlbase/ ./pkg/sql/stats/ ./pkg/sql/types/ ./pkg/sqlmigrations/leasemanager/ ./pkg/storage/enginepb/ ./pkg/ts/catalog/ ./pkg/ts/tspb/ ./pkg/util/ ./pkg/util/hlc/ ./pkg/util/log/ ./pkg/util/metric/ ./pkg/util/protoutil/ ./pkg/util/tracing/; do \
build/werror.sh /Users/irfansharif/Software/native/x86_64-apple-darwin19.5.0/protobuf/protoc -Ipkg:./vendor/github.com:./vendor/github.com/gogo/protobuf:./vendor/github.com/gogo/protobuf/protobuf:./vendor/go.etcd.io:./vendor/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis:./vendor/github.com/cockroachdb/errors --gogoroach_out=Mgoogle/api/annotations.proto=github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis/google/api,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/any.proto=github.com/gogo/protobuf/types,,plugins=grpc,import_prefix=github.com/cockroachdb/cockroach/pkg/:./pkg $dir/*.proto; \
done
build/werror.sh /Users/irfansharif/Software/native/x86_64-apple-darwin19.5.0/protobuf/protoc -Ipkg:./vendor/github.com:./vendor/github.com/gogo/protobuf:./vendor/github.com/gogo/protobuf/protobuf:./vendor/github.com/cockroachdb/errors:./vendor/go.etcd.io:./vendor/github.com/grpc-ecosystem/grpc-gateway/third_party/googleapis --grpc-gateway_out=logtostderr=true,request_context=true:./pkg ./pkg/ts/tspb/timeseries.proto
sed -i '' -E 's!golang.org/x/net/context!context!g' ./pkg/server/serverpb/admin.pb.gw.go ./pkg/server/serverpb/status.pb.gw.go ./pkg/server/serverpb/authentication.pb.gw.go ./pkg/ts/tspb/timeseries.pb.gw.go
gofmt -s -w ./pkg/server/serverpb/admin.pb.gw.go ./pkg/server/serverpb/status.pb.gw.go ./pkg/server/serverpb/authentication.pb.gw.go ./pkg/ts/tspb/timeseries.pb.gw.go
goimports -w ./pkg/server/serverpb/admin.pb.gw.go ./pkg/server/serverpb/status.pb.gw.go ./pkg/server/serverpb/authentication.pb.gw.go ./pkg/ts/tspb/timeseries.pb.gw.go
touch bin/.gw_protobuf_sources
sed -i '' -E \
-e '/import _ /d' \
-e 's!import (fmt|math) "github.com/cockroachdb/cockroach/pkg/(fmt|math)"! !g' \
-e 's!github\.com/cockroachdb/cockroach/pkg/(etcd)!go.etcd.io/\1!g' \
-e 's!github.com/cockroachdb/cockroach/pkg/((bytes|encoding/binary|errors|fmt|io|math|github\.com|(google\.)?golang\.org)([^a-z]|$))!\1!g' \
-e 's!github.com/cockroachdb/cockroach/pkg/errorspb!github.com/cockroachdb/errors/errorspb!g' \
-e 's!golang.org/x/net/context!context!g' \
./pkg/acceptance/cluster/testconfig.pb.go ./pkg/blobs/blobspb/blobs.pb.go ./pkg/build/info.pb.go ./pkg/ccl/backupccl/backup.pb.go ./pkg/ccl/baseccl/encryption_options.pb.go ./pkg/ccl/storageccl/engineccl/enginepbccl/key_registry.pb.go ./pkg/ccl/storageccl/engineccl/enginepbccl/stats.pb.go ./pkg/ccl/utilccl/licenseccl/license.pb.go ./pkg/cli/systembench/systembenchpb/ping.pb.go ./pkg/clusterversion/cluster_version.pb.go ./pkg/config/system.pb.go ./pkg/config/zonepb/zone.pb.go ./pkg/geo/geoindex/config.pb.go ./pkg/geo/geopb/geopb.pb.go ./pkg/gossip/gossip.pb.go ./pkg/jobs/jobspb/jobs.pb.go ./pkg/jobs/jobspb/schedule.pb.go ./pkg/kv/kvnemesis/operations.pb.go ./pkg/kv/kvserver/api.pb.go ./pkg/kv/kvserver/closedts/ctpb/entry.pb.go ./pkg/kv/kvserver/closedts/ctpb/service.pb.go ./pkg/kv/kvserver/concurrency/lock/locking.pb.go ./pkg/kv/kvserver/kvserverpb/lease_status.pb.go ./pkg/kv/kvserver/kvserverpb/liveness.pb.go ./pkg/kv/kvserver/kvserverpb/log.pb.go ./pkg/kv/kvserver/kvserverpb/proposer_kv.pb.go ./pkg/kv/kvserver/kvserverpb/state.pb.go ./pkg/kv/kvserver/protectedts/ptpb/protectedts.pb.go ./pkg/kv/kvserver/protectedts/ptstorage/storage.pb.go ./pkg/kv/kvserver/raft.pb.go ./pkg/kv/kvserver/storage_services.pb.go ./pkg/roachpb/api.pb.go ./pkg/roachpb/app_stats.pb.go ./pkg/roachpb/data.pb.go ./pkg/roachpb/errors.pb.go ./pkg/roachpb/internal.pb.go ./pkg/roachpb/internal_raft.pb.go ./pkg/roachpb/io-formats.pb.go ./pkg/roachpb/metadata.pb.go ./pkg/rpc/heartbeat.pb.go ./pkg/server/diagnosticspb/diagnostics.pb.go ./pkg/server/serverpb/admin.pb.go ./pkg/server/serverpb/authentication.pb.go ./pkg/server/serverpb/init.pb.go ./pkg/server/serverpb/status.pb.go ./pkg/server/status/statuspb/status.pb.go ./pkg/sql/colexec/execpb/stats.pb.go ./pkg/sql/execinfrapb/api.pb.go ./pkg/sql/execinfrapb/data.pb.go ./pkg/sql/execinfrapb/processors.pb.go ./pkg/sql/execinfrapb/processors_base.pb.go ./pkg/sql/execinfrapb/processors_bulk_io.pb.go ./pkg/sql/execinfrapb/processors_changefeeds.pb.go ./pkg/sql/execinfrapb/processors_sql.pb.go ./pkg/sql/execinfrapb/processors_table_stats.pb.go ./pkg/sql/flowinfra/stats.pb.go ./pkg/sql/opt/invertedexpr/span_expression.pb.go ./pkg/sql/pgwire/pgerror/errors.pb.go ./pkg/sql/rowexec/stats.pb.go ./pkg/sql/rowflow/stats.pb.go ./pkg/sql/sqlbase/encoded_datum.pb.go ./pkg/sql/sqlbase/join_type.pb.go ./pkg/sql/sqlbase/locking.pb.go ./pkg/sql/sqlbase/privilege.pb.go ./pkg/sql/sqlbase/structured.pb.go ./pkg/sql/stats/histogram.pb.go ./pkg/sql/stats/table_statistic.pb.go ./pkg/sql/types/types.pb.go ./pkg/sqlmigrations/leasemanager/lease.pb.go ./pkg/storage/enginepb/engine.pb.go ./pkg/storage/enginepb/file_registry.pb.go ./pkg/storage/enginepb/mvcc.pb.go ./pkg/storage/enginepb/mvcc3.pb.go ./pkg/storage/enginepb/rocksdb.pb.go ./pkg/ts/catalog/chart_catalog.pb.go ./pkg/ts/tspb/timeseries.pb.go ./pkg/util/hlc/legacy_timestamp.pb.go ./pkg/util/hlc/timestamp.pb.go ./pkg/util/log/log.pb.go ./pkg/util/metric/metric.pb.go ./pkg/util/protoutil/clone.pb.go ./pkg/util/tracing/recorded_span.pb.go ./pkg/util/unresolved_addr.pb.go
gofmt -s -w ./pkg/acceptance/cluster/testconfig.pb.go ./pkg/blobs/blobspb/blobs.pb.go ./pkg/build/info.pb.go ./pkg/ccl/backupccl/backup.pb.go ./pkg/ccl/baseccl/encryption_options.pb.go ./pkg/ccl/storageccl/engineccl/enginepbccl/key_registry.pb.go ./pkg/ccl/storageccl/engineccl/enginepbccl/stats.pb.go ./pkg/ccl/utilccl/licenseccl/license.pb.go ./pkg/cli/systembench/systembenchpb/ping.pb.go ./pkg/clusterversion/cluster_version.pb.go ./pkg/config/system.pb.go ./pkg/config/zonepb/zone.pb.go ./pkg/geo/geoindex/config.pb.go ./pkg/geo/geopb/geopb.pb.go ./pkg/gossip/gossip.pb.go ./pkg/jobs/jobspb/jobs.pb.go ./pkg/jobs/jobspb/schedule.pb.go ./pkg/kv/kvnemesis/operations.pb.go ./pkg/kv/kvserver/api.pb.go ./pkg/kv/kvserver/closedts/ctpb/entry.pb.go ./pkg/kv/kvserver/closedts/ctpb/service.pb.go ./pkg/kv/kvserver/concurrency/lock/locking.pb.go ./pkg/kv/kvserver/kvserverpb/lease_status.pb.go ./pkg/kv/kvserver/kvserverpb/liveness.pb.go ./pkg/kv/kvserver/kvserverpb/log.pb.go ./pkg/kv/kvserver/kvserverpb/proposer_kv.pb.go ./pkg/kv/kvserver/kvserverpb/state.pb.go ./pkg/kv/kvserver/protectedts/ptpb/protectedts.pb.go ./pkg/kv/kvserver/protectedts/ptstorage/storage.pb.go ./pkg/kv/kvserver/raft.pb.go ./pkg/kv/kvserver/storage_services.pb.go ./pkg/roachpb/api.pb.go ./pkg/roachpb/app_stats.pb.go ./pkg/roachpb/data.pb.go ./pkg/roachpb/errors.pb.go ./pkg/roachpb/internal.pb.go ./pkg/roachpb/internal_raft.pb.go ./pkg/roachpb/io-formats.pb.go ./pkg/roachpb/metadata.pb.go ./pkg/rpc/heartbeat.pb.go ./pkg/server/diagnosticspb/diagnostics.pb.go ./pkg/server/serverpb/admin.pb.go ./pkg/server/serverpb/authentication.pb.go ./pkg/server/serverpb/init.pb.go ./pkg/server/serverpb/status.pb.go ./pkg/server/status/statuspb/status.pb.go ./pkg/sql/colexec/execpb/stats.pb.go ./pkg/sql/execinfrapb/api.pb.go ./pkg/sql/execinfrapb/data.pb.go ./pkg/sql/execinfrapb/processors.pb.go ./pkg/sql/execinfrapb/processors_base.pb.go ./pkg/sql/execinfrapb/processors_bulk_io.pb.go ./pkg/sql/execinfrapb/processors_changefeeds.pb.go ./pkg/sql/execinfrapb/processors_sql.pb.go ./pkg/sql/execinfrapb/processors_table_stats.pb.go ./pkg/sql/flowinfra/stats.pb.go ./pkg/sql/opt/invertedexpr/span_expression.pb.go ./pkg/sql/pgwire/pgerror/errors.pb.go ./pkg/sql/rowexec/stats.pb.go ./pkg/sql/rowflow/stats.pb.go ./pkg/sql/sqlbase/encoded_datum.pb.go ./pkg/sql/sqlbase/join_type.pb.go ./pkg/sql/sqlbase/locking.pb.go ./pkg/sql/sqlbase/privilege.pb.go ./pkg/sql/sqlbase/structured.pb.go ./pkg/sql/stats/histogram.pb.go ./pkg/sql/stats/table_statistic.pb.go ./pkg/sql/types/types.pb.go ./pkg/sqlmigrations/leasemanager/lease.pb.go ./pkg/storage/enginepb/engine.pb.go ./pkg/storage/enginepb/file_registry.pb.go ./pkg/storage/enginepb/mvcc.pb.go ./pkg/storage/enginepb/mvcc3.pb.go ./pkg/storage/enginepb/rocksdb.pb.go ./pkg/ts/catalog/chart_catalog.pb.go ./pkg/ts/tspb/timeseries.pb.go ./pkg/util/hlc/legacy_timestamp.pb.go ./pkg/util/hlc/timestamp.pb.go ./pkg/util/log/log.pb.go ./pkg/util/metric/metric.pb.go ./pkg/util/protoutil/clone.pb.go ./pkg/util/tracing/recorded_span.pb.go ./pkg/util/unresolved_addr.pb.go
touch bin/.go_protobuf_sources
go install -v execgen
bin/prereqs ./pkg/sql/colexec/execgen/cmd/execgen > bin/execgen.d.tmp
mv -f bin/execgen.d.tmp bin/execgen.d
EXECGEN bin/execgen_out.d
Running make with -j16
GOPATH set to /Users/irfansharif/Software
build/node-run.sh -C pkg/ui yarn install --offline
yarn install v1.21.1
[1/5] Validating package.json...
[2/5] Resolving packages...
mkdir -p lib
ln -sf /Users/irfansharif/Software/native/x86_64-apple-darwin19.5.0/geos/lib/lib{geos,geos_c}.dylib lib
EXECGEN pkg/col/coldata/vec.eg.go
EXECGEN pkg/sql/colexec/and_or_projection.eg.go
EXECGEN pkg/sql/colexec/any_not_null_agg.eg.go
EXECGEN pkg/sql/colexec/avg_agg.eg.go
EXECGEN pkg/sql/colexec/bool_and_or_agg.eg.go
EXECGEN pkg/sql/colexec/cast.eg.go
EXECGEN pkg/sql/colexec/const.eg.go
EXECGEN pkg/sql/colexec/count_agg.eg.go
EXECGEN pkg/sql/colexec/distinct.eg.go
EXECGEN pkg/sql/colexec/hashjoiner.eg.go
EXECGEN pkg/sql/colexec/hashtable_distinct.eg.go
EXECGEN pkg/sql/colexec/hashtable_full_default.eg.go
EXECGEN pkg/sql/colexec/hashtable_full_deleting.eg.go
EXECGEN pkg/sql/colexec/hash_aggregator.eg.go
EXECGEN pkg/sql/colexec/hash_utils.eg.go
EXECGEN pkg/sql/colexec/like_ops.eg.go
EXECGEN pkg/sql/colexec/mergejoinbase.eg.go
EXECGEN pkg/sql/colexec/mergejoiner_exceptall.eg.go
EXECGEN pkg/sql/colexec/mergejoiner_fullouter.eg.go
EXECGEN pkg/sql/colexec/mergejoiner_inner.eg.go
EXECGEN pkg/sql/colexec/mergejoiner_intersectall.eg.go
[3/5] Fetching packages...
EXECGEN pkg/sql/colexec/mergejoiner_leftanti.eg.go
EXECGEN pkg/sql/colexec/mergejoiner_leftouter.eg.go
EXECGEN pkg/sql/colexec/mergejoiner_leftsemi.eg.go
EXECGEN pkg/sql/colexec/mergejoiner_rightouter.eg.go
EXECGEN pkg/sql/colexec/min_max_agg.eg.go
EXECGEN pkg/sql/colexec/ordered_synchronizer.eg.go
EXECGEN pkg/sql/colexec/overloads_test_utils.eg.go
EXECGEN pkg/sql/colexec/proj_const_left_ops.eg.go
EXECGEN pkg/sql/colexec/proj_const_right_ops.eg.go
EXECGEN pkg/sql/colexec/proj_non_const_ops.eg.go
EXECGEN pkg/sql/colexec/quicksort.eg.go
EXECGEN pkg/sql/colexec/rank.eg.go
EXECGEN pkg/sql/colexec/relative_rank.eg.go
[4/5] Linking dependencies...
warning " > connected-react-router@6.6.1" has unmet peer dependency "history@^4.7.2".
warning " > connected-react-router@6.6.1" has unmet peer dependency "react-router@^4.3.1 || ^5.0.0".
EXECGEN pkg/sql/colexec/row_number.eg.go
warning " > html-webpack-template@6.0.1" has unmet peer dependency "html-webpack-plugin@2.x".
warning "karma-webpack > webpack-dev-middleware@1.12.2" has incorrect peer dependency "webpack@^1.0.0 || ^2.0.0 || ^3.0.0".
EXECGEN pkg/sql/colexec/rowstovec.eg.go
EXECGEN pkg/sql/colexec/selection_ops.eg.go
EXECGEN pkg/sql/colexec/select_in.eg.go
EXECGEN pkg/sql/colexec/sort.eg.go
EXECGEN pkg/sql/colexec/substring.eg.go
EXECGEN pkg/sql/colexec/sum_agg.eg.go
EXECGEN pkg/sql/colexec/values_differ.eg.go
EXECGEN pkg/sql/colexec/vec_comparators.eg.go
EXECGEN pkg/sql/colexec/window_peer_grouper.eg.go
go install -v docgen
bin/prereqs ./pkg/cmd/docgen > bin/docgen.d.tmp
mv -f bin/docgen.d.tmp bin/docgen.d
# github.com/cockroachdb/cockroach/pkg/cmd/docgen
ld: warning: directory not found for option '-L/Users/irfansharif/Software/native//cryptopp'
ld: warning: directory not found for option '-L/Users/irfansharif/Software/native//jemalloc/lib'
ld: warning: directory not found for option '-L/Users/irfansharif/Software/native//snappy'
ld: warning: directory not found for option '-L/Users/irfansharif/Software/native//libedit/src/.libs'
ld: warning: directory not found for option '-L/Users/irfansharif/Software/native//rocksdb'
ld: warning: directory not found for option '-L/Users/irfansharif/Software/native//libroach'
docgen grammar bnf docs/generated/sql/bnf --quiet
docgen functions docs/generated/sql --quiet
touch bin/.docgen_functions
touch bin/.docgen_bnfs
[5/5] Building fresh packages...
warning Error running install script for optional dependency: "/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents: Command failed.
Exit code: 1
Command: node install
Arguments:
Directory: /Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents
Output:
node-pre-gyp info it worked if it ends with ok
node-pre-gyp info using node-pre-gyp@0.10.0
node-pre-gyp info using node@13.8.0 | darwin | x64
node-pre-gyp info check checked for \"/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node\" (not found)
node-pre-gyp http GET https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4/fse-v1.2.4-node-v79-darwin-x64.tar.gz
node-pre-gyp http 404 https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4/fse-v1.2.4-node-v79-darwin-x64.tar.gz
node-pre-gyp WARN Tried to download(404): https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4info This module is OPTIONAL, you can safely ignore this error
/fse-v1.2.4-node-v79-darwin-x64.tar.gz
node-pre-gyp WARN Pre-built binaries not found for fsevents@1.2.4 and node@13.8.0 (node-v79 ABI, unknown) (falling back to source compile with node-gyp)
node-pre-gyp http 404 status code downloading tarball https://fsevents-binaries.s3-us-west-2.amazonaws.com/v1.2.4/fse-v1.2.4-node-v79-darwin-x64.tar.gz
gyp info it worked if it ends with ok
gyp info using node-gyp@5.0.7
gyp info using node@13.8.0 | darwin | x64
gyp info ok
gyp info it worked if it ends with ok
gyp info using node-gyp@5.0.7
gyp info using node@13.8.0 | darwin | x64
gyp info find Python using Python version 2.7.16 found at \"/System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python\"
gyp info spawn /System/Library/Frameworks/Python.framework/Versions/2.7/Resources/Python.app/Contents/MacOS/Python
gyp info spawn args [
gyp info spawn args '/usr/local/Cellar/node/13.8.0/libexec/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/usr/local/Cellar/node/13.8.0/libexec/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/Users/irfansharif/Library/Caches/node-gyp/13.8.0',
gyp info spawn args '-Dnode_gyp_dir=/usr/local/Cellar/node/13.8.0/libexec/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/Users/irfansharif/Library/Caches/node-gyp/13.8.0/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
gyp info ok
gyp info it worked if it ends with ok
gyp info using node-gyp@5.0.7
gyp info using node@13.8.0 | darwin | x64
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make[1]: warning: jobserver unavailable: using -j1. Add `+' to parent make rule.
SOLINK_MODULE(target) Release/.node
CXX(target) Release/obj.target/fse/fsevents.o
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:68:
../../nan/nan_converters_43_inl.h:22:231: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
imp::ToFactory<v8::Boolean>::return_t imp::ToFactory<v8::Boolean>::convert(v8::Local<v8::Value> val) { v8::Isolate *isolate = v8::Isolate::GetCurrent(); v8::EscapableHandleScope scope(isolate); return scope.Escape( val->ToBoolean(isolate->GetCurrentContext()) .FromMaybe(v8::Local<v8::Boolean>())); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2762:37: note: passing argument to parameter 'isolate' here
Local<Boolean> ToBoolean(Isolate* isolate) const;
^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:202:
In file included from ../../nan/nan_converters.h:68:
../../nan/nan_converters_43_inl.h:40:197: error: no viable conversion from 'Local<v8::Context>' to 'v8::Isolate *'
imp::ToFactory<bool>::return_t imp::ToFactory<bool>::convert(v8::Local<v8::Value> val) { v8::Isolate *isolate = v8::Isolate::GetCurrent(); v8::HandleScope scope(isolate); return val->BooleanValue(isolate->GetCurrentContext()); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2771:30: note: passing argument to parameter 'isolate' here
bool BooleanValue(Isolate* isolate) const;
^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:190:
../../nan/nan_implementation_12_inl.h:103:42: error: no viable conversion from 'v8::Isolate *' to 'Local<v8::Context>'
return scope.Escape(v8::Function::New( isolate
^~~~~~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'v8::Isolate *' to 'const v8::Local<v8::Context> &' for 1st argument
class Local {
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:189:7: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'v8::Isolate *' to 'v8::Local<v8::Context> &&' for 1st argument
class Local {
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:193:41: note: candidate template ignored: could not match 'Local<type-parameter-0-0>' against 'v8::Isolate *'
inline __attribute__((always_inline)) Local(Local<S> that)
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:4313:22: note: passing argument to parameter 'context' here
Local<Context> context, FunctionCallback callback,
^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:203:
In file included from ../../nan/nan_new.h:190:
../../nan/nan_implementation_12_inl.h:337:37: error: too few arguments to function call, expected 2, have 1
return v8::StringObject::New(value).As<v8::StringObject>();
~~~~~~~~~~~~~~~~~~~~~ ^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:5688:3: note: 'New' declared here
static Local<Value> New(Isolate* isolate, Local<String> value);
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1034:53: error: too few arguments to function call, single argument 'context' was not specified
v8::Local<v8::String> string = from->ToString();
~~~~~~~~~~~~~~ ^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2750:3: note: 'ToString' declared here
__attribute__((warn_unused_result)) MaybeLocal<String> ToString(
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1044:37: error: cannot initialize a parameter of type 'v8::Isolate *' with an lvalue of type 'char *'
length_ = string->WriteUtf8(str_, static_cast<int>(len), 0, flags);
^~~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:2947:26: note: passing argument to parameter 'isolate' here
int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1818:28: error: no matching member function for call to 'Set'
New(persistentHandle)->Set(New(key).ToLocalChecked(), value);
~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context, uint32_t index,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1824:28: error: no matching member function for call to 'Set'
New(persistentHandle)->Set(key, value);
~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context, uint32_t index,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1830:28: error: no matching member function for call to 'Set'
New(persistentHandle)->Set(index, value);
~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context, uint32_t index,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1836:32: error: no matching member function for call to 'Get'
New(persistentHandle)->Get(New(key).ToLocalChecked()));
~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:57: note: candidate function not viable: requires 2 arguments, but 1 was provided
__attribute__((warn_unused_result)) MaybeLocal<Value> Get(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:57: note: candidate function not viable: requires 2 arguments, but 1 was provided
__attribute__((warn_unused_result)) MaybeLocal<Value> Get(Local<Context> context,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1842:48: error: no matching member function for call to 'Get'
return scope.Escape(New(persistentHandle)->Get(key));
~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:57: note: candidate function not viable: requires 2 arguments, but 1 was provided
__attribute__((warn_unused_result)) MaybeLocal<Value> Get(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:57: note: candidate function not viable: requires 2 arguments, but 1 was provided
__attribute__((warn_unused_result)) MaybeLocal<Value> Get(Local<Context> context,
^
In file included from ../fsevents.cc:6:
../../nan/nan.h:1847:48: error: no matching member function for call to 'Get'
return scope.Escape(New(persistentHandle)->Get(index));
~~~~~~~~~~~~~~~~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3594:57: note: candidate function not viable: requires 2 arguments, but 1 was provided
__attribute__((warn_unused_result)) MaybeLocal<Value> Get(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3597:57: note: candidate function not viable: requires 2 arguments, but 1 was provided
__attribute__((warn_unused_result)) MaybeLocal<Value> Get(Local<Context> context,
^
In file included from ../fsevents.cc:6:
In file included from ../../nan/nan.h:2657:
../../nan/nan_object_wrap.h:24:38: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
(__builtin_expect(!(persistent().IsNearDeath()), 0) ? __assert_rtn(__func__, \"../../nan/nan_object_wrap.h\", 24, \"persistent().IsNearDeath()\") : (void)0);
~~~~~~~~~~~~ ^
../../nan/nan_object_wrap.h:67:18: error: no member named 'MarkIndependent' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
persistent().MarkIndependent();
~~~~~~~~~~~~ ^
../../nan/nan_object_wrap.h:124:39: error: no member named 'IsNearDeath' in 'Nan::Persistent<v8::Object, v8::NonCopyablePersistentTraits<v8::Object> >'
(__builtin_expect(!(wrap->handle_.IsNearDeath()), 0) ? __assert_rtn(__func__, \"../../nan/nan_object_wrap.h\", 124, \"wrap->handle_.IsNearDeath()\") : (void)0);
~~~~~~~~~~~~~ ^
../fsevents.cc:50:32: error: no template named 'Handle' in namespace 'v8'
static void Initialize(v8::Handle<v8::Object> exports);
~~~~^
../fsevents.cc:63:6: warning: field 'async_resource' will be initialized after field 'lockStarted' [-Wreorder]
: async_resource(\"fsevents:FSEvents\"), lockStarted(false) {
^
In file included from ../fsevents.cc:82:
../src/constants.cc:89:11: error: no matching member function for call to 'Set'
object->Set(Nan::New<v8::String>(\"kFSEventStreamEventFlagNone\").ToLocalChecked(), Nan::New<v8::Integer>(0x00000000));
~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context, uint32_t index,
^
In file included from ../fsevents.cc:82:
../src/constants.cc:90:11: error: no matching member function for call to 'Set'
object->Set(Nan::New<v8::String>(\"kFSEventStreamEventFlagMustScanSubDirs\").ToLocalChecked(), Nan::New<v8::Integer>(0x00000001));
~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context, uint32_t index,
^
In file included from ../fsevents.cc:82:
../src/constants.cc:91:11: error: no matching member function for call to 'Set'
object->Set(Nan::New<v8::String>(\"kFSEventStreamEventFlagUserDropped\").ToLocalChecked(), Nan::New<v8::Integer>(0x00000002));
~~~~~~~~^~~
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3547:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context,
^
/Users/irfansharif/Library/Caches/node-gyp/13.8.0/include/node/v8.h:3550:51: note: candidate function not viable: requires 3 arguments, but 2 were provided
__attribute__((warn_unused_result)) Maybe<bool> Set(Local<Context> context, uint32_t index,
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
1 warning and 20 errors generated.
make[1]: *** [Release/obj.target/fse/fsevents.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/usr/local/Cellar/node/13.8.0/libexec/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack at ChildProcess.emit (events.js:321:20)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Darwin 19.5.0
gyp ERR! command \"/usr/local/Cellar/node/13.8.0/bin/node\" \"/usr/local/Cellar/node/13.8.0/libexec/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"build\" \"--fallback-to-build\" \"--module=/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node\" \"--module_name=fse\" \"--module_path=/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64\" \"--napi_version=5\" \"--node_abi_napi=napi\"
gyp ERR! cwd /Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents
gyp ERR! node -v v13.8.0
gyp ERR! node-gyp -v v5.0.7
gyp ERR! not ok
node-pre-gyp ERR! build error
node-pre-gyp ERR! stack Error: Failed to execute 'node-gyp build --fallback-to-build --module=/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node --module_name=fse --module_path=/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64 --napi_version=5 --node_abi_napi=napi' (1)
node-pre-gyp ERR! stack at ChildProcess.<anonymous> (/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/node_modules/node-pre-gyp/lib/util/compile.js:83:29)
node-pre-gyp ERR! stack at ChildProcess.emit (events.js:321:20)
node-pre-gyp ERR! stack at maybeClose (internal/child_process.js:1026:16)
node-pre-gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:286:5)
node-pre-gyp ERR! System Darwin 19.5.0
node-pre-gyp ERR! command \"/usr/local/Cellar/node/13.8.0/bin/node\" \"/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/node_modules/node-pre-gyp/bin/node-pre-gyp\" \"install\" \"--fallback-to-build\"
node-pre-gyp ERR! cwd /Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents
node-pre-gyp ERR! node -v v13.8.0
node-pre-gyp ERR! node-pre-gyp -v v0.10.0
node-pre-gyp ERR! not ok
Failed to execute 'node-gyp build --fallback-to-build --module=/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64/fse.node --module_name=fse --module_path=/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/fsevents/lib/binding/Release/node-v79-darwin-x64 --napi_version=5 --node_abi_napi=napi' (1)"
Done in 42.09s.
# Prevent ProtobufJS from trying to install its own packages because a) the
# the feature is buggy, and b) it introduces an unnecessary dependency on NPM.
# See: https://github.com/dcodeIO/protobuf.js/issues/716.
# We additionally pin the dependencies by linking in a lock file for
# reproducable builds.
build/node-run.sh pkg/ui/bin/gen-protobuf-cli-deps.js > pkg/ui/node_modules/protobufjs/cli/package.json
ln -sf ../../../yarn.protobufjs-cli.lock pkg/ui/node_modules/protobufjs/cli/yarn.lock
build/node-run.sh -C pkg/ui/node_modules/protobufjs/cli yarn install --offline
yarn install v1.21.1
error An unexpected error occurred: "/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/protobufjs/cli/package.json: Unexpected end of JSON input".
info If you think this is a bug, please open a bug report with the information provided in "/Users/irfansharif/Software/src/github.com/cockroachdb/cockroach/pkg/ui/node_modules/protobufjs/cli/yarn-error.log".
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
make: *** [pkg/ui/yarn.installed] Error 1
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment