Created
June 17, 2021 17:47
-
-
Save isaacs/c02d6c2f72cbbbb0c7c5be856d8bac8a to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/lib/diff.js b/lib/diff.js | |
index dac7c81f..1f8eff0f 100644 | |
--- a/lib/diff.js | |
+++ b/lib/diff.js | |
@@ -145,9 +145,9 @@ const allChildren = node => { | |
if (!node) | |
return new Map() | |
- // if the node is a global root, and also a link, then what we really | |
+ // if the node is root, and also a link, then what we really | |
// want is to traverse the target's children | |
- if (node.global && node.isRoot && node.isLink) | |
+ if (node.isRoot && node.isLink) | |
return allChildren(node.target) | |
const kids = new Map() |
Not necessarily. isRoot
means "this is the root of the project". isLink
means "this is a symlink (or at least, path !== realpath)".
It would be a case like:
mkdir foo
ln -s foo bar
cd bar
npm install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
when npm ci with workspaces, both isRoot and isLink are true