isatimur

2017-04-21 10:51:45.953  INFO 9784 --- [nio-8080-exec-1] SendDestinationQueueController           : Enter controller with payload:
2017-04-21 10:51:46.142  INFO 9784 --- [nio-8080-exec-1] JmsService                               : Json message: {"dateFrom":"2017-04-20T07:35:55.210+00:00","dateTo":"2017-04-20T16:35:55.210+00:00","queueName":"test1051"} -  sending to destination: rmsStatementsPerKuvdRecordsIn
2017-04-21 10:51:46.994  INFO 9784 --- [nio-8080-exec-1] JmsService                               : Creating dynamic consumer from queue by name: test1051 and putting data messages to StageDB
2017-04-21 10:51:47.009  INFO 9784 --- [pool-1-thread-1] JmsConsumer                              : Create a Connection
2017-04-21 10:51:47.303  INFO 9784 --- [pool-1-thread-1] JmsConsumer                              : // Create a Session
2017-04-21 10:51:47.303  INFO 9784 --- [pool-1-thread-1] JmsConsumer                              : // Create the destination (Topic or Queue)
2017-04-21 10:51:47.303  INFO 9784 --

isatimur

2017-06-22 14:05:25.334 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.export.ExportBuilderBase   : Extracting object 24:11:0340531:798
2017-06-22 14:05:25.334 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.export.ExportBuilderBase   : Extracting object 24:11:0340510:793
2017-06-22 14:05:25.334 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.export.ExportBuilderBase   : Extracting object 24:11:0340531:812
2017-06-22 14:05:25.334 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.export.ExportBuilderBase   : Extracting object 24:11:0410105:9
2017-06-22 14:05:25.334 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.export.ExportBuilderBase   : Extracting object 24:11:0340517:412
2017-06-22 14:05:25.334 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.export.ExportBuilderBase   : Extracting object 24:11:0340531:800
2017-06-22 14:05:25.334 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.export.ExportBuilderBase   : Extracting object 24:11:0410211:298
2017-06-22 14:05:25.335 DEBUG 3316 --- [r[ftsAdapterIn]] r.a.p.service.exp

isatimur

package ru.atc.pmo.service.export;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.jdbc.datasource.DataSourceTransactionManager;
import org.springframework.stereotype.Component;
import ru.atc.pmo.service.db.DaoResult;
import ru.atc.pmo.service.db.PmoDao;

isatimur

Вопросы по дизайн ревью и код ревью:
    - это разделение по пакетам и модульность - а также применение паттернов проектирования - пример Lagom
	- тестирование должно соблюдаться с неким порогом покрытия тестов, правильным наименованием теста - сигнатура теста, разделением тестов на интеграционный, unit и функциональный тесты.
	- обследование инструментария тестирования для play framework-а -  jacoco, selenium, junit4, sonar, checkstyle  - очень важный момент это с тестирование Actor-ов
чек стайл - нужно выбрать:
	https://stackoverflow.com/questions/16929442/how-to-integrate-checkstyle-and-pmd-into-play-framework-build-scala-file
	http://ics-software-engineering.github.io/play-example-quality-assurance/
	https://www.quora.com/How-do-I-implement-check-style-set-up-for-play-framework-with-Java
	https://blog.thomastoye.be/play-framework-ci-507b9e77d5b3
	https://groups.google.com/forum/#!topic/play-framework/1aGhAMmIZyU

isatimur

<?xml version="1.0"?>
<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.2//EN" "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">

<module name="Checker">
  <property name="charset" value="UTF-8"/>

  <module name="SuppressWarningsFilter" />

  <module name="TreeWalker">
    <property name="tabWidth" value="4"/>

isatimur

class Cash {
  private final Exchange exchange;
  private final int cents;
  public Cash(Exchange exch, int cents) {
    this.exchange = exch;
    this.cents = cents;
  }
  public Cash in(String currency) {
    return new Cash(
      this.exchange,

isatimur

@Data
@AllArgsConstructor
@NoArgsConstructor
public class Page<T> {
    private int page;
    private int size;
    private int totalSize;
    private List<T> entities;
}

isatimur

curl -X HEAD \
  https://cdn.dasreda.ru/storage-data/039049c5-6500-460e-aea7-d1452408e2b2/kak_ne_ubit-_biznes_kassovym_razryvom.pdf \
  -H 'authorization: Bearer fuck.yourself.true-token' \
  -H 'cache-control: no-cache' \
  -H 'content-type: application/json' \
  -H 'postman-token: fdd83e1c-2d15-8312-0869-316d92eca807' \
  -H 'source: ui' \

isatimur

{
  "page": 0,
  "size": 1,
  "totalSize": 203,
  "entities": [
    {
      "id": 0123,
      "slug": "registraciya-kredita",
      "title": "Регистрация кредита",
      "shortDescription": "Курс состоит из пошаговых инструкций, которые помогут предпринимателю.",

isatimur

var http = require('http');
var express = require('express');
var app = express();
const fetch = require('node-fetch');


app.get('/:inn', function (req, res) {
const {inn} = req.params;

const response = fetch("https://egrul.nalog.ru/", {