Patch for binutils 2.31.1 that fixes "invalid version 21 (max 0)" errors https://sourceware.org/ml/binutils/2018-08/msg00227.html

binutils-bfd-elflink.patch

--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -686,13 +686,11 @@ bfd_elf_record_link_assignment (bfd *output_bfd,
       && !h->def_regular)
     h->root.type = bfd_link_hash_undefined;
 
-  /* If this symbol is not being provided by the linker script, and it is
-     currently defined by a dynamic object, but not by a regular object,
-     then clear out any version information because the symbol will not be
-     associated with the dynamic object any more.  */
-  if (!provide
-      && h->def_dynamic
-      && !h->def_regular)
+  /* If this symbol is currently defined by a dynamic object, but not
+     by a regular object, then clear out any version information because
+     the symbol will not be associated with the dynamic object any
+     more.  */
+  if (h->def_dynamic && !h->def_regular)
     h->verinfo.verdef = NULL;
 
   /* Make sure this symbol is not garbage collected.  */

What is this

This patch fixes an issue with symbol versioning when using binutils 2.31.1.
In particular, when you try to link binary artifacts created using binutils 2.30+ together with artifacts created using previous versions of binutils, you may get linker errors similar to:

/usr/bin/ld: bin/libKF5Service.so.5.49.0: _edata: invalid version 21 (max 0)
/usr/bin/ld: bin/libKF5Service.so.5.49.0: error adding symbols: bad value

Check if there is a version newer than 2.31.1 released and whether this fix is already incorporated in it (it was not the case on the moment of creating this gist).

Links:

• https://sourceware.org/ml/binutils/2018-08/msg00227.html
• https://bugzilla.redhat.com/show_bug.cgi?id=1599521

Howto:

cd binutils-2.31.1/

# Get this patch
git clone https://gist.github.com/71e6d01abf78d569f698502c4e69e249

# See what it modifies
git apply --stat 71e6d01abf78d569f698502c4e69e249/binutils-bfd-elflink.patch

# Check for errors
git apply --check 71e6d01abf78d569f698502c4e69e249/binutils-bfd-elflink.patch

# Apply
git apply 71e6d01abf78d569f698502c4e69e249/binutils-bfd-elflink.patch