Skip to content

Instantly share code, notes, and snippets.

@iwiznia
Last active December 28, 2015 19:08
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save iwiznia/7547713 to your computer and use it in GitHub Desktop.
Save iwiznia/7547713 to your computer and use it in GitHub Desktop.
ActiveRecord merge test for order of joins
unless File.exists?('Gemfile')
File.write('Gemfile', <<-GEMFILE)
source 'https://rubygems.org'
gem 'rails', github: 'rails/rails'
gem 'sqlite3'
GEMFILE
system 'bundle'
end
require 'bundler'
Bundler.setup(:default)
require 'active_record'
require 'minitest/autorun'
require 'logger'
#require 'debugger'
# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:')
ActiveRecord::Base.logger = Logger.new(STDOUT)
ActiveRecord::Schema.define do
create_table :posts do |t|
end
create_table :comments do |t|
t.integer :post_id
t.string :name
end
end
class Post < ActiveRecord::Base
has_many :comments
end
class Comment < ActiveRecord::Base
belongs_to :post
scope :fails, -> {
parent = Arel::Table.new('other_table')
joins(self.arel_table.join(parent).join_sources)
}
scope :works, -> {
parent = Arel::Table.new('other_table')
joins(self.arel_table.join(parent).join_sources.map(&:to_sql).join(' '))
}
end
class BugTest < MiniTest::Unit::TestCase
def test_joins_on_correct_order_fails
assert_equal Post.joins('INNER JOIN "comments" ON "comments"."post_id" = "posts"."id"').merge(Comment.fails).to_sql, 'SELECT "posts".* FROM "posts" INNER JOIN "comments" ON "comments"."post_id" = "posts"."id" INNER JOIN "other_table"'
end
def test_joins_on_correct_order_works
assert_equal Post.joins(:comments).merge(Comment.fails).to_sql, 'SELECT "posts".* FROM "posts" INNER JOIN "comments" ON "comments"."post_id" = "posts"."id" INNER JOIN "other_table"'
end
def test_joins_on_correct_order_works2
assert_equal Post.joins(:comments).merge(Comment.works).to_sql, 'SELECT "posts".* FROM "posts" INNER JOIN "comments" ON "comments"."post_id" = "posts"."id" INNER JOIN "other_table"'
end
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment