TPT++ cppcheck

cppcheck.txt

[src/Format.cpp:221]: (style) 'struct PNGChunk' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/Format.cpp:216]: (error) Mismatching allocation and deallocation: currentRow
[src/Misc.cpp:85]: (error) Common realloc mistake: 'name' nulled but not freed upon failure
[src/Misc.cpp:65]: (error) Common realloc mistake: 'fn' nulled but not freed upon failure
[src/Misc.cpp:380]: (error) Possible null pointer dereference: AppDataPath
[src/Misc.cpp:391]: (error) Possible null pointer dereference: AppDataPath
[src/gui/game/GameController.h:89] -> [src/gui/game/GameView.h:23]: (style) Variable 'DrawPoints' hides enumerator with same name
[src/gui/game/GameController.h:90] -> [src/gui/game/GameView.h:23]: (style) Variable 'DrawRect' hides enumerator with same name
[src/gui/game/GameController.h:91] -> [src/gui/game/GameView.h:23]: (style) Variable 'DrawLine' hides enumerator with same name
[src/gui/game/GameController.h:92] -> [src/gui/game/GameView.h:23]: (style) Variable 'DrawFill' hides enumerator with same name
[src/gui/game/GameController.h:134] -> [src/gui/game/GameView.h:28]: (style) Variable 'PlaceSave' hides enumerator with same name
[src/PowderToySDL.cpp:799] -> [src/PowderToySDL.cpp:802]: (performance) Variable 'tempScale' is reassigned a value before the old one has been used.
[src/PowderToySDL.cpp:800] -> [src/PowderToySDL.cpp:803]: (performance) Variable 'tempFullscreen' is reassigned a value before the old one has been used.
[src/PowderToySDL.cpp:298]: (style) Unused variable: surface
[src/PowderToySDL.cpp:746]: (style) Variable 'currentY' is assigned a value that is never used.
[src/PowderToySDL.cpp:842]: (style) Variable 'sdlStatus' is assigned a value that is never used.
[src/gui/game/Tool.h:86]: (warning) Member variable 'PropertyTool::propOffset' is not initialized in the constructor.
[src/PowderToySDL.cpp:948]: (performance) Inefficient usage of string::find() in condition; string::compare() would be faster.
[src/client/Client.cpp:1856]: (style) Statements following return, break, continue, goto or throw will never be executed.
[src/client/Client.cpp:1862]: (style) Statements following return, break, continue, goto or throw will never be executed.
[src/client/Client.cpp:69]: (warning) Member variable 'Client::lastStampTime' is not initialized in the constructor.
[src/client/Client.cpp:69]: (warning) Member variable 'Client::lastStampName' is not initialized in the constructor.
[src/client/Client.cpp:69]: (warning) Member variable 'Client::thumbnailCacheNextID' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::waterEEnabled' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::legacyEnable' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::gravityEnable' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::aheatEnable' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::paused' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::gravityMode' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::airMode' is not initialized in the constructor.
[src/client/GameSave.cpp:56]: (warning) Member variable 'GameSave::edgeMode' is not initialized in the constructor.
[src/client/GameSave.cpp:86]: (performance) Variable 'originalData' is assigned in constructor body. Consider performing initialization in initialization list.
[src/client/GameSave.cpp:118]: (performance) Variable 'originalData' is assigned in constructor body. Consider performing initialization in initialization list.
[src/client/GameSave.cpp:150]: (performance) Variable 'originalData' is assigned in constructor body. Consider performing initialization in initialization list.
[src/client/GameSave.cpp:2173]: (error) Mismatching allocation and deallocation: outputData
[src/client/GameSave.cpp:2180]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'.
[src/client/HTTP.cpp:719]: (style) Variable 'm' is assigned a value that is never used.
[src/client/MD5.cpp:112]: (warning) Size of pointer 'ctx' used instead of size of its data.
[src/client/SaveInfo.cpp:5]: (warning) Member variable 'SaveInfo::Favourite' is not initialized in the constructor.
[src/client/SaveInfo.cpp:27]: (warning) Member variable 'SaveInfo::Favourite' is not initialized in the constructor.
[src/client/SaveInfo.cpp:46]: (warning) Member variable 'SaveInfo::Favourite' is not initialized in the constructor.
[src/client/requestbroker/APIRequest.cpp:94]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/client/requestbroker/ImageRequest.cpp:7]: (warning) Member variable 'ImageRequest::RequestTime' is not initialized in the constructor.
[src/client/requestbroker/ImageRequest.cpp:10]: (performance) Variable 'URL' is assigned in constructor body. Consider performing initialization in initialization list.
[src/client/requestbroker/RequestBroker.cpp:206] -> [src/client/requestbroker/RequestBroker.cpp:208]: (performance) Variable 'resultStatus' is reassigned a value before the old one has been used.
[src/client/requestbroker/RequestBroker.cpp:153]: (performance) Possible inefficient checking for 'completeQueue' emptiness.
[src/client/requestbroker/RequestBroker.cpp:75]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/client/requestbroker/RequestBroker.cpp:215]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/client/requestbroker/RequestBroker.cpp:307]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/client/requestbroker/RequestBroker.cpp:317]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/client/requestbroker/WebRequest.cpp:93]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/graphics/OpenGLDrawMethods.inl:138]: (style) Unused variable: i
[src/graphics/OpenGLDrawMethods.inl:138]: (style) Unused variable: j
[src/graphics/OpenGLDrawMethods.inl:138]: (style) Variable 'bn' is assigned a value that is never used.
[src/graphics/OpenGLDrawMethods.inl:138]: (style) Variable 'ba' is assigned a value that is never used.
[src/graphics/OpenGLDrawMethods.inl:168]: (style) Unused variable: i
[src/graphics/OpenGLDrawMethods.inl:168]: (style) Unused variable: j
[src/graphics/OpenGLDrawMethods.inl:168]: (style) Variable 'bn' is assigned a value that is never used.
[src/graphics/OpenGLDrawMethods.inl:168]: (style) Variable 'ba' is assigned a value that is never used.
[src/graphics/OpenGLGraphics.cpp:11]: (warning) Member variable 'Graphics::vid' is not initialized in the constructor.
[src/graphics/RasterDrawMethods.inl:19]: (style) Unused variable: width
[src/graphics/RasterDrawMethods.inl:19]: (style) Unused variable: height
[src/graphics/Graphics.h:181]: (style) 'class Graphics' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/graphics/Renderer.cpp:709]: (style) Checking if unsigned variable 'wt' is less than zero.
[src/graphics/Renderer.cpp:524]: (style) Unused variable: cr
[src/graphics/Renderer.cpp:524]: (style) Unused variable: cg
[src/graphics/Renderer.cpp:524]: (style) Unused variable: cb
[src/graphics/Renderer.cpp:915]: (style) Unused variable: mx
[src/graphics/Renderer.cpp:915]: (style) Unused variable: my
[src/graphics/Renderer.cpp:915]: (style) Variable 'b' is assigned a value that is never used.
[src/graphics/Renderer.cpp:915]: (style) Unused variable: bq
[src/graphics/Renderer.cpp:915]: (style) Unused variable: match
[src/graphics/Renderer.cpp:1007]: (style) Unused variable: nx
[src/graphics/Renderer.cpp:1007]: (style) Unused variable: ny
[src/graphics/Renderer.cpp:1046]: (style) Unused variable: c
[src/graphics/Renderer.cpp:1171]: (style) Variable 'fnx' is assigned a value that is never used.
[src/graphics/Renderer.cpp:1172]: (style) Variable 'fny' is assigned a value that is never used.
[src/graphics/Renderer.h:41]: (style) 'class Renderer' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/graphics/Renderer.cpp:682]: (style) Checking if unsigned variable 'wt' is less than zero.
[src/graphics/Renderer.cpp:670]: (style) Unused variable: i
[src/graphics/Renderer.cpp:670]: (style) Unused variable: j
[src/graphics/Renderer.cpp:685]: (style) Variable 'gc' is assigned a value that is never used.
[src/graphics/Renderer.cpp:915]: (style) Unused variable: j
[src/graphics/Renderer.cpp:1126]: (style) Unused variable: x
[src/graphics/Renderer.cpp:1126]: (style) Unused variable: y
[src/graphics/Renderer.cpp:1374]: (style) Unused variable: legr
[src/graphics/Renderer.cpp:1374]: (style) Unused variable: legg
[src/graphics/Renderer.cpp:1374]: (style) Unused variable: legb
[src/graphics/Renderer.cpp:1590]: (style) Variable 'cola1' is assigned a value that is never used.
[src/graphics/Renderer.cpp:2165]: (style) Unused variable: i
[src/graphics/Renderer.cpp:2165]: (style) Unused variable: j
[src/graphics/Renderer.cpp:2421]: (warning) Member variable 'Renderer::vid' is not initialized in the constructor.
[src/graphics/Renderer.cpp:2421]: (warning) Member variable 'Renderer::persistentVid' is not initialized in the constructor.
[src/graphics/Renderer.cpp:2421]: (warning) Member variable 'Renderer::warpVid' is not initialized in the constructor.
[src/gui/colourpicker/ColourPickerActivity.cpp:143]: (style) Assignment of function parameter has no effect outside the function.
[src/gui/colourpicker/ColourPickerActivity.cpp:233]: (style) Assignment of function parameter has no effect outside the function.
[src/gui/console/ConsoleController.h:13]: (style) 'class ConsoleController' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/dialogues/ConfirmPrompt.cpp:11]: (style) Unused variable: width
[src/gui/dialogues/ConfirmPrompt.cpp:11]: (style) Unused variable: height
[src/gui/dialogues/ConfirmPrompt.cpp:67]: (style) Unused variable: width
[src/gui/dialogues/ConfirmPrompt.cpp:67]: (style) Unused variable: height
[src/gui/game/Brush.cpp:6]: (style) Unused variable: t
[src/gui/game/GameController.cpp:750]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/gui/game/EllipseBrush.h:32]: (style) Unused variable: j
[src/gui/game/GameModel.h:35]: (style) 'class GameModel' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/game/DecorationTool.h:71] -> [src/gui/game/GameView.h:23]: (style) Variable 'DrawLine' hides enumerator with same name
[src/gui/game/DecorationTool.h:74] -> [src/gui/game/GameView.h:23]: (style) Variable 'DrawRect' hides enumerator with same name
[src/gui/game/DecorationTool.h:77] -> [src/gui/game/GameView.h:23]: (style) Variable 'DrawFill' hides enumerator with same name
[src/gui/game/GameView.cpp:327]: (style) Variable 'currentX' is assigned a value that is never used.
[src/gui/game/GameView.cpp:42]: (warning) Member variable 'SplitButton::rightDown' is not initialized in the constructor.
[src/gui/game/GameView.cpp:42]: (warning) Member variable 'SplitButton::leftDown' is not initialized in the constructor.
[src/gui/game/GameView.cpp:930]: (performance) Possible inefficient checking for 'tags' emptiness.
[src/gui/game/GameView.cpp:1084]: (performance) Possible inefficient checking for 'pointQueue' emptiness.
[src/gui/game/GameView.cpp:932]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/gui/game/GameView.cpp:2099]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/gui/interface/ScrollPanel.cpp:138]: (style) Variable 'oldOffsetX' is assigned a value that is never used.
[src/gui/localbrowser/LocalBrowserController.cpp:64]: (performance) Variable 'saves' is assigned in constructor body. Consider performing initialization in initialization list.
[src/gui/localbrowser/LocalBrowserController.h:10]: (style) 'class LocalBrowserController' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/localbrowser/LocalBrowserModel.cpp:70]: (style) Variable 'tempSavesList' is assigned a value that is never used.
[src/gui/localbrowser/LocalBrowserModel.cpp:13]: (performance) Variable 'stampIDs' is assigned in constructor body. Consider performing initialization in initialization list.
[src/gui/login/LoginController.h:14]: (style) 'class LoginController' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/login/LoginModel.cpp:3]: (warning) Member variable 'LoginModel::loginStatus' is not initialized in the constructor.
[src/gui/options/OptionsController.h:12]: (style) 'class OptionsController' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/preview/PreviewController.cpp:95]: (warning) Possible leak in public function. The pointer 'loginWindow' is not deallocated before it is allocated.
[src/gui/preview/PreviewModel.cpp:8]: (warning) Member variable 'PreviewModel::tSaveID' is not initialized in the constructor.
[src/gui/preview/PreviewModel.cpp:8]: (warning) Member variable 'PreviewModel::tSaveDate' is not initialized in the constructor.
[src/gui/preview/PreviewView.cpp:568]: (style) Variable 'usernameY' is assigned a value that is never used.
[src/gui/preview/PreviewView.cpp:592]: (style) Variable 'commentY' is assigned a value that is never used.
[src/gui/render/RenderController.h:11]: (style) 'class RenderController' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/search/SearchController.cpp:245]: (performance) Variable 'saves' is assigned in constructor body. Consider performing initialization in initialization list.
[src/gui/search/SearchController.cpp:298]: (performance) Variable 'saves' is assigned in constructor body. Consider performing initialization in initialization list.
[src/gui/search/SearchController.cpp:331]: (performance) Variable 'saves' is assigned in constructor body. Consider performing initialization in initialization list.
[src/gui/search/SearchController.cpp:356]: (performance) Variable 'saves' is assigned in constructor body. Consider performing initialization in initialization list.
[src/gui/search/SearchController.h:13]: (style) 'class SearchController' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/search/SearchModel.cpp:6]: (warning) Member variable 'SearchModel::thResultCount' is not initialized in the constructor.
[src/gui/search/SearchView.cpp:468]: (style) Unused variable: buttonWidth
[src/gui/search/SearchView.cpp:468]: (style) Unused variable: buttonHeight
[src/gui/search/SearchView.cpp:468]: (style) Variable 'saveX' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:468]: (style) Variable 'saveY' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:468]: (style) Variable 'savesX' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:491]: (style) Variable 'buttonAreaWidth' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:490]: (style) Variable 'buttonXOffset' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:667]: (style) Variable 'tagWidth' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:668]: (style) Variable 'tagHeight' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:576]: (style) Variable 'tagX' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:576]: (style) Variable 'tagY' is assigned a value that is never used.
[src/gui/search/SearchView.cpp:663]: (style) Variable 'tagXOffset' is assigned a value that is never used.
[src/gui/tags/TagsController.h:10]: (style) 'class TagsController' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/gui/tags/TagsView.cpp:91]: (performance) Variable 'tag' is assigned in constructor body. Consider performing initialization in initialization list.
[src/gui/tags/TagsView.cpp:109]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[src/gui/update/UpdateActivity.h:6]: (style) 'class UpdateActivity' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/lua/LegacyLuaAPI.cpp:1870] -> [src/lua/LegacyLuaAPI.cpp:1874]: (performance) Variable 'fileauthor' is reassigned a value before the old one has been used.
[src/lua/LegacyLuaAPI.cpp:1870] -> [src/lua/LegacyLuaAPI.cpp:1875]: (performance) Variable 'fileid' is reassigned a value before the old one has been used.
[src/lua/LegacyLuaAPI.cpp:61]: (style) Unused variable: tempinteger
[src/lua/LegacyLuaAPI.cpp:62]: (style) Unused variable: tempfloat
[src/lua/LegacyLuaAPI.cpp:1264]: (style) Unused variable: nx
[src/lua/LegacyLuaAPI.cpp:1264]: (style) Unused variable: ny
[src/lua/LegacyLuaAPI.cpp:1267]: (style) Variable 'acount' is assigned a value that is never used.
[src/lua/LegacyLuaAPI.cpp:1265]: (style) Unused variable: width
[src/lua/LegacyLuaAPI.cpp:1265]: (style) Unused variable: height
[src/lua/LegacyLuaAPI.cpp:1266]: (style) Unused variable: value
[src/lua/LuaComponent.cpp:9]: (warning) Member variable 'LuaComponent::component' is not initialized in the constructor.
[src/lua/LuaComponent.cpp:9]: (warning) Member variable 'LuaComponent::UserData' is not initialized in the constructor.
[src/lua/LuaScriptInterface.cpp:712]: (style) Unused variable: x
[src/lua/LuaScriptInterface.cpp:712]: (style) Unused variable: y
[src/lua/LuaScriptInterface.cpp:1458]: (style) Unused variable: j
[src/lua/LuaScriptInterface.cpp:3102]: (style) Variable 'len' is assigned a value that is never used.
[src/lua/TPTSTypes.h:17]: (performance) Variable 'exception' is assigned in constructor body. Consider performing initialization in initialization list.
[src/lua/LuaScriptInterface.cpp:1467]: (error) Uninitialized variable: tempfile
[src/lua/LuaWindow.cpp:41]: (warning) Member variable 'LuaWindow::UserData' is not initialized in the constructor.
[src/lua/LuaWindow.h:12]: (style) 'class LuaWindow' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/lua/TPTScriptInterface.cpp:329]: (portability) Casting between integer* and float* which have an incompatible binary data representation.
[src/lua/TPTScriptInterface.cpp:357]: (portability) Casting between integer* and float* which have an incompatible binary data representation.
[src/lua/TPTScriptInterface.cpp:404]: (portability) Casting between integer* and float* which have an incompatible binary data representation.
[src/lua/TPTScriptInterface.cpp:54]: (style) Variable 'retCode' is assigned a value that is never used.
[src/lua/TPTScriptInterface.cpp:209]: (style) Unused variable: commandWords
[src/lua/TPTScriptInterface.cpp:197]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[src/lua/TPTScriptInterface.cpp:381]: (error) Uninitialized variable: type
[src/lua/socket/buffer.c:80]: (style) Variable 'tm' is assigned a value that is never used.
[src/lua/socket/buffer.c:111]: (style) Variable 'tm' is assigned a value that is never used.
[src/lua/socket/inet.c:262]: (portability) scanf without field width limits can crash with huge input data on some versions of libc.
[src/powdertoyjava/OpenGLCanvasWin32.cpp:149] -> [src/powdertoyjava/OpenGLCanvasWin32.cpp:153]: (performance) Variable 'result' is reassigned a value before the old one has been used.
[src/simulation/Air.cpp:355]: (warning) Member variable 'Air::bmap' is not initialized in the constructor.
[src/simulation/Air.cpp:355]: (warning) Member variable 'Air::emap' is not initialized in the constructor.
[src/simulation/Air.cpp:355]: (warning) Member variable 'Air::fvx' is not initialized in the constructor.
[src/simulation/Air.cpp:355]: (warning) Member variable 'Air::fvy' is not initialized in the constructor.
[src/simulation/Gravity.cpp:531]: (warning) Member variable 'Gravity::th_gravchanged' is not initialized in the constructor.
[src/simulation/Gravity.cpp:531]: (warning) Member variable 'Gravity::grav_ready' is not initialized in the constructor.
[src/simulation/Gravity.cpp:531]: (warning) Member variable 'Gravity::gravthread_done' is not initialized in the constructor.
[src/simulation/Gravity.cpp:531]: (warning) Member variable 'Gravity::bmap' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_gravchanged' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::grav_ready' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::gravthread_done' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_ptgravx' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_ptgravy' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_gravmapbig' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_gravxbig' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_gravybig' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_ptgravxt' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_ptgravyt' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_gravmapbigt' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_gravxbigt' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::th_gravybigt' is not initialized in the constructor.
[src/simulation/Gravity.cpp:525]: (warning) Member variable 'Gravity::bmap' is not initialized in the constructor.
[src/simulation/Gravity.cpp:364]: (style) Variable 'changed' is assigned a value that is never used.
[src/simulation/Simulation.cpp:1779]: (portability) Using memset() on struct which contains a floating point number.
[src/simulation/Simulation.cpp:1794]: (portability) Using memset() on struct which contains a floating point number.
[src/simulation/Simulation.cpp:422] -> [src/simulation/Simulation.cpp:423]: (performance) Variable 'x1' is reassigned a value before the old one has been used.
[src/simulation/Simulation.cpp:422] -> [src/simulation/Simulation.cpp:423]: (performance) Variable 'x2' is reassigned a value before the old one has been used.
[src/simulation/Simulation.cpp:3935] -> [src/simulation/Simulation.cpp:3935]: (style) Same expression on both sides of '&&'.
[src/simulation/Simulation.cpp:234]: (style) Variable 'fullW' is assigned a value that is never used.
[src/simulation/Simulation.cpp:235]: (style) Variable 'fullH' is assigned a value that is never used.
[src/simulation/Simulation.cpp:1774]: (style) Unused variable: x
[src/simulation/Simulation.cpp:1774]: (style) Unused variable: y
[src/simulation/Simulation.cpp:3166]: (style) Unused variable: eff_ior
[src/simulation/Simulation.h:33]: (style) 'class Simulation' does not have a copy constructor which is recommended since the class contains a pointer to allocated memory.
[src/simulation/Simulation.cpp:4744]: (style) Variable 'pt' is assigned a value that is never used.
[src/simulation/Simulation.cpp:4744]: (style) Variable 'pc' is assigned a value that is never used.
[src/simulation/Simulation.cpp:4745]: (style) Unused variable: InterThreads
[src/simulation/elements/ACID.cpp:52]: (style) Unused variable: np
[src/simulation/elements/ARAY.cpp:52]: (style) Unused variable: nr
[src/simulation/elements/BANG.cpp:52]: (style) Unused variable: nb
[src/simulation/elements/BMTL.cpp:52]: (style) Unused variable: rt
[src/simulation/elements/BMTL.cpp:52]: (style) Unused variable: tempFactor
[src/simulation/elements/BREC.cpp:52]: (style) Unused variable: np
[src/simulation/elements/BRMT.cpp:52]: (style) Unused variable: rt
[src/simulation/elements/CAUS.cpp:52]: (style) Unused variable: trade
[src/simulation/elements/CAUS.cpp:52]: (style) Unused variable: np
[src/simulation/elements/COAL.cpp:52]: (style) Unused variable: r
[src/simulation/elements/COAL.cpp:52]: (style) Unused variable: rx
[src/simulation/elements/COAL.cpp:52]: (style) Unused variable: ry
[src/simulation/elements/COAL.cpp:52]: (style) Unused variable: trade
[src/simulation/elements/COAL.cpp:52]: (style) Unused variable: temp
[src/simulation/elements/CRAY.cpp:52]: (style) Unused variable: nr
[src/simulation/elements/CRAY.cpp:52]: (style) Unused variable: ry1
[src/simulation/elements/CRAY.cpp:52]: (style) Unused variable: rx1
[src/simulation/elements/CRAY.cpp:81]: (style) Variable 'isBlackDeco' is assigned a value that is never used.
[src/simulation/elements/CRAY.cpp:137]: (style) Variable 'dcolour' is assigned a value that is never used.
[src/simulation/elements/DEST.cpp:52]: (style) Unused variable: topv
[src/simulation/elements/DMG.cpp:52]: (style) Unused variable: nb
[src/simulation/elements/DSTW.cpp:52]: (style) Unused variable: rt
[src/simulation/elements/EMBR.cpp:51]: (style) Unused variable: nb
[src/simulation/elements/EXOT.cpp:52]: (style) Unused variable: nb
[src/simulation/elements/EXOT.cpp:52]: (style) Unused variable: rrx
[src/simulation/elements/EXOT.cpp:52]: (style) Unused variable: rry
[src/simulation/elements/Element.cpp:90]: (style) Unused variable: rt
[src/simulation/elements/FIGH.cpp:128] -> [src/simulation/elements/FIGH.cpp:128]: (style) Same expression on both sides of '||'.
[src/simulation/elements/FWRK.cpp:52]: (style) Unused variable: r
[src/simulation/elements/FWRK.cpp:52]: (style) Unused variable: rx
[src/simulation/elements/FWRK.cpp:52]: (style) Unused variable: ry
[src/simulation/elements/GOLD.cpp:53]: (style) Variable 'blocking' is assigned a value that is never used.
[src/simulation/elements/LIGH.cpp:73]: (style) Variable 'pNear' is assigned a value that is never used.
[src/simulation/elements/NEUT.cpp:74]: (style) Clarify calculation precedence for '%' and '?'.
[src/simulation/elements/PBCN.cpp:55] -> [src/simulation/elements/PBCN.cpp:61]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.
[src/simulation/elements/PIPE.cpp:189]: (style) Variable 'rndstore' is assigned a value that is never used.
[src/simulation/elements/QRTZ.cpp:153]: (style) Variable 't' is assigned a value that is never used.
[src/simulation/elements/SING.cpp:52]: (style) Unused variable: rad
[src/simulation/elements/SING.cpp:52]: (style) Unused variable: nxi
[src/simulation/elements/SING.cpp:52]: (style) Unused variable: nxj
[src/simulation/elements/VIRS.cpp:55] -> [src/simulation/elements/VIRS.cpp:59]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.
[src/simulation/elements/WIRE.cpp:52]: (style) Unused variable: s
[src/tasks/Task.cpp:54] -> [src/tasks/Task.cpp:60]: (performance) Variable 'newDone' is reassigned a value before the old one has been used.
[src/tasks/Task.cpp:55] -> [src/tasks/Task.cpp:61]: (performance) Variable 'newSuccess' is reassigned a value before the old one has been used.
[src/tasks/Task.h:20]: (warning) Member variable 'Task::done' is not initialized in the constructor.
[src/tasks/Task.h:20]: (warning) Member variable 'Task::success' is not initialized in the constructor.
[src/tasks/Task.h:20]: (warning) Member variable 'Task::thDone' is not initialized in the constructor.
[src/tasks/Task.h:20]: (warning) Member variable 'Task::thSuccess' is not initialized in the constructor.
[src/tasks/TaskWindow.cpp:13]: (error) Member variable 'closeOnDone' is initialized by itself.