Skip to content

Instantly share code, notes, and snippets.

@jacksonpires
Forked from anchietajunior/pull_request.md
Last active March 28, 2020 21:20
Show Gist options
  • Save jacksonpires/7faa073b24918de7a4830e98ffec723a to your computer and use it in GitHub Desktop.
Save jacksonpires/7faa073b24918de7a4830e98ffec723a to your computer and use it in GitHub Desktop.
This is a PR template

Pull Request Description

This PR aims to do something (detailed description).

Type (Feature, Fix, Config, etc)

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 🔩
  • This change requires a documentation update 📙
  • Improvement 🌠
  • Refactor 🔄
  • Add Test Specs 🚦

Tests

Tests description

  • Test A
  • Test B

Tests configurations and running:

  • RSpec: 3.0
  • Jest: 3.0
  • Rubocop 0.80.1
  • SCSS Lint 0.59.0
rspec .
yarn test
rubocop
scss-lint

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment