Skip to content

Instantly share code, notes, and snippets.

View jackyu's full-sized avatar

Jack Yu jackyu

  • anue
  • Taiwan, Taipei
View GitHub Profile
@jackyu
jackyu / google-analytics-data-events.js
Created May 29, 2021 08:24 — forked from kevinblake/google-analytics-data-events.js
Fire Google Analytics Events using data attributes for label, action and category fields
var googleDataEvents = {
pageTracker: null,
init: function (document) {
document.find("a[data-ga-label],area[data-ga-label]").click(this.trackLink);
},
trackLink: function (e) {
if (_gaq) {
e.preventDefault();
var l = $(this);
var label = l.attr("data-ga-label");
@jackyu
jackyu / note_code_review_checklist.md
Last active May 8, 2021 09:29 — forked from bigsergey/review-checklist.md
[筆記][CodeReview] Front-end Code Review Checklist

Review checklist

General

  1. Does the code work?
  2. Description of the project status is included.
  3. Code is easily understand.
  4. Code is written following the coding standarts/guidelines (React in our case).
  5. Code is in sync with existing code patterns/technologies.
  6. DRY. Is the same code duplicated more than twice?