Skip to content

Instantly share code, notes, and snippets.

@jamesob
Created June 22, 2018 20:40
Show Gist options
  • Save jamesob/4b68362c5b47c6ce46ea712ebb9995e2 to your computer and use it in GitHub Desktop.
Save jamesob/4b68362c5b47c6ce46ea712ebb9995e2 to your computer and use it in GitHub Desktop.
git diff threadnames2.13..18928a194fa351e07eb808eaea01792ceb1d2093
diff --git a/src/threadutil.cpp b/src/threadutil.cpp
index 0630eff..c558c50 100644
--- a/src/threadutil.cpp
+++ b/src/threadutil.cpp
@@ -50,10 +50,9 @@ std::string thread_util::GetInternalName() {
* Set the in-memory internal name for this thread. Does not affect the process
* name.
*/
-static bool SetInternalName(const std::string& name)
+static void SetInternalName(const std::string& name)
{
g_thread_name = name;
- return true;
}
/**
@@ -66,10 +65,7 @@ std::string thread_util::GetInternalName()
return "";
}
-static bool SetInternalName(const std::string& name)
-{
- return false;
-}
+static void SetInternalName(const std::string& name) { }
#endif
diff --git a/src/threadutil.h b/src/threadutil.h
index 0e23d4b..efff1db 100644
--- a/src/threadutil.h
+++ b/src/threadutil.h
@@ -12,8 +12,6 @@ namespace thread_util
/**
* Rename a thread both in terms of an internal (in-memory) name as well
* as its system thread name.
- *
- * @return whether or not the rename succeeded.
*/
void Rename(const std::string&);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment