Skip to content

Instantly share code, notes, and snippets.

@jarnheimer

jarnheimer/Developers.php

Last active March 21, 2018 13:01
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save jarnheimer/8d97cbbec8a619a8714937fff74acefc to your computer and use it in GitHub Desktop.
Save jarnheimer/8d97cbbec8a619a8714937fff74acefc to your computer and use it in GitHub Desktop.
Download ZIP
Test example
Raw
Developers.php
<?php namespace App;
class Developers
{
function get_best_developer($type)
{
if ($type == 1) { // VueJs
$developer = 'John Smith';
} elseif ($type == 2) { // Laravel
$developer = 'Andrew';
} elseif ($type == 3) { // Servers
$developer = 'Maria';
} elseif ($type == 4) { // Sympfony
$developer = 'Max';
}
return $developer;
}
}
@jarnheimer
Copy link
Author

jarnheimer commented Mar 19, 2018 •
edited

A pull request is made from the branch feature-developer-finder to dev. You will make a code review. The code above is written by a very junior developer, and your task is to give him tips on how this can be improved. What do you say to him?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment