Skip to content

Instantly share code, notes, and snippets.

@jasco
Last active April 18, 2024 18:07
Show Gist options
  • Save jasco/5f742709088f80f07eb2e0d6a141d3f2 to your computer and use it in GitHub Desktop.
Save jasco/5f742709088f80f07eb2e0d6a141d3f2 to your computer and use it in GitHub Desktop.
Workaround for SqlAlchemy Alembic Migrations

Dialect specific migration with Alembic

DDL

Certain SQL dialect specific SQL including triggers and stored procedures are not abstracted away by SqlAlchemy. In those cases SqlAlchemy provides a DDL interface that can be connected to events that conditionally trigger the appropriate dialect specific code.

ddl = sqlalchemy.DDL(custom_pg_trigger)
sqlalchemy.event.listen(MyTable.__table__, "after_create",  ddl.execute_if(dialect="postgresql"))

ddl = sqlalchemy.DDL(custom_sqlite_trigger)
sqlalchemy.event.listen(MyTable.__table__, "after_create",  ddl.execute_if(dialect="sqlite"))

Alembic unfortunately does not recognized a schema change when events are added. The alembic generated changeset can be manually added to the upgrade and downgrade cases:

ddl = sqlachemy.DDL(custom_pg_trigger)
ddl_callable = ddl.execute_if(dialect="postgresql")
ddl_callable(target=None, bind=alembic.get_context().bind)

ddl = sqlachemy.DDL(custom_sqlite_trigger)
ddl_callable = ddl.execute_if(dialect="sqlite")
ddl_callable(target=None, bind=alembic.get_context().bind)

SQLite ALTER DROP COLUMN

SQLite only supports a subset of the SQL ALTER constructs. For certain actions like dropping a table, the accepted workaround is to

  1. create a new table
  2. copy the original table to the new table
  3. drop the old table
  4. rename the new table

Because this is a common pattern, Alembic has a construct that detects operations other than COLUMN ADD (which is supported) on an SQLite database and performs the copy. Unfortunately even if the database is SQLite the condition is not generated automatically, so again the migration must be manually edited.

with op.batch_alter_table('mytable') as batch_op:
    batch_op.drop_column('created_at')
    batch_op.drop_column('updated_at')

SQLite ALTER ADD COLUMN with non-constant DEFAULT

Trying to add a non-null column with a default value of current time results in an error on SQLite with something about a non-static default value. Because the operations are all add_column which is nominally supported by SQLite, the operation will still attempt to use ALTER TABLE rather than a table copy.

# Still fails because uses ALTER TABLE
with op.batch_alter_table('mytable') as batch_op:
    batch_op.add_column(sa.Column('created_at', sa.DateTime(timezone=True), nullable=False, server_default=sa.text(u'CURRENT_TIMESTAMP')))
    batch_op.add_column(sa.Column('updated_at', sa.DateTime(timezone=True), nullable=True))

The work around is to force the table copy by using batch_alter_table with a recreate=always. Unfortunately, it means the table copy will no longer be dialect specific, but at least it works.

 with op.batch_alter_table('user', recreate='always') as batch_op:
    batch_op.add_column(sa.Column('created_at', sa.DateTime(timezone=True), nullable=False, server_default=sa.text(u'CURRENT_TIMESTAMP')))
    batch_op.add_column(sa.Column('updated_at', sa.DateTime(timezone=True), nullable=True))
@kolypto
Copy link

kolypto commented Feb 3, 2021

Thank you, helped me a lot!

@FrostyX
Copy link

FrostyX commented Jun 5, 2022

Thank you, the part about recreate=always was very helpful to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment