Skip to content

Instantly share code, notes, and snippets.

@jasonwebster
Created April 7, 2016 23:38
Show Gist options
  • Save jasonwebster/d0b7660eeac59e31b6bc81b8e36aae8e to your computer and use it in GitHub Desktop.
Save jasonwebster/d0b7660eeac59e31b6bc81b8e36aae8e to your computer and use it in GitHub Desktop.
commit 7a4c485975114f292b78776f513220e33e314c54
Merge: 1302fa4 bee8dab
Author: Jason Webster <jason@metalabdesign.com>
Date: Thu Apr 7 08:39:53 2016 -0700
Merge pull request #2928 from flowapp/remove_coupon_validation
Remove active Stripe subscription requirement from Coupons::Apply
commit 1302fa4bd991eb8088913c9db28ee1d289d6f2e2
Merge: 3060c22 ca6461c
Author: Jason Webster <jason@metalabdesign.com>
Date: Wed Apr 6 19:33:44 2016 -0700
Merge pull request #2925 from flowapp/sync_group_changes
Sync new group creation through websocket
commit bee8dab53aa6fe2712369770c6745277091a2087
Author: Jason Webster <jason@metalabdesign.com>
Date: Wed Apr 6 19:17:14 2016 -0700
Remove active Stripe subscription requirement from Coupons::Apply
We were actually relying on the fact that this validation didn't work properly
to run that entire promotional code & coupon system we built recently. Due to
how many nested transactions there are when this is called from
Organizations::Create, the rollback never makes it up to the top.
We need to have a much longer conversation about never ever ever ever using that
pattern of raising a rollback to enforce validations (and instead just do it the
proper way we've established elsewhere, like Task & List creation).
I've got a much more comprehensive refactoring of the coupon system in progress,
but this temporary fix is necessary in order to grant some discounts to our
current unlimited trial customers.
commit ca6461c294e30a8d2e450a9325840ec4cd1c836f
Author: Ajay <ajay@getflow.com>
Date: Mon Apr 4 17:43:38 2016 -0700
Sync new group creation through websocket
* When ever a new group gets created, the corresponding lists send an update through their websocket sync mechanism. This change adds the ability for a group to send its own sync packet when one gets created.
commit 3060c22f2fee4bd4bdde58948c2f305d124193ea
Merge: 08612c1 e644748
Author: incurito <ajaypromodh@gmail.com>
Date: Wed Apr 6 10:06:32 2016 -0700
Merge pull request #2924 from flowapp/workspaces_get_404
Correctly 404 in GET /workspaces/:id if the account has no role
commit e6447489b4ebf49df9ef2af7752f27940be7d9da
Author: Jason Webster <jason@metalabdesign.com>
Date: Mon Apr 4 15:29:59 2016 -0700
Correctly 404 in GET /workspaces/:id if the account has no role
https://app.getsentry.com/flow/flow-production-api/issues/119841686/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment