jbalboni

{
  "definitions": {
    "VVSPersonIdentifier": {
      "type": "object",
      "required": [
        "assigningAuthority",
        "uniqueId"
      ],
      "properties": {
        "assigningAuthority": {

jbalboni

Feature flags
- Could be a little messy for changes outside of queryies and templates
- Long running changes behind a feature flag can become confusing
- Having multiple feature flags in one query or template could be confusing
- Leaves the build/environment process the same
- Messiness or issues with this approach affects VFS devs more, but it's also easier for us to support day to day
- We'd still need a prod content staging environment
- Much quicker to implement

Integration branch

jbalboni

12:43:16 job.1  | /Users/jbalboni/adhoc/vets-api/app/workers/education_form/create_daily_spool_files.rb:7: warning: already initialized constant EducationForm::WINDOWS_NOTEPAD_LINEBREAK
12:43:16 job.1  | /Users/jbalboni/adhoc/vets-api/app/workers/education_form/create_daily_spool_files.rb:7: warning: previous definition of WINDOWS_NOTEPAD_LINEBREAK was here
12:43:16 job.1  | /Users/jbalboni/adhoc/vets-api/app/workers/education_form/create_daily_spool_files.rb:13: warning: already initialized constant EducationForm::CreateDailySpoolFiles::LIVE_FORM_TYPES
12:43:16 job.1  | /Users/jbalboni/adhoc/vets-api/app/workers/education_form/create_daily_spool_files.rb:13: warning: previous definition of LIVE_FORM_TYPES was here
12:43:16 job.1  | /Users/jbalboni/adhoc/vets-api/lib/backend_services.rb:3: warning: already initialized constant BackendServices::FACILITIES
12:43:16 job.1  | /Users/jbalboni/adhoc/vets-api/lib/backend_services.rb:3: warning: previous definition of FACILITIES was here
12:43:16 job.1  | /Users/jbal

jbalboni

How to use Apple's Voice Over to manually check basic accessibility/usability issues

In addition to automated testing, all of Vets.gov should be manually checked by the sprint teams and then the 508 office. See also: https://help.apple.com/voiceover/info/guide/10.12/#/vo15603

Basic controls quick reference:

VO = control+option (but may vary)

Function	Keyboard command

jbalboni

If they are at the computer and still have the form open on the review page:

On IE11, Windows 8:

1. Click the gear icon in the top right corner of the browser window to open the menu.
2. Click the "F12 Developer Tools" option
3. In the window that pops up that the bottom of the browser window, click the icon on the left hand size that looks like a box with a greater than sign in it (second one down).
4. On the education form, click "Submit Application" again.
5. Have the user read or copy and paste any text that appears underneath the word "Console" in the window at the bottom of the browser.

jbalboni

• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/2416 (Obligatory text update starter task)
• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/2322 (Another text update, but an intro to schemaform codebase)
• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/1465 (Good primer issue on how our site works)
• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/2278 (React, routing issue)
• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/2069 (straightforward, but gets into the weeds of schemaform a little)
• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/1576 (another chore task, but shows how we organize shared schemaform code)
• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/2311 (Might be an ok intro to e2e tests)
• https://github.com/department-of-veterans-affairs/vets.gov-team/issues/2108 (little bit more complicated schemaform refactoring)

jbalboni

Schemaform walkthrough

This walkthrough is going to detail how our form building code (called schemaform from here on) and the library it's built on work. This guide assumes you're comfortable with React and building forms.

JSON Schema

One pre-requisite for understanding how schemaform works is the JSON Schema standard. JSON Schema is a way of describing the allowed shape of JSON objects. There are some good examples to look through on the (http://json-schema.org/examples.html)[JSON Schema site]. Here are some basics:

Schema's have a type, that tells you what kind of data is allowed:

jbalboni

import fullSchema1995 from 'vets-json-schema/dist/change-of-program-schema.json';

const {
  veteranFullName,
  veteranSocialSecurityNumber,
  vaFileNumber
} = fullSchema1995.properties;

const config = {
  defaultDefinitions: fullSchema1995.definitions,

jbalboni

Keybase proof

I hereby claim:

• I am jbalboni on github.
• I am jbalboni (https://keybase.io/jbalboni) on keybase.
• I have a public key whose fingerprint is 1A3E 5606 9A10 0A26 A44A EF37 414F 4105 978E 4AE2

To claim this, I am signing this object:

jbalboni

Form config

Forms are created by creating a page that uses FormApp from the schemaform folder, a form config object, and routes generated from that config file. See src/js/edu-benefits/1995 for an example.

Form config options:

• urlPrefix: Prefix string to add to the path for each page
• introduction: The introduction page component to use. Intro page is skipped if not provided
• confirmation: The confirmation page component to use after form is successfully submitted
• trackingPrefix: The prefix for Google Analytics events that are sent for different form actions
• title: The title of the form. Displayed on all pages