Skip to content

Instantly share code, notes, and snippets.

@jbgo
Created November 1, 2013 20:45
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save jbgo/7271665 to your computer and use it in GitHub Desktop.
Save jbgo/7271665 to your computer and use it in GitHub Desktop.
deprecation warnings in test after upgrading from rails 4.0.0 to 4.0.1
ContactTest
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.247) test: #create when contact is a person should belong to the user.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.266) test: #create when contact is a place should belong to the organization.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.282) test: #create when contact is added to the organization only should belong to the organization.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.299) test: #destroy when contact belongs to a user should be soft destroyed.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.310) test: #destroy when contact belongs to an organization should be soft destroyed.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.324) test: #destroy when we want to destroy a contact no matter what should permanently destroy the contact.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.337) test: #reclassify! when training set does not exist should skip classificaiton.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.376) test: #reclassify! when training set exists should classify the contact.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.379) test: #search_terms should include city and state if an address is present.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.381) test: #search_terms should include name and company.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.396) test: #search_text should update on create.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.397) test: .permit_attributes should permit all attributes except for application managed attributes.
DEPRECATION WARNING: Proc#bind is deprecated and will be removed in future versions. (called from run_test at /Users/jordan/.rvm/rubies/ruby-2.0.0-p247/lib/ruby/2.0.0/test/unit.rb:858)
PASS (0:00:05.399) test: Contact should remove deprecated associations.
ContactTest
PASS (0:00:05.247) test: #create when contact is a person should belong to the user.
PASS (0:00:05.266) test: #create when contact is a place should belong to the organization.
PASS (0:00:05.282) test: #create when contact is added to the organization only should belong to the organization.
PASS (0:00:05.299) test: #destroy when contact belongs to a user should be soft destroyed.
PASS (0:00:05.310) test: #destroy when contact belongs to an organization should be soft destroyed.
PASS (0:00:05.324) test: #destroy when we want to destroy a contact no matter what should permanently destroy the contact.
PASS (0:00:05.337) test: #reclassify! when training set does not exist should skip classificaiton.
PASS (0:00:05.376) test: #reclassify! when training set exists should classify the contact.
PASS (0:00:05.379) test: #search_terms should include city and state if an address is present.
PASS (0:00:05.381) test: #search_terms should include name and company.
PASS (0:00:05.396) test: #search_text should update on create.
PASS (0:00:05.397) test: .permit_attributes should permit all attributes except for application managed attributes.
PASS (0:00:05.399) test: Contact should remove deprecated associations.
source 'https://rubygems.org'
ruby '2.0.0'
gem 'rails', '4.0.1'
gem 'pg'
gem 'sass-rails', '~> 4.0.0'
gem 'uglifier', '>= 1.3.0'
gem 'coffee-rails', '~> 4.0.0'
gem 'jquery-rails'
gem 'turbolinks'
gem 'jbuilder', '~> 1.2'
gem 'cancan'
gem 'devise'
gem 'omniauth-google-oauth2'
gem 'haml'
gem 'contextio'
gem 'unicorn'
gem 'resque'
gem 'resque-scheduler', require: 'resque_scheduler'
gem 'geocoder'
gem 'paper_trail', '>= 3.0.0.beta1'
gem 'kaminari', '~> 0.14.1'
gem 'acts_as_commentable'
gem 'json'
gem 'nbayes',
github: 'oasic/nbayes',
ref: '31c9deb0693f' # The ruby gem is outdated
gem 'vcard_parser',
github: 'jbgo/vcard_parser',
ref: 'address-book-compatibility'
gem 'dotenv-rails', groups: %w(development test)
gem 'rails_admin'
group :development do
gem 'foreman'
gem 'puma'
gem 'better_errors'
gem 'binding_of_caller'
gem 'guard-bundler'
gem 'guard-pow'
gem 'guard-minitest'
gem 'growl'
gem 'pry-rails'
end
group :production do
gem 'rails_12factor'
gem 'newrelic_rpm'
end
group :doc do
gem 'sdoc', require: false
gem 'hanna-nouveau', require: false
end
group :test do
gem 'factory_girl_rails'
gem 'database_cleaner'
gem 'mocha', require: false
gem 'shoulda-context'
gem 'turn'
gem 'vcr'
gem 'webmock', '~> 1.11.0'
gem 'timecop'
gem 'capybara', require: false
gem 'launchy', require: false
gem 'temping'
end
diff --git a/Gemfile b/Gemfile
index 1872c2a..c2f4cff 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,7 +2,7 @@ source 'https://rubygems.org'
ruby '2.0.0'
-gem 'rails', '4.0.0'
+gem 'rails', '4.0.1'
gem 'pg'
gem 'sass-rails', '~> 4.0.0'
gem 'uglifier', '>= 1.3.0'
diff --git a/Gemfile.lock b/Gemfile.lock
index d66d596..5b8ab33 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -15,25 +15,25 @@ GIT
GEM
remote: https://rubygems.org/
specs:
- actionmailer (4.0.0)
- actionpack (= 4.0.0)
- mail (~> 2.5.3)
- actionpack (4.0.0)
- activesupport (= 4.0.0)
+ actionmailer (4.0.1)
+ actionpack (= 4.0.1)
+ mail (~> 2.5.4)
+ actionpack (4.0.1)
+ activesupport (= 4.0.1)
builder (~> 3.1.0)
erubis (~> 2.7.0)
rack (~> 1.5.2)
rack-test (~> 0.6.2)
- activemodel (4.0.0)
- activesupport (= 4.0.0)
+ activemodel (4.0.1)
+ activesupport (= 4.0.1)
builder (~> 3.1.0)
- activerecord (4.0.0)
- activemodel (= 4.0.0)
+ activerecord (4.0.1)
+ activemodel (= 4.0.1)
activerecord-deprecated_finders (~> 1.0.2)
- activesupport (= 4.0.0)
+ activesupport (= 4.0.1)
arel (~> 4.0.0)
activerecord-deprecated_finders (1.0.3)
- activesupport (4.0.0)
+ activesupport (4.0.1)
i18n (~> 0.6, >= 0.6.4)
minitest (~> 4.2)
multi_json (~> 1.3)
@@ -42,7 +42,7 @@ GEM
acts_as_commentable (4.0.1)
addressable (2.3.5)
ansi (1.4.3)
- arel (4.0.0)
+ arel (4.0.1)
atomic (1.1.14)
bcrypt-ruby (3.1.2)
better_errors (1.0.1)
@@ -156,7 +156,7 @@ GEM
minitest (4.7.5)
mocha (0.14.0)
metaclass (~> 0.0.1)
- multi_json (1.8.0)
+ multi_json (1.8.2)
multipart-post (1.2.0)
nested_form (0.3.2)
newrelic_rpm (3.6.7.159)
@@ -199,13 +199,13 @@ GEM
rack
rack-test (0.6.2)
rack (>= 1.0)
- rails (4.0.0)
- actionmailer (= 4.0.0)
- actionpack (= 4.0.0)
- activerecord (= 4.0.0)
- activesupport (= 4.0.0)
+ rails (4.0.1)
+ actionmailer (= 4.0.1)
+ actionpack (= 4.0.1)
+ activerecord (= 4.0.1)
+ activesupport (= 4.0.1)
bundler (>= 1.3.0, < 2.0)
- railties (= 4.0.0)
+ railties (= 4.0.1)
sprockets-rails (~> 2.0.0)
rails_12factor (0.0.2)
rails_serve_static_assets
@@ -227,9 +227,9 @@ GEM
sass-rails (~> 4.0)
rails_serve_static_assets (0.0.1)
rails_stdout_logging (0.0.2)
- railties (4.0.0)
- actionpack (= 4.0.0)
- activesupport (= 4.0.0)
+ railties (4.0.1)
+ actionpack (= 4.0.1)
+ activesupport (= 4.0.1)
rake (>= 0.8.7)
thor (>= 0.18.1, < 2.0)
raindrops (0.12.0)
@@ -276,7 +276,7 @@ GEM
multi_json (~> 1.0)
rack (~> 1.0)
tilt (~> 1.1, != 1.3.0)
- sprockets-rails (2.0.0)
+ sprockets-rails (2.0.1)
actionpack (>= 3.0)
activesupport (>= 3.0)
sprockets (~> 2.8)
@@ -297,7 +297,7 @@ GEM
coffee-rails
turn (0.9.6)
ansi
- tzinfo (0.3.37)
+ tzinfo (0.3.38)
uglifier (2.2.1)
execjs (>= 0.3.0)
multi_json (~> 1.0, >= 1.0.2)
@@ -352,7 +352,7 @@ DEPENDENCIES
pg
pry-rails
puma
- rails (= 4.0.0)
+ rails (= 4.0.1)
rails_12factor
rails_admin
resque
GIT
remote: git://github.com/jbgo/vcard_parser.git
revision: 08a9d67fd61e8e45676e8a4cb3d1f07f40caeca0
ref: address-book-compatibility
specs:
vcard_parser (0.0.8)
GIT
remote: git://github.com/oasic/nbayes.git
revision: 31c9deb0693fb25e8ad02135e89f29c1eba115fa
ref: 31c9deb0693f
specs:
nbayes (0.1.2)
GEM
remote: https://rubygems.org/
specs:
actionmailer (4.0.1)
actionpack (= 4.0.1)
mail (~> 2.5.4)
actionpack (4.0.1)
activesupport (= 4.0.1)
builder (~> 3.1.0)
erubis (~> 2.7.0)
rack (~> 1.5.2)
rack-test (~> 0.6.2)
activemodel (4.0.1)
activesupport (= 4.0.1)
builder (~> 3.1.0)
activerecord (4.0.1)
activemodel (= 4.0.1)
activerecord-deprecated_finders (~> 1.0.2)
activesupport (= 4.0.1)
arel (~> 4.0.0)
activerecord-deprecated_finders (1.0.3)
activesupport (4.0.1)
i18n (~> 0.6, >= 0.6.4)
minitest (~> 4.2)
multi_json (~> 1.3)
thread_safe (~> 0.1)
tzinfo (~> 0.3.37)
acts_as_commentable (4.0.1)
addressable (2.3.5)
ansi (1.4.3)
arel (4.0.1)
atomic (1.1.14)
bcrypt-ruby (3.1.2)
better_errors (1.0.1)
coderay (>= 1.0.0)
erubis (>= 2.6.6)
binding_of_caller (0.7.2)
debug_inspector (>= 0.0.1)
bootstrap-sass (2.3.2.2)
sass (~> 3.2)
builder (3.1.4)
cancan (1.6.10)
capybara (2.1.0)
mime-types (>= 1.16)
nokogiri (>= 1.3.3)
rack (>= 1.0.0)
rack-test (>= 0.5.4)
xpath (~> 2.0)
coderay (1.0.9)
coffee-rails (4.0.0)
coffee-script (>= 2.2.0)
railties (>= 4.0.0.beta, < 5.0)
coffee-script (2.2.0)
coffee-script-source
execjs
coffee-script-source (1.6.3)
contextio (1.6.0)
oauth (~> 0.4.5)
crack (0.4.1)
safe_yaml (~> 0.9.0)
database_cleaner (1.1.1)
debug_inspector (0.0.2)
devise (3.1.0)
bcrypt-ruby (~> 3.0)
orm_adapter (~> 0.1)
railties (>= 3.2.6, < 5)
thread_safe (~> 0.1)
warden (~> 1.2.3)
dotenv (0.9.0)
dotenv-rails (0.9.0)
dotenv (= 0.9.0)
erubis (2.7.0)
execjs (2.0.1)
factory_girl (4.2.0)
activesupport (>= 3.0.0)
factory_girl_rails (4.2.1)
factory_girl (~> 4.2.0)
railties (>= 3.0.0)
faraday (0.8.8)
multipart-post (~> 1.2.0)
ffi (1.9.0)
font-awesome-rails (3.2.1.3)
railties (>= 3.2, < 5.0)
foreman (0.63.0)
dotenv (>= 0.7)
thor (>= 0.13.6)
formatador (0.2.4)
geocoder (1.1.8)
growl (1.0.3)
guard (1.8.3)
formatador (>= 0.2.4)
listen (~> 1.3)
lumberjack (>= 1.0.2)
pry (>= 0.9.10)
thor (>= 0.14.6)
guard-bundler (1.0.0)
bundler (~> 1.0)
guard (~> 1.1)
guard-minitest (1.3.0)
guard (>= 1.8)
minitest (>= 2.1)
guard-pow (1.0.0)
guard (>= 1.1)
haml (4.0.3)
tilt
hanna-nouveau (0.2.2)
haml
rdoc
hashie (2.0.5)
hike (1.2.3)
httpauth (0.2.0)
i18n (0.6.5)
jbuilder (1.5.1)
activesupport (>= 3.0.0)
multi_json (>= 1.2.0)
jquery-rails (3.0.4)
railties (>= 3.0, < 5.0)
thor (>= 0.14, < 2.0)
jquery-ui-rails (4.0.5)
railties (>= 3.1.0)
json (1.8.1)
jwt (0.1.8)
multi_json (>= 1.5)
kaminari (0.14.1)
actionpack (>= 3.0.0)
activesupport (>= 3.0.0)
kgio (2.8.1)
launchy (2.3.0)
addressable (~> 2.3)
listen (1.3.1)
rb-fsevent (>= 0.9.3)
rb-inotify (>= 0.9)
rb-kqueue (>= 0.2)
lumberjack (1.0.4)
mail (2.5.4)
mime-types (~> 1.16)
treetop (~> 1.4.8)
metaclass (0.0.1)
method_source (0.8.2)
mime-types (1.25)
mini_portile (0.5.1)
minitest (4.7.5)
mocha (0.14.0)
metaclass (~> 0.0.1)
multi_json (1.8.2)
multipart-post (1.2.0)
nested_form (0.3.2)
newrelic_rpm (3.6.7.159)
nokogiri (1.6.0)
mini_portile (~> 0.5.0)
oauth (0.4.7)
oauth2 (0.8.1)
faraday (~> 0.8)
httpauth (~> 0.1)
jwt (~> 0.1.4)
multi_json (~> 1.0)
rack (~> 1.2)
omniauth (1.1.4)
hashie (>= 1.2, < 3)
rack
omniauth-google-oauth2 (0.2.1)
omniauth (~> 1.0)
omniauth-oauth2
omniauth-oauth2 (1.1.1)
oauth2 (~> 0.8.0)
omniauth (~> 1.0)
orm_adapter (0.4.0)
paper_trail (3.0.0.beta1)
activerecord (>= 3.0, < 5.0)
pg (0.17.0)
polyglot (0.3.3)
pry (0.9.12.2)
coderay (~> 1.0.5)
method_source (~> 0.8)
slop (~> 3.4)
pry-rails (0.3.2)
pry (>= 0.9.10)
puma (2.6.0)
rack (>= 1.1, < 2.0)
rack (1.5.2)
rack-pjax (0.7.0)
nokogiri (~> 1.5)
rack (~> 1.3)
rack-protection (1.5.0)
rack
rack-test (0.6.2)
rack (>= 1.0)
rails (4.0.1)
actionmailer (= 4.0.1)
actionpack (= 4.0.1)
activerecord (= 4.0.1)
activesupport (= 4.0.1)
bundler (>= 1.3.0, < 2.0)
railties (= 4.0.1)
sprockets-rails (~> 2.0.0)
rails_12factor (0.0.2)
rails_serve_static_assets
rails_stdout_logging
rails_admin (0.5.0)
bootstrap-sass (~> 2.3)
builder (~> 3.1)
coffee-rails (~> 4.0)
font-awesome-rails (~> 3.0)
haml (~> 4.0)
jquery-rails (~> 3.0)
jquery-ui-rails (~> 4.0)
kaminari (~> 0.14)
nested_form (~> 0.3)
rack-pjax (~> 0.7)
rails (~> 4.0.0)
remotipart (~> 1.0)
safe_yaml (~> 0.9)
sass-rails (~> 4.0)
rails_serve_static_assets (0.0.1)
rails_stdout_logging (0.0.2)
railties (4.0.1)
actionpack (= 4.0.1)
activesupport (= 4.0.1)
rake (>= 0.8.7)
thor (>= 0.18.1, < 2.0)
raindrops (0.12.0)
rake (10.1.0)
rb-fsevent (0.9.3)
rb-inotify (0.9.2)
ffi (>= 0.5.0)
rb-kqueue (0.2.0)
ffi (>= 0.5.0)
rdoc (3.12.2)
json (~> 1.4)
redis (3.0.4)
redis-namespace (1.3.1)
redis (~> 3.0.0)
remotipart (1.2.1)
resque (1.22.0)
multi_json (~> 1.0)
redis-namespace (~> 1.0)
sinatra (>= 0.9.2)
vegas (~> 0.1.2)
resque-scheduler (2.0.1)
redis (>= 2.0.1)
resque (>= 1.20.0)
rufus-scheduler
rufus-scheduler (3.0.0)
tzinfo
safe_yaml (0.9.7)
sass (3.2.10)
sass-rails (4.0.0)
railties (>= 4.0.0.beta, < 5.0)
sass (>= 3.1.10)
sprockets-rails (~> 2.0.0)
sdoc (0.3.20)
json (>= 1.1.3)
rdoc (~> 3.10)
shoulda-context (1.1.5)
sinatra (1.4.3)
rack (~> 1.4)
rack-protection (~> 1.4)
tilt (~> 1.3, >= 1.3.4)
slop (3.4.6)
sprockets (2.10.0)
hike (~> 1.2)
multi_json (~> 1.0)
rack (~> 1.0)
tilt (~> 1.1, != 1.3.0)
sprockets-rails (2.0.1)
actionpack (>= 3.0)
activesupport (>= 3.0)
sprockets (~> 2.8)
sqlite3 (1.3.8)
temping (3.2.0)
activerecord (>= 3.1)
activesupport (>= 3.1)
sqlite3 (~> 1.3.7)
thor (0.18.1)
thread_safe (0.1.3)
atomic
tilt (1.4.1)
timecop (0.6.3)
treetop (1.4.15)
polyglot
polyglot (>= 0.3.1)
turbolinks (1.3.0)
coffee-rails
turn (0.9.6)
ansi
tzinfo (0.3.38)
uglifier (2.2.1)
execjs (>= 0.3.0)
multi_json (~> 1.0, >= 1.0.2)
unicorn (4.6.3)
kgio (~> 2.6)
rack
raindrops (~> 0.7)
vcr (2.5.0)
vegas (0.1.11)
rack (>= 1.0.0)
warden (1.2.3)
rack (>= 1.0)
webmock (1.11.0)
addressable (>= 2.2.7)
crack (>= 0.3.2)
xpath (2.0.0)
nokogiri (~> 1.3)
PLATFORMS
ruby
DEPENDENCIES
acts_as_commentable
better_errors
binding_of_caller
cancan
capybara
coffee-rails (~> 4.0.0)
contextio
database_cleaner
devise
dotenv-rails
factory_girl_rails
foreman
geocoder
growl
guard-bundler
guard-minitest
guard-pow
haml
hanna-nouveau
jbuilder (~> 1.2)
jquery-rails
json
kaminari (~> 0.14.1)
launchy
mocha
nbayes!
newrelic_rpm
omniauth-google-oauth2
paper_trail (>= 3.0.0.beta1)
pg
pry-rails
puma
rails (= 4.0.1)
rails_12factor
rails_admin
resque
resque-scheduler
sass-rails (~> 4.0.0)
sdoc
shoulda-context
temping
timecop
turbolinks
turn
uglifier (>= 1.3.0)
unicorn
vcard_parser!
vcr
webmock (~> 1.11.0)
@jbgo
Copy link
Author

jbgo commented Nov 8, 2013

Looks like this has been fixed now: thoughtbot/shoulda-context#36

Also, minitest-spec-rails has a shoulda compatibility layer called mini_shoulda: https://github.com/metaskills/minitest-spec-rails#mini_shoulda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment