Skip to content

Instantly share code, notes, and snippets.

@jcoyne

jcoyne/gist:10388838

Created April 10, 2014 14:33
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save jcoyne/10388838 to your computer and use it in GitHub Desktop.
Save jcoyne/10388838 to your computer and use it in GitHub Desktop.
Download ZIP
Recommendations
Raw
gistfile1.md

  • In CatalogController: author_link, series_link, url_link and subject_link appear to be view helpers and ought to be refactored into a module in app/views/helpers/. https://github.iu.edu/listeam/Blacklight/blob/59ae572f8433bb0d1269e0df7b11557c187d9baa/app/controllers/catalog_controller.rb#L405-L491

  • In CatalogController and Iucat::WebserviceHelper, avoid using instance variables such as (@display_text & @display_line) if you aren’t using these variables in a view.

  • In CatalogController encapsulate the building of @bib_display into its own method. You could consider moving this method into the SolrDocument class and add the results to the document so they could be treated as fields coming out of Solr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment