Release 0.9.15.md

Pull Request Report

[Fix #2719] App does not fit on iPhone X screen (#2856)

URL: status-im/status-mobile#2856 Creator: foopang Labels: Tested - OK, bounty, medium-priority

fixes #2719

I guess we will need another splash image for iPhone X portrait (1125px x 2436px) 🙂

status: ready

[ISSUE #2287] Push Notifications: Use status-go NotifyUsers instead of Notify (#2902)

URL: status-im/status-mobile#2902 Creator: PombeirP Labels: bounty, medium-priority, tech-debt

Fixes #2287

Summary:

This PR updates the react-side code to use Statusgo.NotifyUsers(message, payloadJSON, tokensArray *C.char) instead of Statusgo.Notify(token *C.char).

Review notes:

I've made some temporary changes to logging code and set the payload to some bogus data, so this should be reset before merging to develop.

Testing notes:

In order to test that the unencrypted payload has arrived correctly to the Go side, I changed the following code in geth/api/api.go on my machine: You need to make sure that the LOG_LEVEL_STATUS_GO feature flag is set to at least warn level.

Steps to test:

• Attach to adb logs using adb logcat | grep -e ReactNativeJS -e notifyUsers -e send-notification -e NotifyUsers -e StatusModule
• Open Status
• Open a chat
• Send a message

You should see something similar to the following: There's initially the call to send-notification on the CLJS side, then the fake WARN log message on the geth side, and then the success callback result appearing back on the CLJS side (send-notification cb result: {"status":true}).

On the receiving device, you can see the title and content that come from the CLJS code:

status: ready

[#3006]: No more search features (#3173)

URL: status-im/status-mobile#3173 Creator: alwx Labels: Tested - OK, medium-priority

Fixes #3006

Removes all existing search features, except the ones in discover section (because it will also be removed completely soon).

Arch Linux Support (#3186)

URL: status-im/status-mobile#3186 Creator: azer Labels: developer-xp

Summary

It creates umbrella commands for all Linux packages and adds support for Arch Linux' package manager pacman.

Testing

You can run it inside a Docker with Arch Linux image. I've tested it in Arch before submitting this PR though.

Status: ready

Fix #3013 Swipe chat based deletion (#3192)

URL: status-im/status-mobile#3192 Creator: hanwencheng Labels: bounty

Swipe chat based deletion of chat

If you submit PR for issue with bounty then write here Fixes #NN where NN is issue number

fixes #3013

Summary:

Add pan-responder for inner panel.

Review notes (optional):

• The previous anim/value function is incorrect, so I correct it.
• The touchable-highlight for navigation need to be wrapped inside pan-responoder because:
  1. outside pan-responder will block the move detection
  2. the delete button need to be split from the original button
• As home-list-browser-item-inner-view is introduced from previous commit 7e78acc0cc492951e299b73c83eb0b78d067275d @flexsurfer , now there is only delete-chat handler. It need to be decided how to delete browser item, and then make an animation-container for both home-list-chat-item-inner-view and home-list-browser-item-inner-view, which are out of the topic of this issue.

Steps to test:

• Open Status
• Swipe Console Chat from left to right
• Swipe back or Delete

status: ready

Replace contacts/get-by-id realm read with app-db read (#3212)

URL: status-im/status-mobile#3212 Creator: dmitryn Labels: Tested - OK, medium-priority, tech-debt

Addresses #3210

Summary:

Replace contacts/get-by-id realm read with app-db read as we don't need to touch realm since data is already in app-db.

Review notes:

This is part of further work at status-im/status-mobile#3210 Just starting with changes related to contacts/get-by-id reads so it would be easier to review one change at a time.

Testing notes:

App behavior should not change. Code changed related to parts:

• chat member removed
• chat member left chat
• add contact (success and fail scenarios)

status: ready

Allow app reloading in development mode [FIX #3118] (#3218)

URL: status-im/status-mobile#3218 Creator: audriu Labels: developer-xp

fixes #3118

Summary:Allow app reloading in development mode.

Steps to test:

• Open Status
• Edit code
• RN applications can be reloaded while developing using react-native developer menu.

status: ready

[refs #3210] Replace realm reads for chats with app-db reads (#3225)

URL: status-im/status-mobile#3225 Creator: dmitryn Labels: medium-priority, tech-debt

Addresses #3210 This second part of ongoing work, part 1 is here status-im/status-mobile#3212

Summary:

Replace realm read for chats data with app-db read as we don't need to touch realm since data is already in app-db.

Review notes:

This is part of further work at status-im/status-mobile#3210

Testing notes:

App behavior should not change. Code changed related to interactions with the chats:

• chat created
• member invited
• member removed
• member left
• chat removed

status: ready

Effects should be dumb, without any logic (#3228)

URL: status-im/status-mobile#3228 Creator: janherich Labels: Tested - OK, bug, high-priority, release, tech-debt

Works towards status-im/swarms#74 idea

Summary:

Coeffects/effects should be simple and not contain any logic other then implementation details about how the side effects are actually translated (whether it's direct call, queueing for later processing, batching, etc.) so they can be re-used to maximal extent.

Having actual application logic is them is bad because:

1. They are less re-usable
2. Hard to test

Also, I removed :message-overhead field in chat realm/app-db entity and every logic associated with it. It looks like some relict from older code, we were setting it, but it was never actually red.

As another thing, it fixes #3249

Testing notes (optional):

Chat regression testing

status: ready

Update status-go to develop-g607954bf (#3236)

URL: status-im/status-mobile#3236 Creator: adambabik Labels: Tested - OK

Another update after a bunch of refactoring we did recently.

Changelog (curated):

156bbe19 [#429] fix npe in geth's filter system.
def50018 [#429/partial] Add a patch to fix npe in go-ethereum. (#599)
653da5bc Result of tx processing returned as QueuedTxResult
680d0513 Refactoring of TxQueue and Manager (#530)
c153a60d Clean up whisper log delivery (#555)
0771e7d1 Use single codepath for sending transactions to a local and remote nodes (#527)
bffd2fda Add `Content-Type` to the whisper tests as required in geth 1.7.3. (#553)
f93cd81d Upgrade to geth 1.7.3 and add geth patches (#492)
7ab6a062 [#516] Fix panic based on wrong error in setImmediate function (#535)
21132a44 Remove creating global `_status_catalog` variable

[ISSUE #2883] Migrate wallet/request to latest mockups (#3247)

URL: status-im/status-mobile#3247 Creator: jeluard Labels: Tested - OK, wallet

fixes #2883 fixes #3042 fixes #3220 improves #3196

Summary:

Migrate wallet/request to latest mockups while relying on components.

Steps to test:

• Open Status
• Navigate wallet /
• Screen should work as previously and respect mockups

status: ready

[#3014]: Updated chat input (#3259)

URL: status-im/status-mobile#3259 Creator: alwx Labels:

This PR includes several amazing changes:

1. Removes react-native-emoji-picker;
2. Restyles chat input view to make it match the new design;
3. Adds several cool animations to input field;
4. Refactors some parts. However, (and it's important!) it's not a refactoring PR and I would like not to make some big changes here to structure/refers/etc here.

This is how it looks:

[ISSUE #3208] Removed ContextMenu usage (#3260)

URL: status-im/status-mobile#3260 Creator: jeluard Labels: Tested - OK

fixes #3208 edit: also #3244

Summary:

Moved away from ContextMenu usage

Steps to test:

• Open Status
• Make general sanity check tests
• Validate all ContextMenu have been migrated to popup lists (e.g. in group chat settings - user profile, when showing profile keys)

status: ready

[refs #3210] remove unnecessary reads from Realm for messages (#3265)

URL: status-im/status-mobile#3265 Creator: dmitryn Labels: Tested - OK, tech-debt

Addresses #3210

Summary:

Replace realm read for messages data with app-db read as we don't need to touch realm since data is already in app-db.

Testing notes:

App behavior should not change. Code changed related to messages:

• intro/account creation messages
• regular messages

status: ready

feature #3243 - contact profile screen cleanup (#3266)

URL: status-im/status-mobile#3266 Creator: goranjovic Labels: Tested - OK

fixes #3243

Summary:

Fixes the contact's profile screen:

• removes status and qa screen
• adds back keys

Steps to test:

• Start chatting, then open contact profile

status: ready

[ISSUE #3213] Allow to reset gas details (#3272)

URL: status-im/status-mobile#3272 Creator: jeluard Labels: wallet

fixes #3213

Summary:

Allow to reset gas details to default value

Steps to test:

• Open Status
• Change wallet fee in send screen
• Validate reset button works as expected

status: ready

bug #3232 - fixed profile image setting (#3279)

URL: status-im/status-mobile#3279 Creator: goranjovic Labels: Tested - OK, bug

fixes #3232

Summary:

Fixes bug where profile image can't be set (choosing from gallery does nothing, choosing from camera crashes)

Steps to test:

• Open Profile and try to set profile image from gallery
• Also try to set image with camera

status: ready

Fix broken spec validator for screen params (#3283)

URL: status-im/status-mobile#3283 Creator: foopang Labels:

status: ready

[tests #3281] added/reworked transaction tests (sanity) (#3287)

URL: status-im/status-mobile#3287 Creator: antdanchenko Labels: tests

Added new suite of tests for transactions. The suite will run against each PR:

• C1925 | Send transaction from Wallet screen to contact (via Recent recipients)
• C1935 | Send transaction from Wallet screen to contact (via 'Enter contact code' - STT address)
• C1926 | Request transaction from Wallet screen
• C1927 | Send Request in 1-1 chat. Other user can tap on request and send me ETH. Transaction history shows this transaction
• C1928 | Send Request in Group Chat. Other user can tap on request and send me ETH in Group Chat
• C1936 | Send transaction from 'History' -> 'Unsigned'
• C2076 | Can send ETH in 1:1 chat (by using send command). Transaction history shows this transaction
• C2077 | Can send ETH in Group chat with 2 participants (by using send command)

[ISSUE #3241] Do not use hardcoded gas price (#3288)

URL: status-im/status-mobile#3288 Creator: jeluard Labels: wallet

relates to #3241

Summary:

Rely on geth to access current gas price

Steps to test:

• Open Status
• Navigate wallet / send
• Verify it's not using default hardcoded value

status: ready

clean non-working dapps (#3290)

URL: status-im/status-mobile#3290 Creator: rasom Labels: Tested - OK

fixes #3240

status: ready

Update status-go to develop-g9cc9982a. (#3291)

URL: status-im/status-mobile#3291 Creator: mandrigin Labels: Tested - OK, high-priority

Summary:

commit 9cc9982a6a1c9c8d852a1b567bf933e2eaac548d (HEAD -> develop, upstream/develop)
[#639] Disable filter removal in `go-ethereum`. (#650)

commit 2d964bfe9f9554fdb34c6c19095f3c5e88c527e6
Remove async operations from node manager (#584)

commit 4cddc362acc2e05ad7b0538a7aaf10b7fea2b2ab
Fix all data races in jail package (#632)

commit 00df3ff9f8fcd75074bf2b403db8e7e874617146
[#618] Jail.Call to return valid JSON string based results (#619)

commit d0ef64a177aa609314b0680faf38bd5c80958c62
Maintain local copy of the nonce for each used address (#538)

commit ca719af71c2ecdc793673820a039b46d96e1ec7d
Sync blockchain before running e2e tests on public testnet #568 (#612)

commit ca5a8f666982a516c32740b1635c9fceff2c4fc1
Enable ethereum metrics collection (#616)

status: ready

upgrade rn-camera (attempt to fix #3289) (#3297)

URL: status-im/status-mobile#3297 Creator: rasom Labels: Tested - Issues

fix #3289

status: ready

fix location/phone commands migrations #3256 (#3298)

URL: status-im/status-mobile#3298 Creator: rasom Labels: Tested - OK, bug, release

fixes #3256 fixes #3277 status: ready

bug #3300 - updated leftover sub after rebase (#3302)

URL: status-im/status-mobile#3302 Creator: goranjovic Labels: Tested - OK, bug

fixes #3300

Summary:

Updates the leftover removed sub after rebase,

Steps to test:

• Open Status
• Wallet > Send > Choose recipient

status: ready

Jenkinsfile.release: use BRANCH_NAME (#3303)

URL: status-im/status-mobile#3303 Creator: oskarth Labels:

Jenkinsfile.release should be like in 0.9.13: https://github.com/status-im/status-react/pull/2919/files#diff-ca24b89c55f8d23ebebff270bf89f180

To be cherry-picked @yenda

[FIX] fix apk path for releases (#3306)

URL: status-im/status-mobile#3306 Creator: yenda Labels:

status: ready

[ISSUE #3083] Adapted chat menu to latest mockups (#3308)

URL: status-im/status-mobile#3308 Creator: jeluard Labels:

fixes #3083

Summary:

Adapt chat menu to reflect latest mockups

Steps to test:

• Open Status
• Navigate chat / group chat
• Validate menu reflect mockups

status: ready

Fetch short preview during sending (#3309)

URL: status-im/status-mobile#3309 Creator: janherich Labels: Tested - OK, bug, high-priority, release

fixes #3267

Summary:

Previously, short preview for send command messages was only fetched when last message was mounted in the chat-list (now home) screen, with the logic that it's unnecessary to always fetch short preview because sometimes the message will never be displayed as an last-message in the chat on chat-list (home) screen. With various perf hacks to improve rendering (like having home tab always mounted, etc.), this approach is not reliable, so simple always requesting short preview during the send process works better.

Testing notes (optional):

Test the scenario outlined in issue + make sure that /send and /request commands are still working as intended.

status: ready

[Tests #3284] added sanity profile and browsing tests (#3311)

URL: status-im/status-mobile#3311 Creator: Serhy Labels: tests

Summary:

Added three tests requested in #3284: C1937 | Profile view of contact from list of contacts (like Jarrad profile) C2088 | Can switch network to Rinkeby with upstream. Sign in. Rinkeby with upstream is shown in C2089 | Can open QR code, can share public key

Please note that there is one more test added from #3285: C2082 | Browse link for Open DApp - can open, when closed - new Chat in Home

Revert "upgrade rn-camera (attempt to fix #3289)" (#3323)

URL: status-im/status-mobile#3323 Creator: yenda Labels:

This reverts commit 032c5b42eb6b5ea0cdcab72604fc71022480d45e.

[tests #3282] Added sanity tests for message sending verification (#3324)

URL: status-im/status-mobile#3324 Creator: yevh-berdnyk Labels: tests

Summary:

Added tests for messaging and chat management requested in #3282:

• C1929 | Messaging in 1-1 chat: sending text message, sending emoji, sending text and emoji. Sending text message with new line + C2085 | Can delete 1:1 chat + C1943 | Browse site from link sent in 1-1 chat
• C1930 | Text/emoji Messaging in Group Chat with 3 group chat members
• C1931 | Messaging in public chat

Revert "Merge remote-tracking branch 'origin/develop' into develop" (#3329)

URL: status-im/status-mobile#3329 Creator: yenda Labels:

This reverts commit 6d0681f906c2424845b334035ada46db60ae90c2, reversing changes made to 85ed3b3686a292cbcac2887028d7a6a317bc6c06.

Fix latest nightly -> nigthly migration (#3338)

URL: status-im/status-mobile#3338 Creator: janherich Labels: Tested - OK

fixes #3337

Summary:

This commit just reverts previous migrations clumped into v21 and established new v22 migration with the identical functionality, as it was decided that we will always support commit -> commit migrations (technically nightly -> nightly, but it's not really feasible to rely on that) to better support dogfooding.

Testing notes (optional):

Test the scenario described in the ticket

status: ready

Etherscan api update (#3343)

URL: status-im/status-mobile#3343 Creator: tarekskr Labels: Tested - OK, bounty

Fixes #3294

[ISSUE #3321] Migrated group chat creation flow (#3344)

URL: status-im/status-mobile#3344 Creator: jeluard Labels: Tested - OK

fixes #3321 fixes #3292

Summary:

Migrated group chat creation flow to latest mockups.

Steps to test:

• Open Status
• Create a group chat
• Validate it matches related mockups

status: ready

[FIX #3123] ui: fix network field overflow on long network names in profile (#3345)

URL: status-im/status-mobile#3345 Creator: ikysylevych Labels: Tested - OK, good first issue

fixes #3123

Summary

Introduced proportions between field title and value and ellipsis endings on text overflow.

Note: In case of longer network names, this bug may be probably reproducible even with latest ios/android devices.

status: ready

[ISSUE #3320] Fixed incorrect label (#3347)

URL: status-im/status-mobile#3347 Creator: jeluard Labels: Tested - OK

fixes #3320

Summary:

Fixed incorrect label in wallet / send

Steps to test:

• Open Status
• Navigate wallet / send
• Validate the proper label is used

status: ready

Simplify input handling (#3355)

URL: status-im/status-mobile#3355 Creator: janherich Labels: Tested - OK, clojure, medium-priority, tech-debt

Follow-up on #3309, erasing tech debt.

Summary:

After #3309 was merged, we can rely on command message previews/short previews always being generated before message is actually written into app-db and realm, both when sending and receiving. So it makes no sense to support :cache-data? option when requesting jail data for message and also requesting previews/short-previews when message is mounted in view (unreliable anyway with lazy rendered FlatList + pre-rendering perf hacks). This PR cleans up the unused code associated with that option + removes complicated and redundant request-command-data function/event in the chat.events.input namespace.

Additionally, it cleans the model/message namespace, improving some hard to read code, always making all coeffects pure and never generating random-id/timestamp in event handlers, removing some needless duplication + fixing the request bug where command request marking as answered didn't work as it should (change was propagated to realm only, so the request was answered only once you restarted the app and not immediately after sending the response).

Testing notes (optional):

Test that commands in chats are still working correctly and previews/short-previews are generated without problem in all situations

status: ready

turn off auto capitalization in url text inputs (browser) (#3356)

URL: status-im/status-mobile#3356 Creator: rasom Labels:

There is no issue for this, but this behavior is a bit annoying.

status: ready

Migrate figwheel conf from project.clj to figwheel ns (#3358)

URL: status-im/status-mobile#3358 Creator: voxlet Labels: bounty

Fixes #2999

Summary:

Replaced the figwheel profile :cljsbuild section with the equivalent in figwheel.edn format (along with the config reshaping code in figwheel-api), making sure not to change the behavior of figwheel-api/start.

Review notes (optional):

I erred on the conservative side with the changes, preserving the *-test builds and warning-handler in the android build.

Steps to test:

• Confirm lein figwheel-repl behavior has not changed

status: ready

Returning expandable animations back, removing :get-max-container-area-height (#3367)

URL: status-im/status-mobile#3367 Creator: alwx Labels: Tested - OK

Seems like :get-max-container-area-height became useless not so long ago. More importantly, it now returns incorrect negative value which means all awesome animations introduced here status-im/status-mobile#3259 don't work anymore.

This PR fixes this issue, removes :get-max-container-area-height, introduces some small changes to expandable and make animations work again.

[FIX #3351] chat: fix extra new lines adding in the text input on enter (ios) (#3373)

URL: status-im/status-mobile#3373 Creator: ikysylevych Labels:

Summary:

Concatenation of the input text with a new line symbol "\n" looks exhaustive in iOS. But it may be required in Android. I cannot test Android at this moment. In case it fails in Android maybe we should add a platform check.

status: ready

[TESTS #3344] Updated group chat creation flow (#3374)

URL: status-im/status-mobile#3374 Creator: yevh-berdnyk Labels: tests

Summary:

Updated group chat creation flow in automated tests according to PR #3344

status: ready

[ISSUE #3313] Migrated public chat creation flow (#3381)

URL: status-im/status-mobile#3381 Creator: jeluard Labels: Tested - OK

fixes #3313 fixes #3341

Note that input errors have not been migrated to new paradigm.

Summary:

Migrated public chat creation flow to latest mockups. Also added popup prompt to destructive actions (applies to group chat too)

Steps to test:

• Open Status
• Navigate home tab
• Create a public chat: validates ii follows the mockups

status: ready

Update mailserver node id (#3384)

URL: status-im/status-mobile#3384 Creator: dmitryn Labels: bug, high-priority, offline-inboxing

fixes status-im/status-mobile#3271 status-im/status-mobile#3333

Mailserver nodeID has been changed (looks like it happened during migration to Docker)

Fix wrong derefs (#3389)

URL: status-im/status-mobile#3389 Creator: yenda Labels: bug

note: nothing to test, fix broken develop

status: ready

Revert "Fix #3013 Swipe chat based deletion" (#3390)

URL: status-im/status-mobile#3390 Creator: yenda Labels: bug

This reverts commit f4f1ab4e2fa6beac22765b19dfcf98bcac463253.

The commit is breaking home screen

This is current develop: you can check Branch: PR-3389 Android: https://i.diawi.com/H2GYbu iOS: https://i.diawi.com/gkq9aF

This is this branch: Branch: PR-3390 Android: https://i.diawi.com/QNi99t iOS: https://i.diawi.com/YP8Qoo

I checked at least for Android

Note for testers: no need to test this it's a revert

Status: ready

Removed old dependencies (#3391)

URL: status-im/status-mobile#3391 Creator: jeluard Labels:

Summary:

Removed old dependencies from package-lock.json

status: ready

Improved french translation (#3395)

URL: status-im/status-mobile#3395 Creator: jeluard Labels: translations

Summary:

Update French translation to match latest labels

status: ready

[ISSUE #3396] Fixed incorrect atom access (#3402)

URL: status-im/status-mobile#3402 Creator: jeluard Labels: Tested - OK

fixes #3396

Summary:

Fixed issue when sending empty message

Steps to test:

• Open Status
• Open a chat
• Send an empty message

status: ready

WIP Release 0.9.15 (#3410)

URL: status-im/status-mobile#3410 Creator: jeluard Labels:

Release branch for 0.9.15.

Starting point: cc6414c2040487887fe45259e41ec15276949624

Cherry-picks

status: wip

No messages in group chat after remove participant (#3473)

URL: status-im/status-mobile#3473 Creator: goranjovic Labels:

WIP