Skip to content

Instantly share code, notes, and snippets.

@jeneve
Created June 16, 2016 20:16
Show Gist options
  • Save jeneve/c417bcb8dad80bed8dd7609857d4ab7d to your computer and use it in GitHub Desktop.
Save jeneve/c417bcb8dad80bed8dd7609857d4ab7d to your computer and use it in GitHub Desktop.

Student: Jeneve

Notes:

  • 6 Passing Tests
  • Should test for individual parameter content (specific name, description etc)
  • Good work testing count and response code for delete/create
  • Tests should be more robust with items/information on the page (per user story)
  • First user story is complete except for limiting results to 15 displayed on the page
  • Nice job separating show parameters into variable but should also pull connection into private method to reduce repetition

Evaluation Criteria

Subjective evaluation will be made on your work/process according to the following criteria:

1. Ruby Style

  • 4: Developer writes code that is exceptionally clear and well-factored
  • 3: Developer solves problems with a balance between conciseness and clarity and often extracts logical components
  • 2: Developer writes effective code, but does not breakout logical components
  • 1: Developer writes code with unnecessary variables, operations, or steps which do not increase clarity
  • 0: Developer writes code that is difficult to understand

2. Rails Syntax & API

  • 4: Developer is able to craft Rails features that follow the principles of MVC, push business logic down the stack, and skillfully utilizes ActiveRecord to model application state. Developer can speak to choices made in the code and knows what every line of code is doing.
  • 3: Developer generally writes clean Rails features that make smart use of Ruby, with some struggles in pushing logic down the stack. The application displays good judgement in modeling the problem as data. Developer can speak to choices made in the code and knows what every line of code is doing.
  • 2: Developer struggles with some concepts of MVC. Developer is not confident in what every line of the code is doing or cannot speak to the choices made.
  • 1: Developer struggles with MVC and pushing logic down the stack
  • 0: Developer shows little or no understanding of how to craft Rails applications

3. Testing

  • 4: Developer excels at taking small steps and using the tests for both design and verification. All new lines of code are tested.
  • 3: Developer writes tests that are effective validation of functionality. Most new lines of code are tested.
  • 2: Developer writes tests. Most new lines of code are tested but they aren't effective at testing for functionality and value.
  • 1: Developer is able to write tests, but most new lines of code are not tested.
  • 0: Developer does not use tests.

4. Progression/Completion

  • 4: Developer is able to implement solutions at the speed of a developer.
  • 3: Developer is able to implement solutions at the speed of a junior developer.
  • 2: Developer is able to implement solutions at the speed of an apprentice.
  • 1: Developer struggles to implement solutions at the speed of an apprentice.
  • 0: Developer is not able to implement basic functionality.

5. Workflow

  • 4: Developer commits every 15 minutes
  • 3: Developer commits almost every 15 minutes
  • 2: Developer does not commit regularly
  • 1: Developer has poor git workflow and does not commit regularly
  • 0: Developer committed once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment