Review of Hyku i2 vs i35 vs Hyrax Double Combo

meld-review-results.txt

Again with the markdown.  Imagine if we'd changed the method instead of the views!  Oh well this is one that is in Hyrax as well.  📑  app/views/hyrax/my/collections/_list_collections.html.erb
Again with the markdown.  📑  app/views/hyrax/dashboard/works/_list_works.html.erb
Alters rendering of component's CSS also has some additional logic.  Likely keep.  📑  app/views/catalog/_index_list_default.html.erb
Bring over Hyrax updates but we need version logic  📑  app/assets/javascripts/hyrax/editor.es6
Compare and merge into i35's app/controllers/concerns/hyku/works_controller_behavior.rb  📑  app/controllers/concerns/hyrax/works_controller_behavior.rb
Consider removing as we should have this config section hidden; and wouldn't need another view override.  📑  app/views/hyrax/dashboard/show_admin.html.erb
Consider removing if the underlying flash message bug is fixed  📑  app/views/layouts/hyrax/dashboard.html.erb
Convert to decorator with default image based on Site  📑  app/services/hyrax/thumbnail_path_service.rb
Create a decorator and revisit updating some settings in Hyrax to eliminate need for override.  📑  app/models/hyrax/contact_form.rb
Favor i2  📑  app/views/layouts/hyrax.html.erb
Keep i2  📑  app/views/hyrax/homepage/_recent_document.html.erb
Keep i2  📑  docker-compose.yml
Keep i2 additions  📑  config/routes.rb
Keep i2 additions  📑  spec/controllers/hyrax/homepage_controller_spec.rb
Keep i2 as Hyrax has this but it is different from baseline behavior.  📑  app/views/hyrax/base/_citations.html.erb
Keep i2 as it has caching-busting URL handling  📑  app/views/layouts/homepage.html.erb
Keep i2 as there's a hint we should continue to provide in Hyku prime  📑  app/views/hyrax/admin/users/index.html.erb
Keep i2, as it uses markdown for the title/label.  📑  app/views/hyrax/my/works/_list_works.html.erb
Keep i2, but again what miracles we'd have with presenters that perform the markdown  📑  app/views/hyrax/dashboard/collections/_list_collections.html.erb
Keep i2, but boy howdy are there a lot of things to review  📑  app/views/shared/_appearance_styles.html.erb
Keep i2, but boy should we consider presenter method for title to use markdown  📑  app/views/hyrax/collections/show.html.erb
Keep i2, but boy should we consider presenter method for title to use markdown  📑  app/views/hyrax/dashboard/collections/_collection_title.html.erb
Keep i2, but likely there aren't any chnages  📑  spec/rails_helper.rb
Keep...it's markdown  📑  app/views/hyrax/dashboard/collections/_show_document_list_row.html.erb
Markdown with the title, keep proposed i2  📑  app/views/hyrax/homepage/_explore_collections.html.erb
Probably remove but review the before_action of i2  📑  app/controllers/hyrax/dashboard/profiles_controller.rb
Refactor?  We could make a method for rendering the description and allow both Hyrax and Hyku to have a favored format.  Or simply keep the view partial.  There's likely a more robust markdown rendering soThe presenter could opt to render the title with markdown.  As written this is a carbon copy with a markdown wrapper of the title. Solution to consider.  📑  app/views/hyrax/base/_work_description.erb
Removed file in i2  📑  app/controllers/hyrax/admin/workflow_roles_controller.rb
Removed from i2 as it is only indentation  📑  app/views/hyrax/homepage/_featured.html.erb
Removed from i2 as only differences were comments  📑  app/services/hyrax/analytics/google.rb
Removed from i2 because implementation file is removed as well.  📑  spec/services/hyrax/workflow/permission_query_spec.rb
Removed in i2  📑  app/services/hyrax/workflow/permission_query.rb
Review again as candidate for removal.  📑  app/views/hyrax/homepage/_featured_fields.html.erb
Review as there looks to be a parse error in the unless block  📑  app/views/_logo.html.erb
This is a good addition, and could be backported to Hyrax with some permission management added to reflect what's in Hyku.  📑  app/views/hyrax/batch_edits/_delete_selected.html.erb
This might be a good port back to Hyrax  📑  app/views/hyrax/base/unauthorized.html.erb
This needs a full review for Bootstrap 4 consideration.  📑  app/views/catalog/_search_form.html.erb
Will need to extract configuration in Hyrax to meet features of Hyku  📑  app/helpers/hyrax/file_set_helper.rb
Will need to update to Bootstrap 4 and compare to Hyrax to see if we can extract a helper method for this; and thus remove a view override.  📑  app/views/hyrax/admin/workflows/index.html.erb
Wraps i35 with a markdown call, which then alters how Hyrax behaves.  Could be a partial or whole backport with some helper methods.  📑  app/views/catalog/_index_header_list_collection.html.erb
Wraps i35 with a markdown call, which then alters how Hyrax behaves.  Could be a partial or whole backport with some helper methods.  📑  app/views/catalog/_index_header_list_default.html.erb