Comparing a microformats-ruby RuboCop cleanup diff

_indieweb_microformats-ruby-pr80.md

See microformats/microformats-ruby#80 for details on these files.

bin_microformats.txt

== bin/microformats ==
C:  7:  8: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)
C: 11:  1: Layout/IndentationWidth: Use 2 (not 4) spaces for indentation. (https://github.com/bbatsov/ruby-style-guide#spaces-indentation)
C: 16:  3: Style/UnlessElse: Do not use unless with else. Rewrite these with the positive case first. (https://github.com/bbatsov/ruby-style-guide#no-else-with-unless)
C: 23:  3: Style/UnlessElse: Do not use unless with else. Rewrite these with the positive case first. (https://github.com/bbatsov/ruby-style-guide#no-else-with-unless)

lib_microformats.rb.txt

== lib/microformats.rb ==
C: 25:  7: Style/CommentedKeyword: Do not place comments on the same line as the end keyword.

lib_microformats_absolute_uri.rb.txt

== lib/microformats/absolute_uri.rb ==
C: 12:  5: Metrics/AbcSize: Assignment Branch Condition size for absolutize is too high. [31.11/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 12:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for absolutize is too high. [9/6]
C: 12:  5: Metrics/PerceivedComplexity: Perceived complexity for absolutize is too high. [9/7]

lib_microformats_format_parser.rb.txt

== lib/microformats/format_parser.rb ==
C:  2:  3: Metrics/ClassLength: Class has too many lines. [244/100]
C:  3:  5: Metrics/AbcSize: Assignment Branch Condition size for parse is too high. [402.8/15] (http://c2.com/cgi/wiki?AbcMetric)
C:  3:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse is too high. [108/6]
C:  3:  5: Metrics/MethodLength: Method has too many lines. [199/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C:  3:  5: Metrics/PerceivedComplexity: Perceived complexity for parse is too high. [118/7]
C: 34: 13: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C: 53: 19: Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.
C: 72: 13: Style/CommentedKeyword: Do not place comments on the same line as the end keyword.
C: 85: 13: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C: 93: 13: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C:110: 13: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C:125: 17: Layout/LeadingCommentSpace: Missing space after #. (https://github.com/bbatsov/ruby-style-guide#hash-space)
C:157: 13: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C:165: 13: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C:182: 13: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C:274:  5: Metrics/AbcSize: Assignment Branch Condition size for parse_element is too high. [58.97/15] (http://c2.com/cgi/wiki?AbcMetric)
C:274:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse_element is too high. [15/6]
C:274:  5: Metrics/MethodLength: Method has too many lines. [41/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C:274:  5: Metrics/PerceivedComplexity: Perceived complexity for parse_element is too high. [18/7]
C:295: 15: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C:297: 15: Layout/CommentIndentation: Incorrect indentation detected (column 14 instead of 16).
C:315: 15: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)

lib_microformats_parser.rb.txt

== lib/microformats/parser.rb ==
C: 10:  5: Metrics/AbcSize: Assignment Branch Condition size for parse is too high. [31.45/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 10:  5: Metrics/MethodLength: Method has too many lines. [22/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 60:  5: Metrics/AbcSize: Assignment Branch Condition size for parse_element is too high. [17.38/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 60:  5: Metrics/MethodLength: Method has too many lines. [12/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 81:  7: Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.
C: 84:  5: Metrics/AbcSize: Assignment Branch Condition size for parse_rels is too high. [71.11/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 84:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse_rels is too high. [15/6]
C: 84:  5: Metrics/MethodLength: Method has too many lines. [18/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 84:  5: Metrics/PerceivedComplexity: Perceived complexity for parse_rels is too high. [15/7]

lib_microformats_parser_core.rb.txt

== lib/microformats/parser_core.rb ==
C:  2:  3: Metrics/ClassLength: Class has too many lines. [292/100]
C: 37:  5: Metrics/AbcSize: Assignment Branch Condition size for backcompat_format_classes is too high. [81.86/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 37:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for backcompat_format_classes is too high. [45/6]
C: 37:  5: Metrics/MethodLength: Method has too many lines. [76/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 37:  5: Metrics/PerceivedComplexity: Perceived complexity for backcompat_format_classes is too high. [36/7]
C: 41:  7: Metrics/BlockLength: Block has too many lines. [71/25]
C:139:  5: Metrics/AbcSize: Assignment Branch Condition size for backcompat_property_classes is too high. [184.8/15] (http://c2.com/cgi/wiki?AbcMetric)
C:139:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for backcompat_property_classes is too high. [80/6]
C:139:  5: Metrics/MethodLength: Method has too many lines. [169/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C:139:  5: Metrics/PerceivedComplexity: Perceived complexity for backcompat_property_classes is too high. [89/7]
C:174:  7: Metrics/BlockLength: Block has too many lines. [143/25]

lib_microformats_property_parser.rb.txt

== lib/microformats/property_parser.rb ==
C:  2:  3: Metrics/ClassLength: Class has too many lines. [104/100]
C:  3:  5: Metrics/AbcSize: Assignment Branch Condition size for parse is too high. [111/15] (http://c2.com/cgi/wiki?AbcMetric)
C:  3:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse is too high. [31/6]
C:  3:  5: Metrics/MethodLength: Method has too many lines. [55/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C:  3:  5: Metrics/PerceivedComplexity: Perceived complexity for parse is too high. [36/7]
C: 51: 15: Metrics/BlockNesting: Avoid more than 3 levels of block nesting. (https://github.com/bbatsov/ruby-style-guide#three-is-the-number-thou-shalt-count)
C: 75:  5: Metrics/AbcSize: Assignment Branch Condition size for parse_element is too high. [47.58/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 75:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse_element is too high. [13/6]
C: 75:  5: Metrics/MethodLength: Method has too many lines. [20/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 75:  5: Metrics/PerceivedComplexity: Perceived complexity for parse_element is too high. [15/7]
C: 99:  5: Metrics/AbcSize: Assignment Branch Condition size for render_text_and_replace_images is too high. [33.3/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 99:  5: Metrics/MethodLength: Method has too many lines. [12/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
W: 99: 46: Lint/UnusedMethodArgument: Unused method argument - base. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)
W:104: 28: Lint/ShadowingOuterLocalVariable: Shadowing outer local variable - node.
W:117: 27: Lint/UnusedMethodArgument: Unused method argument - base. (https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars)

lib_microformats_results_collection.txt

== lib/microformats/results/collection.rb ==
C: 52:  5: Metrics/AbcSize: Assignment Branch Condition size for method_missing is too high. [41.4/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 52:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for method_missing is too high. [13/6]
C: 52:  5: Metrics/MethodLength: Method has too many lines. [33/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 52:  5: Metrics/PerceivedComplexity: Perceived complexity for method_missing is too high. [15/7]
C: 52:  5: Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super. (https://github.com/bbatsov/ruby-style-guide#no-method-missing)
C: 95:  5: Metrics/AbcSize: Assignment Branch Condition size for item? is too high. [20.78/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 95:  5: Metrics/MethodLength: Method has too many lines. [13/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)

lib_microformats_results_parser_result.rb.txt

== lib/microformats/results/parser_result.rb ==
C: 42:  5: Metrics/AbcSize: Assignment Branch Condition size for method_missing is too high. [56.09/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 42:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for method_missing is too high. [17/6]
C: 42:  5: Metrics/MethodLength: Method has too many lines. [33/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 42:  5: Metrics/PerceivedComplexity: Perceived complexity for method_missing is too high. [20/7]
C: 42:  5: Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super. (https://github.com/bbatsov/ruby-style-guide#no-method-missing)

lib_microformats_results_property_set.rb.txt

== lib/microformats/results/property_set.rb ==
C: 28:  5: Metrics/AbcSize: Assignment Branch Condition size for method_missing is too high. [21.26/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 28:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for method_missing is too high. [7/6]
C: 28:  5: Metrics/MethodLength: Method has too many lines. [23/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 28:  5: Metrics/PerceivedComplexity: Perceived complexity for method_missing is too high. [10/7]
C: 28:  5: Style/MethodMissing: When using method_missing, define respond_to_missing? and fall back on super. (https://github.com/bbatsov/ruby-style-guide#no-method-missing)

lib_microformats_time_property_parser.rb.txt

== lib/microformats/time_property_parser.rb ==
C:  2:  3: Metrics/ClassLength: Class has too many lines. [141/100]
C:  3:  5: Metrics/AbcSize: Assignment Branch Condition size for parse is too high. [52.5/15] (http://c2.com/cgi/wiki?AbcMetric)
C:  3:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse is too high. [17/6]
C:  3:  5: Metrics/MethodLength: Method has too many lines. [34/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C:  3:  5: Metrics/PerceivedComplexity: Perceived complexity for parse is too high. [19/7]
C: 52:  5: Metrics/AbcSize: Assignment Branch Condition size for parse_element is too high. [59.91/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 52:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse_element is too high. [19/6]
C: 52:  5: Metrics/MethodLength: Method has too many lines. [24/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 52:  5: Metrics/PerceivedComplexity: Perceived complexity for parse_element is too high. [21/7]
C: 53:  7: Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression. (https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals)
C: 82:  5: Metrics/AbcSize: Assignment Branch Condition size for parse_dt is too high. [150.6/15] (http://c2.com/cgi/wiki?AbcMetric)
C: 82:  5: Metrics/CyclomaticComplexity: Cyclomatic complexity for parse_dt is too high. [59/6]
C: 82:  5: Metrics/MethodLength: Method has too many lines. [74/10] (https://github.com/bbatsov/ruby-style-guide#short-methods)
C: 82:  5: Metrics/PerceivedComplexity: Perceived complexity for parse_dt is too high. [49/7]
C:106: 57: Style/IfInsideElse: Convert if nested inside else to elsif.
C:121: 57: Style/IfInsideElse: Convert if nested inside else to elsif.
C:125: 23: Style/DateTime: Prefer Date or Time over DateTime. (https://github.com/bbatsov/ruby-style-guide#date--time)
C:137: 57: Style/IfInsideElse: Convert if nested inside else to elsif.
C:146: 57: Style/IfInsideElse: Convert if nested inside else to elsif.
C:183:  5: Style/RescueStandardError: Avoid rescuing without specifying an error class.

lib_microformats_version.rb.txt

== lib/microformats/version.rb ==
C:  2: 13: Style/MutableConstant: Freeze mutable objects assigned to constants.
C:  2: 13: Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)