Skip to content

Instantly share code, notes, and snippets.

@jhuska

jhuska/xhrhalter.adoc

Last active August 29, 2015 14:06
Show Gist options
  • Save jhuska/95fbe6169b4f1e2dce07 to your computer and use it in GitHub Desktop.
Save jhuska/95fbe6169b4f1e2dce07 to your computer and use it in GitHub Desktop.
Download ZIP
XHRHalter Alpha2
Raw
xhrhalter.adoc

  1. Enum XHRState:

    1. Ma to simulovat XHRRequest state ? + nejake dalsie stavy navyse, ktore su potrebne k implementacii ?

    2. Ak ano tak v specifikacii sa tie stavy volaju trocha inak.

  2. Zjednotenie AjaxHalter vs. XHRHalter

    1. Premenoval som XHRHalter interface na AjaxHalter, z toho isteho dovodu, preco bolo premenovany guardXHR na guarAjax. Chceme to ? Alebo to je taka low-level featura ze nam to nevadi ?

    2. Ak chceme pouzivat AjaxHalter, bolo by fajn keby zjednotime, upravime nazvy tried v baliku: https://github.com/arquillian/arquillian-graphene/tree/ARQGRA-86/impl/src/main/java/org/jboss/arquillian/graphene/page/interception a taktiez nazov JS suboru a objektu: https://github.com/arquillian/arquillian-graphene/blob/ARQGRA-86/impl/src/main/javascript/Graphene.Page.XHRHalter.js

  3. Je AjaxHalter.getHandleBlocking(); dostatocne intuitivne meno metody ?

    1. staci v tom to pripade JavaDoc ?

    2. getRequestHandleBlocking() by bolo prilis dlhe ?

    3. alebo co tak vymenit mena metod, getHandle a getHandleBlocking na: getHandle() a getHandleNonBlocking() ?

    4. ma nejaky use case metoda getHandle ? V RF testoch sa nepouziva.

@lfryc
Copy link

lfryc commented Sep 22, 2014

(1) pojmenovat dle standardu a ponechat stavy, ktere jsou navic

(2) sjednotit bez vyjimky

(3) *Blocking vyjadruje, ze ta metoda blokuje dokud nebude nejaky handle k dispozici, mas pravdu, ze je to neintuitivni - je obtainHandleSynchronously() lepsi? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment