Created
May 19, 2021 16:46
-
-
Save jillr/f2a01a25cc902a1a89194a2dccecf749 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11:38 < pabelanger> it is the COLLECTION_PATH that is wrong | |
11:38 < pabelanger> in galaxy-importer | |
11:38 < pabelanger> we likely need to override that to use ~/.ansible/collections/ansible_collections | |
11:42 < pabelanger> yah, we may need to patch galaxy-importer so we can pass our own colleciton path | |
11:44 <@jillr> pabelanger: ok, I'm going to hold off on a pr to just generally set the path in ansible-galaxy-importer/run.yaml then | |
11:45 < pabelanger> jillr: quick look at code says that might not work | |
11:45 < pabelanger> we should ask the galaxy folk how they deal with it on AH | |
11:46 <@jillr> ack | |
11:47 <@jillr> well, for AH wouldn't they only be testing the built collection? | |
11:47 <@jillr> like, after collection_prep/add_docs.py has been run already | |
11:47 <@jillr> that's a manual step for cloud collection releases | |
11:47 < pabelanger> I am not sure TBH | |
11:48 < felixfontein> isn't the built documentation .rst and thus not used by AH anyway (because it only handles MD)? | |
11:52 < tadeboro> felixfontein: AH probably still uses rst for reference docs. md is what should contain scenario guides and other info. | |
11:58 < felixfontein> tadeboro: ok, that's even more... confusing. | |
12:00 < pabelanger> jillr: so if we install the collections into ansible_collections/placeholder_namespace/placeholder_name, it might work | |
12:00 < pabelanger> but not sure | |
12:01 < pabelanger> galaxy team should be able to help here | |
12:03 <@jillr> pabelanger: ok so I need to ping the galaxy team and find out how they test docs on AH? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment