Skip to content

Instantly share code, notes, and snippets.

@jimmyc1987
Last active July 23, 2019 04:28
Show Gist options
  • Save jimmyc1987/5ed764c56d5f75917a5702881d8c1823 to your computer and use it in GitHub Desktop.
Save jimmyc1987/5ed764c56d5f75917a5702881d8c1823 to your computer and use it in GitHub Desktop.
pr template

⚠️ NOTE: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; new or removed environment variables; reasons for why the PR is on hold; or anything else you would like to draw attention to

Definition of done checklist (some items may not be applicable)

  • Tested on Android and iOS
  • Tested on small and large screens
  • English i18n is tested and done
  • Signed off by a designer (deisgners name)
  • Requested code review (use Ready for code review tag)
    • Code review completed (developers name)
  • Requested testing (use Ready for testing tag)
    • Signed off by tester (testers name)

Build number & git tag

Provide the git tag and iOS build number will be used to identify the build that will be tested

Description

A few sentences describing the overall goals of the pull request's commits. What is the current behavior of the app? What is the updated/expected behavior with this PR?

List issues that have been addressed in this PR

e.g. #616, #616, #616.

Referencing issues in commits

Please reference the issue you fix in the corresponding commit. e.g. Fixes #616 or Fix #616 or fixed #616.

Full list can be found https://help.github.com/articles/closing-issues-using-keywords/

Before & After Screenshots (if needed)

BEFORE: [insert screenshot here]

AFTER: [insert screenshot here]

Other changes (e.g. bug fixes, UI tweaks, refactors)

Descriptions of minor changes here.

Todos

Fill out or remove list items as needed

  • Tests
  • Documentation

Deploy Notes

Notes regarding deployment of the contained body of work. These should note any new dependencies, new scripts, etc.

New scripts:

  • script : script details

New dependencies:

  • dependency : dependency details

New dev dependencies:

  • dependency : dependency details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment