Created
July 7, 2019 13:39
-
-
Save jkrems/7ff6e9b755288f806eefb11010935bc3 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> make -j4 | |
/Applications/Xcode-beta.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=0 | |
LD_LIBRARY_PATH=/Users/jkrems/Projects/node/node/out/Release/lib.host:/Users/jkrems/Projects/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /Users/jkrems/Projects/node/node/out/Release/obj/gen; python tools/js2c.py lib/internal/bootstrap/environment.js lib/internal/bootstrap/loaders.js lib/internal/bootstrap/node.js lib/internal/bootstrap/pre_execution.js lib/internal/per_context/primordials.js lib/internal/per_context/setup.js lib/internal/per_context/domexception.js lib/async_hooks.js lib/assert.js lib/buffer.js lib/child_process.js lib/console.js lib/constants.js lib/crypto.js lib/cluster.js lib/dgram.js lib/dns.js lib/domain.js lib/events.js lib/fs.js lib/http.js lib/http2.js lib/_http_agent.js lib/_http_client.js lib/_http_common.js lib/_http_incoming.js lib/_http_outgoing.js lib/_http_server.js lib/https.js lib/inspector.js lib/module.js lib/net.js lib/os.js lib/path.js lib/perf_hooks.js lib/process.js lib/punycode.js lib/querystring.js lib/readline.js lib/repl.js lib/stream.js lib/_stream_readable.js lib/_stream_writable.js lib/_stream_duplex.js lib/_stream_transform.js lib/_stream_passthrough.js lib/_stream_wrap.js lib/string_decoder.js lib/sys.js lib/timers.js lib/tls.js lib/_tls_common.js lib/_tls_wrap.js lib/trace_events.js lib/tty.js lib/url.js lib/util.js lib/v8.js lib/vm.js lib/worker_threads.js lib/zlib.js lib/internal/assert.js lib/internal/assert/assertion_error.js lib/internal/async_hooks.js lib/internal/buffer.js lib/internal/cli_table.js lib/internal/child_process.js lib/internal/cluster/child.js lib/internal/cluster/master.js lib/internal/cluster/round_robin_handle.js lib/internal/cluster/shared_handle.js lib/internal/cluster/utils.js lib/internal/cluster/worker.js lib/internal/console/constructor.js lib/internal/console/global.js lib/internal/crypto/certificate.js lib/internal/crypto/cipher.js lib/internal/crypto/diffiehellman.js lib/internal/crypto/hash.js lib/internal/crypto/keygen.js lib/internal/crypto/keys.js lib/internal/crypto/pbkdf2.js lib/internal/crypto/random.js lib/internal/crypto/scrypt.js lib/internal/crypto/sig.js lib/internal/crypto/util.js lib/internal/constants.js lib/internal/dgram.js lib/internal/dns/promises.js lib/internal/dns/utils.js lib/internal/dtrace.js lib/internal/encoding.js lib/internal/errors.js lib/internal/error-serdes.js lib/internal/fixed_queue.js lib/internal/freelist.js lib/internal/freeze_intrinsics.js lib/internal/fs/promises.js lib/internal/fs/read_file_context.js lib/internal/fs/streams.js lib/internal/fs/sync_write_stream.js lib/internal/fs/utils.js lib/internal/fs/watchers.js lib/internal/http.js lib/internal/idna.js lib/internal/inspector_async_hook.js lib/internal/js_stream_socket.js lib/internal/linkedlist.js lib/internal/main/check_syntax.js lib/internal/main/eval_string.js lib/internal/main/eval_stdin.js lib/internal/main/inspect.js lib/internal/main/print_bash_completion.js lib/internal/main/print_help.js lib/internal/main/prof_process.js lib/internal/main/repl.js lib/internal/main/run_main_module.js lib/internal/main/run_third_party_main.js lib/internal/main/worker_thread.js lib/internal/modules/cjs/helpers.js lib/internal/modules/cjs/loader.js lib/internal/modules/esm/loader.js lib/internal/modules/esm/create_dynamic_module.js lib/internal/modules/esm/default_resolve.js lib/internal/modules/esm/module_job.js lib/internal/modules/esm/module_map.js lib/internal/modules/esm/translators.js lib/internal/net.js lib/internal/options.js lib/internal/policy/manifest.js lib/internal/policy/sri.js lib/internal/priority_queue.js lib/internal/process/esm_loader.js lib/internal/process/execution.js lib/internal/process/main_thread_only.js lib/internal/process/per_thread.js lib/internal/process/policy.js lib/internal/process/promises.js lib/internal/process/stdio.js lib/internal/process/warning.js lib/internal/process/worker_thread_only.js lib/internal/process/report.js lib/internal/process/task_queues.js lib/internal/querystring.js lib/internal/readline.js lib/internal/repl.js lib/internal/repl/await.js lib/internal/repl/history.js lib/internal/repl/utils.js lib/internal/socket_list.js lib/internal/test/binding.js lib/internal/timers.js lib/internal/tls.js lib/internal/trace_events_async_hooks.js lib/internal/tty.js lib/internal/url.js lib/internal/util.js lib/internal/util/comparisons.js lib/internal/util/debuglog.js lib/internal/util/inspect.js lib/internal/util/inspector.js lib/internal/util/types.js lib/internal/http2/core.js lib/internal/http2/compat.js lib/internal/http2/util.js lib/internal/v8_prof_polyfill.js lib/internal/v8_prof_processor.js lib/internal/validators.js lib/internal/stream_base_commons.js lib/internal/vm/source_text_module.js lib/internal/worker.js lib/internal/worker/io.js lib/internal/streams/lazy_transform.js lib/internal/streams/async_iterator.js lib/internal/streams/buffer_list.js lib/internal/streams/duplexpair.js lib/internal/streams/legacy.js lib/internal/streams/destroy.js lib/internal/streams/state.js lib/internal/streams/pipeline.js lib/internal/streams/end-of-stream.js deps/v8/tools/splaytree.js deps/v8/tools/codemap.js deps/v8/tools/consarray.js deps/v8/tools/csvparser.js deps/v8/tools/profile.js deps/v8/tools/profile_view.js deps/v8/tools/logreader.js deps/v8/tools/arguments.js deps/v8/tools/tickprocessor.js deps/v8/tools/SourceMap.js deps/v8/tools/tickprocessor-driver.js deps/node-inspect/lib/_inspect.js deps/node-inspect/lib/internal/inspect_client.js deps/node-inspect/lib/internal/inspect_repl.js deps/acorn/acorn/dist/acorn.js deps/acorn/acorn-walk/dist/walk.js deps/acorn-plugins/acorn-bigint/index.js deps/acorn-plugins/acorn-class-fields/index.js deps/acorn-plugins/acorn-numeric-separator/index.js deps/acorn-plugins/acorn-private-class-elements/index.js deps/acorn-plugins/acorn-private-methods/index.js deps/acorn-plugins/acorn-static-class-features/index.js config.gypi tools/js2c_macros/check_macros.py tools/js2c_macros/nodcheck_macros.py --target "/Users/jkrems/Projects/node/node/out/Release/obj/gen/node_javascript.cc" | |
touch f781774cdc13b7b21f27e10610b84ee116182b00.intermediate | |
touch 5fdce13b7e1e87c080581d733c32bbdee2685958.intermediate | |
LD_LIBRARY_PATH=/Users/jkrems/Projects/node/node/out/Release/lib.host:/Users/jkrems/Projects/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; mkdir -p /Users/jkrems/Projects/node/node/out/Release/obj/gen/src/node/inspector/protocol; python tools/inspector_protocol/code_generator.py --jinja_dir tools/inspector_protocol --output_base "/Users/jkrems/Projects/node/node/out/Release/obj/gen/src/" --config src/inspector/node_protocol_config.json | |
LD_LIBRARY_PATH=/Users/jkrems/Projects/node/node/out/Release/lib.host:/Users/jkrems/Projects/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../tools/v8_gypfiles; mkdir -p /Users/jkrems/Projects/node/node/out/Release/obj/gen/torque-output-root/torque-generated; "/Users/jkrems/Projects/node/node/out/Release/torque" ../../deps/v8/src/builtins/base.tq ../../deps/v8/src/builtins/growable-fixed-array.tq ../../deps/v8/src/builtins/frames.tq ../../deps/v8/src/builtins/arguments.tq ../../deps/v8/src/builtins/array.tq ../../deps/v8/src/builtins/array-copywithin.tq ../../deps/v8/src/builtins/array-every.tq ../../deps/v8/src/builtins/array-filter.tq ../../deps/v8/src/builtins/array-find.tq ../../deps/v8/src/builtins/array-findindex.tq ../../deps/v8/src/builtins/array-foreach.tq ../../deps/v8/src/builtins/array-join.tq ../../deps/v8/src/builtins/array-lastindexof.tq ../../deps/v8/src/builtins/array-of.tq ../../deps/v8/src/builtins/array-map.tq ../../deps/v8/src/builtins/array-reduce.tq ../../deps/v8/src/builtins/array-reduce-right.tq ../../deps/v8/src/builtins/array-reverse.tq ../../deps/v8/src/builtins/array-shift.tq ../../deps/v8/src/builtins/array-slice.tq ../../deps/v8/src/builtins/array-some.tq ../../deps/v8/src/builtins/array-splice.tq ../../deps/v8/src/builtins/array-unshift.tq ../../deps/v8/src/builtins/collections.tq ../../deps/v8/src/builtins/data-view.tq ../../deps/v8/src/builtins/extras-utils.tq ../../deps/v8/src/builtins/iterator.tq ../../deps/v8/src/builtins/object-fromentries.tq ../../deps/v8/src/builtins/proxy.tq ../../deps/v8/src/builtins/proxy-constructor.tq ../../deps/v8/src/builtins/proxy-revocable.tq ../../deps/v8/src/builtins/proxy-revoke.tq ../../deps/v8/src/builtins/regexp.tq ../../deps/v8/src/builtins/regexp-replace.tq ../../deps/v8/src/builtins/string-endswith.tq ../../deps/v8/src/builtins/string-html.tq ../../deps/v8/src/builtins/string-repeat.tq ../../deps/v8/src/builtins/string-startswith.tq ../../deps/v8/src/builtins/typed-array.tq ../../deps/v8/src/builtins/typed-array-createtypedarray.tq ../../deps/v8/src/builtins/typed-array-every.tq ../../deps/v8/src/builtins/typed-array-filter.tq ../../deps/v8/src/builtins/typed-array-find.tq ../../deps/v8/src/builtins/typed-array-findindex.tq ../../deps/v8/src/builtins/typed-array-foreach.tq ../../deps/v8/src/builtins/typed-array-reduce.tq ../../deps/v8/src/builtins/typed-array-reduceright.tq ../../deps/v8/src/builtins/typed-array-slice.tq ../../deps/v8/src/builtins/typed-array-some.tq ../../deps/v8/src/builtins/typed-array-subarray.tq ../../deps/v8/third_party/v8/builtins/array-sort.tq -o "/Users/jkrems/Projects/node/node/out/Release/obj/gen/torque-output-root/torque-generated" | |
touch 7fc01641bb1c2d55013a0310d69b07f9084caec7.intermediate | |
LD_LIBRARY_PATH=/Users/jkrems/Projects/node/node/out/Release/lib.host:/Users/jkrems/Projects/node/node/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../tools/v8_gypfiles; mkdir -p /Users/jkrems/Projects/node/node/out/Release/obj/gen/inspector-generated-output-root/include/inspector /Users/jkrems/Projects/node/node/out/Release/obj/gen/inspector-generated-output-root/src/inspector/protocol; python ../../deps/v8/third_party/inspector_protocol/code_generator.py --jinja_dir ../../deps/v8/third_party --output_base "/Users/jkrems/Projects/node/node/out/Release/obj/gen/inspector-generated-output-root/src/inspector" --config ../../deps/v8/src/inspector/inspector_protocol_config.json | |
c++ -o /Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/module_wrap.o ../src/module_wrap.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-DNODE_REPORT' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' -I../src -I/Users/jkrems/Projects/node/node/out/Release/obj/gen -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/include -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/http_parser -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/brotli/c/include -I../deps/openssl/openssl/include -Os -gdwarf-2 -mmacosx-version-min=10.10 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/jkrems/Projects/node/node/out/Release/.deps//Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/module_wrap.o.d.raw -I/usr/local/include -c | |
c++ -o /Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/node_credentials.o ../src/node_credentials.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-DNODE_REPORT' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' -I../src -I/Users/jkrems/Projects/node/node/out/Release/obj/gen -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/include -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/http_parser -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/brotli/c/include -I../deps/openssl/openssl/include -Os -gdwarf-2 -mmacosx-version-min=10.10 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/jkrems/Projects/node/node/out/Release/.deps//Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/node_credentials.o.d.raw -I/usr/local/include -c | |
c++ -o /Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/node_domain.o ../src/node_domain.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-DNODE_REPORT' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' -I../src -I/Users/jkrems/Projects/node/node/out/Release/obj/gen -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/include -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/http_parser -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/brotli/c/include -I../deps/openssl/openssl/include -Os -gdwarf-2 -mmacosx-version-min=10.10 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/jkrems/Projects/node/node/out/Release/.deps//Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/node_domain.o.d.raw -I/usr/local/include -c | |
c++ -o /Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/node_env_var.o ../src/node_env_var.cc '-DV8_DEPRECATION_WARNINGS' '-DV8_IMMINENT_DEPRECATION_WARNINGS' '-D_DARWIN_USE_64_BIT_INODE=1' '-DOPENSSL_THREADS' '-DNODE_ARCH="x64"' '-DNODE_WANT_INTERNALS=1' '-DV8_DEPRECATION_WARNINGS=1' '-DNODE_OPENSSL_SYSTEM_CERT_PATH=""' '-DHAVE_INSPECTOR=1' '-DHAVE_DTRACE=1' '-DNODE_REPORT' '-D__POSIX__' '-DNODE_USE_V8_PLATFORM=1' '-DNODE_HAVE_I18N_SUPPORT=1' '-DNODE_HAVE_SMALL_ICU=1' '-DNODE_PLATFORM="darwin"' '-DHAVE_OPENSSL=1' '-DUCONFIG_NO_SERVICE=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=1' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DHTTP_PARSER_STRICT=0' '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-DNGHTTP2_STATICLIB' -I../src -I/Users/jkrems/Projects/node/node/out/Release/obj/gen -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/include -I/Users/jkrems/Projects/node/node/out/Release/obj/gen/src -I../deps/histogram/src -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common -I../deps/zlib -I../deps/http_parser -I../deps/llhttp/include -I../deps/cares/include -I../deps/uv/include -I../deps/nghttp2/lib/includes -I../deps/brotli/c/include -I../deps/openssl/openssl/include -Os -gdwarf-2 -mmacosx-version-min=10.10 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -Werror=undefined-inline -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++1y -stdlib=libc++ -fno-rtti -fno-exceptions -fno-strict-aliasing -MMD -MF /Users/jkrems/Projects/node/node/out/Release/.deps//Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/node_env_var.o.d.raw -I/usr/local/include -c | |
In file included from ../src/module_wrap.cc:1: | |
In file included from ../src/module_wrap.h:6: | |
In file included from /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/unordered_map:369: | |
In file included from /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:16: | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:1805:31: error: no | |
matching constructor for initialization of 'std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>' | |
::new((void*)__p) _Up(_VSTD::forward<_Args>(__args)...); | |
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:1715:18: note: in | |
instantiation of function template specialization | |
'std::__1::allocator<std::__1::__hash_node<std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, void *> >::construct<std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, const std::__1::basic_string<char> &, node::loader::PackageConfig>' requested here | |
{__a.construct(__p, _VSTD::forward<_Args>(__args)...);} | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:1561:14: note: in | |
instantiation of function template specialization | |
'std::__1::allocator_traits<std::__1::allocator<std::__1::__hash_node<std::__1::__hash_value_type<std::__1::basic_string<char>, | |
const node::loader::PackageConfig>, void *> > >::__construct<std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, const std::__1::basic_string<char> &, node::loader::PackageConfig>' requested here | |
{__construct(__has_construct<allocator_type, _Tp*, _Args...>(), | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:2305:20: note: | |
in instantiation of function template specialization | |
'std::__1::allocator_traits<std::__1::allocator<std::__1::__hash_node<std::__1::__hash_value_type<std::__1::basic_string<char>, | |
const node::loader::PackageConfig>, void *> > >::construct<std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, const std::__1::basic_string<char> &, node::loader::PackageConfig>' requested here | |
__node_traits::construct(__na, _NodeTypes::__get_ptr(__h->__value_), | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:2021:29: note: | |
in instantiation of function template specialization | |
'std::__1::__hash_table<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig>, | |
std::__1::__unordered_map_hasher<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::hash<std::__1::basic_string<char> >, true>, | |
std::__1::__unordered_map_equal<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::equal_to<std::__1::basic_string<char> >, true>, | |
std::__1::allocator<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig> > | |
>::__construct_node_hash<const std::__1::basic_string<char> &, node::loader::PackageConfig>' requested here | |
__node_holder __h = __construct_node_hash(__hash, _VSTD::forward<_Args>(__args)...); | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:1083:16: note: | |
in instantiation of function template specialization | |
'std::__1::__hash_table<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig>, | |
std::__1::__unordered_map_hasher<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::hash<std::__1::basic_string<char> >, true>, | |
std::__1::__unordered_map_equal<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::equal_to<std::__1::basic_string<char> >, true>, | |
std::__1::allocator<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig> > | |
>::__emplace_unique_key_args<std::__1::basic_string<char>, const std::__1::basic_string<char> &, node::loader::PackageConfig>' | |
requested here | |
return __emplace_unique_key_args(__f, _VSTD::forward<_First>(__f), | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/unordered_map:971:25: note: | |
in instantiation of function template specialization | |
'std::__1::__hash_table<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig>, | |
std::__1::__unordered_map_hasher<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::hash<std::__1::basic_string<char> >, true>, | |
std::__1::__unordered_map_equal<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::equal_to<std::__1::basic_string<char> >, true>, | |
std::__1::allocator<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig> > | |
>::__emplace_unique<const std::__1::basic_string<char> &, node::loader::PackageConfig>' requested here | |
return __table_.__emplace_unique(_VSTD::forward<_Args>(__args)...); | |
^ | |
../src/module_wrap.cc:561:42: note: in instantiation of function template specialization | |
'std::__1::unordered_map<std::__1::basic_string<char>, const node::loader::PackageConfig, | |
std::__1::hash<std::__1::basic_string<char> >, std::__1::equal_to<std::__1::basic_string<char> >, | |
std::__1::allocator<std::__1::pair<const std::__1::basic_string<char>, const node::loader::PackageConfig> > >::emplace<const | |
std::__1::basic_string<char> &, node::loader::PackageConfig>' requested here | |
auto entry = env->package_json_cache.emplace(path, | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _Dummy = true] | |
using _EnableB = typename enable_if<_Val, bool>::type; | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _Dummy = true] | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _U1 = const std::__1::basic_string<char> &, _U2 = | |
node::loader::PackageConfig] | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _U1 = const std::__1::basic_string<char> &, _U2 = | |
node::loader::PackageConfig] | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:409:5: note: | |
candidate constructor template not viable: requires 0 arguments, but 2 were provided | |
pair() : first(), second() {} | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:443:14: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
explicit pair(pair<_U1, _U2> const& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:450:5: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
pair(pair<_U1, _U2> const& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:457:14: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
explicit pair(pair<_U1, _U2>&&__p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:464:5: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
pair(pair<_U1, _U2>&& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:471:14: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
explicit pair(_Tuple&& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:479:5: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
pair(_Tuple&& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:485:5: note: | |
candidate constructor template not viable: requires 3 arguments, but 2 were provided | |
pair(piecewise_construct_t __pc, | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:542:9: note: | |
candidate constructor template not viable: requires 5 arguments, but 2 were provided | |
pair(piecewise_construct_t, | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:324:5: note: | |
candidate constructor not viable: requires 1 argument, but 2 were provided | |
pair(pair const&) = default; | |
^ | |
In file included from ../src/module_wrap.cc:1: | |
In file included from ../src/module_wrap.h:6: | |
In file included from /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/unordered_map:369: | |
In file included from /Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:16: | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:1805:31: error: no | |
matching constructor for initialization of 'std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>' | |
::new((void*)__p) _Up(_VSTD::forward<_Args>(__args)...); | |
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:1715:18: note: in | |
instantiation of function template specialization | |
'std::__1::allocator<std::__1::__hash_node<std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, void *> >::construct<std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::basic_string<char>, node::loader::PackageConfig>' requested here | |
{__a.construct(__p, _VSTD::forward<_Args>(__args)...);} | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/memory:1561:14: note: in | |
instantiation of function template specialization | |
'std::__1::allocator_traits<std::__1::allocator<std::__1::__hash_node<std::__1::__hash_value_type<std::__1::basic_string<char>, | |
const node::loader::PackageConfig>, void *> > >::__construct<std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::basic_string<char>, node::loader::PackageConfig>' requested here | |
{__construct(__has_construct<allocator_type, _Tp*, _Args...>(), | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:2305:20: note: | |
in instantiation of function template specialization | |
'std::__1::allocator_traits<std::__1::allocator<std::__1::__hash_node<std::__1::__hash_value_type<std::__1::basic_string<char>, | |
const node::loader::PackageConfig>, void *> > >::construct<std::__1::pair<const std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::basic_string<char>, node::loader::PackageConfig>' requested here | |
__node_traits::construct(__na, _NodeTypes::__get_ptr(__h->__value_), | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:2021:29: note: | |
in instantiation of function template specialization | |
'std::__1::__hash_table<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig>, | |
std::__1::__unordered_map_hasher<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::hash<std::__1::basic_string<char> >, true>, | |
std::__1::__unordered_map_equal<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::equal_to<std::__1::basic_string<char> >, true>, | |
std::__1::allocator<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig> > | |
>::__construct_node_hash<std::__1::basic_string<char>, node::loader::PackageConfig>' requested here | |
__node_holder __h = __construct_node_hash(__hash, _VSTD::forward<_Args>(__args)...); | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/__hash_table:1083:16: note: | |
in instantiation of function template specialization | |
'std::__1::__hash_table<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig>, | |
std::__1::__unordered_map_hasher<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::hash<std::__1::basic_string<char> >, true>, | |
std::__1::__unordered_map_equal<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::equal_to<std::__1::basic_string<char> >, true>, | |
std::__1::allocator<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig> > | |
>::__emplace_unique_key_args<std::__1::basic_string<char>, std::__1::basic_string<char>, node::loader::PackageConfig>' | |
requested here | |
return __emplace_unique_key_args(__f, _VSTD::forward<_First>(__f), | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/unordered_map:971:25: note: | |
in instantiation of function template specialization | |
'std::__1::__hash_table<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig>, | |
std::__1::__unordered_map_hasher<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::hash<std::__1::basic_string<char> >, true>, | |
std::__1::__unordered_map_equal<std::__1::basic_string<char>, std::__1::__hash_value_type<std::__1::basic_string<char>, const | |
node::loader::PackageConfig>, std::__1::equal_to<std::__1::basic_string<char> >, true>, | |
std::__1::allocator<std::__1::__hash_value_type<std::__1::basic_string<char>, const node::loader::PackageConfig> > | |
>::__emplace_unique<std::__1::basic_string<char>, node::loader::PackageConfig>' requested here | |
return __table_.__emplace_unique(_VSTD::forward<_Args>(__args)...); | |
^ | |
../src/module_wrap.cc:651:44: note: in instantiation of function template specialization | |
'std::__1::unordered_map<std::__1::basic_string<char>, const node::loader::PackageConfig, | |
std::__1::hash<std::__1::basic_string<char> >, std::__1::equal_to<std::__1::basic_string<char> >, | |
std::__1::allocator<std::__1::pair<const std::__1::basic_string<char>, const node::loader::PackageConfig> > | |
>::emplace<std::__1::basic_string<char>, node::loader::PackageConfig>' requested here | |
auto entry = env->package_json_cache.emplace(pjson_url.ToFilePath(), | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _Dummy = true] | |
using _EnableB = typename enable_if<_Val, bool>::type; | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _Dummy = true] | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _U1 = std::__1::basic_string<char>, _U2 = | |
node::loader::PackageConfig] | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:349:41: note: | |
candidate template ignored: disabled by 'enable_if' [with _U1 = std::__1::basic_string<char>, _U2 = | |
node::loader::PackageConfig] | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:409:5: note: | |
candidate constructor template not viable: requires 0 arguments, but 2 were provided | |
pair() : first(), second() {} | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:443:14: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
explicit pair(pair<_U1, _U2> const& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:450:5: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
pair(pair<_U1, _U2> const& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:457:14: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
explicit pair(pair<_U1, _U2>&&__p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:464:5: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
pair(pair<_U1, _U2>&& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:471:14: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
explicit pair(_Tuple&& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:479:5: note: | |
candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided | |
pair(_Tuple&& __p) | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:485:5: note: | |
candidate constructor template not viable: requires 3 arguments, but 2 were provided | |
pair(piecewise_construct_t __pc, | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:542:9: note: | |
candidate constructor template not viable: requires 5 arguments, but 2 were provided | |
pair(piecewise_construct_t, | |
^ | |
/Applications/Xcode-beta.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include/c++/v1/utility:324:5: note: | |
candidate constructor not viable: requires 1 argument, but 2 were provided | |
pair(pair const&) = default; | |
^ | |
2 errors generated. | |
make[1]: *** [/Users/jkrems/Projects/node/node/out/Release/obj.target/libnode/src/module_wrap.o] Error 1 | |
make[1]: *** Waiting for unfinished jobs.... | |
rm f781774cdc13b7b21f27e10610b84ee116182b00.intermediate 5fdce13b7e1e87c080581d733c32bbdee2685958.intermediate 7fc01641bb1c2d55013a0310d69b07f9084caec7.intermediate | |
make: *** [node] Error 2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/doc/api/esm.md b/doc/api/esm.md | |
index 05d01f7390..fd72642d8b 100644 | |
--- a/doc/api/esm.md | |
+++ b/doc/api/esm.md | |
@@ -266,7 +266,7 @@ import feature from 'es-module-package/features/x.js'; | |
``` | |
If a package has no exports, setting `"exports": false` can be used instead of | |
-`"exports": {}` to indicate the package does not intent for submodules to be | |
+`"exports": {}` to indicate the package does not intend for submodules to be | |
exposed. | |
This is just a convention that works because `false`, just like `{}`, has no | |
iterable own properties. | |
diff --git a/src/env.h b/src/env.h | |
index e68f120bf7..f9b04d61c8 100644 | |
--- a/src/env.h | |
+++ b/src/env.h | |
@@ -102,7 +102,7 @@ struct PackageConfig { | |
const PackageType type; | |
const HasExports has_exports; | |
- const v8::CopyablePersistentTraits<v8::Value>::CopyablePersistent exports; | |
+ const v8::Global<v8::Value> exports; | |
}; | |
} // namespace loader | |
diff --git a/src/module_wrap.cc b/src/module_wrap.cc | |
index 037d691f3a..0b7114874c 100644 | |
--- a/src/module_wrap.cc | |
+++ b/src/module_wrap.cc | |
@@ -26,6 +26,7 @@ using v8::Context; | |
using v8::Function; | |
using v8::FunctionCallbackInfo; | |
using v8::FunctionTemplate; | |
+using v8::Global; | |
using v8::HandleScope; | |
using v8::Integer; | |
using v8::IntegrityLevel; | |
@@ -560,7 +561,7 @@ Maybe<const PackageConfig*> GetPackageConfig(Environment* env, | |
auto entry = env->package_json_cache.emplace(path, | |
PackageConfig { Exists::No, IsValid::Yes, HasMain::No, "", | |
PackageType::None, HasExports::No, | |
- Persistent<Value>() }); | |
+ Global<Value>() }); | |
return Just(&entry.first->second); | |
} | |
@@ -581,7 +582,7 @@ Maybe<const PackageConfig*> GetPackageConfig(Environment* env, | |
env->package_json_cache.emplace(path, | |
PackageConfig { Exists::Yes, IsValid::No, HasMain::No, "", | |
PackageType::None, HasExports::No, | |
- Persistent<Value>() }); | |
+ Global<Value>() }); | |
std::string msg = "Invalid JSON in '" + path + | |
"' imported from " + base.ToFilePath(); | |
node::THROW_ERR_INVALID_PACKAGE_CONFIG(env, msg.c_str()); | |
@@ -612,22 +613,22 @@ Maybe<const PackageConfig*> GetPackageConfig(Environment* env, | |
} | |
Local<Value> exports_v; | |
- Persistent<Value> exports; | |
+ Global<Value> exports; | |
if (pkg_json->Get(env->context(), | |
env->exports_string()).ToLocal(&exports_v) && | |
!exports_v->IsNullOrUndefined()) { | |
exports.Reset(env->isolate(), exports_v); | |
- | |
auto entry = env->package_json_cache.emplace(path, | |
PackageConfig { Exists::Yes, IsValid::Yes, has_main, main_std, | |
- pkg_type, HasExports::Yes, exports }); | |
+ pkg_type, HasExports::Yes, | |
+ std::move(exports) }); | |
return Just(&entry.first->second); | |
} | |
auto entry = env->package_json_cache.emplace(path, | |
PackageConfig { Exists::Yes, IsValid::Yes, has_main, main_std, | |
pkg_type, HasExports::No, | |
- Persistent<Value>() }); | |
+ Global<Value>() }); | |
return Just(&entry.first->second); | |
} | |
@@ -650,7 +651,7 @@ Maybe<const PackageConfig*> GetPackageScopeConfig(Environment* env, | |
auto entry = env->package_json_cache.emplace(pjson_url.ToFilePath(), | |
PackageConfig { Exists::No, IsValid::Yes, HasMain::No, "", | |
PackageType::None, HasExports::No, | |
- Persistent<Value>() }); | |
+ Global<Value>() }); | |
const PackageConfig* pcfg = &entry.first->second; | |
return Just(pcfg); | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment