Testing https://github.com/gohugoio/hugo/pull/11894

gohugoio-hugo-pull-11894-notes.md

✔️ Build status

With v0.121.2:

                   | EN  
-------------------+-----
  Pages            |  8  
  Paginator pages  |  0  
  Non-page files   |  0  
  Static files     |  1  
  Processed images |  0  
  Aliases          |  0  
  Sitemaps         |  1  
  Cleaned          |  0  

With PR #11830:

                   | EN  
-------------------+-----
  Pages            | 10  
  Paginator pages  |  0  
  Non-page files   |  0  
  Static files     |  0  
  Processed images |  0  
  Aliases          |  0  
  Cleaned          |  0  

✔️ Ctrl + C from server

On a few occassions I was not able to kill the server with Ctrl+C on the first try, and after several times it stopped with this message:

Error: context deadline exceeded

Hang after error when running server

I've a resources.GetRemote call that's currently returning a bad request (400) error, and at the moment that is expected (the provider site is having issues). I expected the hugo server to terminate after throwing the error, but I have to Ctrl+C to stop the server. With v0.121.2 the server terminates immediately. This is an intermittent problem, and I have not been able to create a mimimal failing example yet.

9324 – Wrong Permalink for resource in multihost mode when baseURL in one language has a sub path

I have pushed a fix for this, which after the other related work in this area simplified this a lot.

After some thinking, I decided to close/remove #7437 from the mix and introduce a new (marked as internal for now) Resource.NameOriginal method that's used as a fall back in .Resources.Get.

I get it. That's exactly how I handled https://discourse.gohugo.io/t/multi-language-images-and-page-bundles/37325/8... a fallback in the render hook.

But now we don't have to do that because the fallback is baked-in. Nice.

11671 – Renamed content directories not added to the watcher

I have pushed a fixed for this (but the problem wasn't really the watcher). I'm not totally happy with how renames/new content is implemented, but it should work OK.

I recommend changing the issues referenced in the commit message for gohugoio/hugo#11894.

recommendation

Closes #11455
Closes #11549

Fixes #7425
Fixes #7436
Fixes #7544
Fixes #7882
Fixes #7960
Fixes #8255
Fixes #8307
Fixes #8863
Fixes #8927
Fixes #9192
Fixes #9324
Fixes #10169
Fixes #10364
Fixes #10482
Fixes #10630
Fixes #10656
Fixes #10694
Fixes #10918
Fixes #11439
Fixes #11453
Fixes #11457
Fixes #11466
Fixes #11540
Fixes #11551
Fixes #11556
Fixes #11654
Fixes #11661
Fixes #11663
Fixes #11664
Fixes #11669
Fixes #11671
Fixes #11807
Fixes #11808
Fixes #11809
Fixes #11815
Fixes #11840
Fixes #11853
Fixes #11860
Fixes #11883
Fixes #11904

Explanation...

Issues removed from list

#7437 - This is now closed; closed by bep on 2024-01-21.
#8498 - Disabling the taxonomy kind does not disable the term kind, and I think this is a good thing. Unless I'm missing something, we should close this separately.
#9343 - This is now closed; closed by bep on 2023-11-02.
#10104 - This is now closed; resolved in v0.93.0.
#10380 - This is now closed; duplicate of 11808.

Issues added to the list

I have reproduced these issues, and verified that they are fixed by gohugoio/hugo#11894

#7960
#8255
#8863
#10169
#10364
#10482
#10630
#10656
#10918
#11853

@jmooring I have updated the "master list" here gohugoio/hugo#11549 with your comments, I will update the commit message later. While sleeping, I seem to have a better approach to handling content renames/additions when running the server, so I will adjust that later, but other than that I'm pretty happy -- goal is to merge before weekend.

Converting this to a private gist.

Converting this to a private gist.

Disregard. The "convert to private" feature was removed a long time ago. I'll leave this here for a week or so, but at some point I will delete it.