Skip to content

Instantly share code, notes, and snippets.

@joanbm
Last active August 5, 2023 21:03
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save joanbm/fb90f4807b719a2e37a496936faabec9 to your computer and use it in GitHub Desktop.
Save joanbm/fb90f4807b719a2e37a496936faabec9 to your computer and use it in GitHub Desktop.
linux 6.3-rc1: Fix broadcom-wl connection to encrypted WiFi
From bda0e35daa904eb3df1ac5896b0403c7522d5aef Mon Sep 17 00:00:00 2001
From: Joan Bruguera <joanbrugueram@gmail.com>
Date: Thu, 23 Feb 2023 00:47:28 +0000
Subject: [PATCH] linux 6.3-rc1: Fix broadcom-wl connection to encrypted WiFi
Partial revert of commit 015b8cc5e7c4d7bb671f1984d7b7338c310b185b
"wifi: cfg80211: Fix use after free for wext"
This kernel patch fixes / works around broadcom-wl not being able to connect to
encrypted (e.g. WPA2) networks. I believe this is a regression not specific to
broadcom-wl but rather a more general issue but I don't have any other upstream
supported adapter that could be affected by this.
Link: https://lore.kernel.org/linux-wireless/20230124141856.356646-1-alexander@wetzel-home.de/
---
net/wireless/sme.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/wireless/sme.c b/net/wireless/sme.c
index 28ce13840a88..7bdeb8eea92d 100644
--- a/net/wireless/sme.c
+++ b/net/wireless/sme.c
@@ -1500,8 +1500,6 @@ int cfg80211_connect(struct cfg80211_registered_device *rdev,
connect->key = NULL;
connect->key_len = 0;
connect->key_idx = 0;
- connect->crypto.cipher_group = 0;
- connect->crypto.n_ciphers_pairwise = 0;
}
wdev->connect_keys = connkeys;
--
2.39.2
@joanbm
Copy link
Author

joanbm commented Aug 5, 2023

For posterity: this was actually a kernel bug, and it was fixed before the Linux 6.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment