Skip to content

Instantly share code, notes, and snippets.

@joanmarie
Created December 16, 2013 22:24
Show Gist options
  • Save joanmarie/7995552 to your computer and use it in GitHub Desktop.
Save joanmarie/7995552 to your computer and use it in GitHub Desktop.
Patch to add AtkRelation label-for/labelled-by pairs between labels and widgets in the Corebird settings dialog
From 154aafcadd4a600a8faadfa19008ffc43f5b69e0 Mon Sep 17 00:00:00 2001
From: Joanmarie Diggs <jdiggs@igalia.com>
Date: Mon, 16 Dec 2013 22:47:05 +0100
Subject: [PATCH] Add AtkRelation pairs between labels and their widgets
Setting the mnemonic-widget property of a GtkLabel will cause Gtk+ to add
the appropriate accessible relationship between that label and widget.
This is far simpler than manually implementing it via ATK, and will need
to be done anyway if at some point down the road the decision is made to
use underline to support keyboard shortcuts for these widgets.
---
ui/settings-dialog.ui | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/ui/settings-dialog.ui b/ui/settings-dialog.ui
index 13178ec..6d659bf 100644
--- a/ui/settings-dialog.ui
+++ b/ui/settings-dialog.ui
@@ -182,6 +182,7 @@
<property name="halign">end</property>
<property name="hexpand">True</property>
<property name="xalign">1</property>
+ <property name="mnemonic_widget">upload_provider_combobox</property>
<property name="label" translatable="yes">Upload Provider:</property>
</object>
<packing>
@@ -233,6 +234,7 @@
<property name="halign">end</property>
<property name="valign">center</property>
<property name="label" translatable="yes">Show retweets:</property>
+ <property name="mnemonic_widget">search_show_retweets_switch</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -285,6 +287,7 @@
<property name="halign">end</property>
<property name="hexpand">True</property>
<property name="label" translatable="yes">Show Inline Media:</property>
+ <property name="mnemonic_widget">inline_media_switch</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -300,6 +303,7 @@
<property name="halign">end</property>
<property name="hexpand">True</property>
<property name="label" translatable="yes">Use Dark Theme:</property>
+ <property name="mnemonic_widget">dark_theme_switch</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -357,6 +361,7 @@
<property name="halign">end</property>
<property name="hexpand">True</property>
<property name="label" translatable="yes">Maximum media size:</property>
+ <property name="mnemonic_widget">max_media_size_spin_button</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -372,6 +377,7 @@
<property name="halign">end</property>
<property name="hexpand">True</property>
<property name="label" translatable="yes">Auto scroll on new tweets:</property>
+ <property name="mnemonic_widget">auto_scroll_on_new_tweets_switch</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -461,6 +467,7 @@
<property name="halign">end</property>
<property name="xalign">1</property>
<property name="label" translatable="yes">On New Tweets:</property>
+ <property name="mnemonic_widget">on_new_tweets_combobox</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -492,6 +499,7 @@
<property name="can_focus">False</property>
<property name="xalign">1</property>
<property name="label" translatable="yes">On New Mentions:</property>
+ <property name="mnemonic_widget">on_new_mentions_switch</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -506,6 +514,7 @@
<property name="can_focus">False</property>
<property name="xalign">1</property>
<property name="label" translatable="yes">On New Messages:</property>
+ <property name="mnemonic_widget">on_new_dms_switch</property>
</object>
<packing>
<property name="left_attach">0</property>
@@ -568,6 +577,7 @@
<property name="can_focus">False</property>
<property name="xalign">1</property>
<property name="label" translatable="yes">On New Followers:</property>
+ <property name="mnemonic_widget">on_new_followers_switch</property>
</object>
<packing>
<property name="left_attach">0</property>
--
1.8.4.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment