Skip to content

Instantly share code, notes, and snippets.

@johannth
johannth / code-review-agreement.md
Last active August 29, 2015 14:25
QuizUp iOS Code Review Agreement

Code Review Agreement

As the coder, what do I expect of the reviewer?

  • Be critical! I won't take it personally!
  • Thou shalt always weakify strongify! (i.e. reviewer spots dumb things)
  • Suggest alternatives and share knowledge.
  • Build and run code locallly.
  • Take your time to review.
  • Try to spot missing tests.
@johannth
johannth / pep8_testcase.py
Created November 28, 2012 11:21
A more pythonic unittest.TestCase that follows PEP 8 conventions
#!/usr/bin/env python
# -*- coding: utf-8 -*-
"""
A more pythonic unittest TestCase that allows you to follow PEP8
conventions and use self.assert_equal(A, B) instead of self.assertEqual(A, B)
"""
import unittest