Skip to content

Instantly share code, notes, and snippets.

@john-bell-gw

john-bell-gw/pull_request_template.md

Created October 25, 2019 15:19
Show Gist options
  • Save john-bell-gw/abd79adf4b1764ddad647d2cbe73fecf to your computer and use it in GitHub Desktop.
Save john-bell-gw/abd79adf4b1764ddad647d2cbe73fecf to your computer and use it in GitHub Desktop.
Download ZIP
Raw
pull_request_template.md

Description of this change

[A brief, easy to understand summary of what you did. Links to Jira stories are helpful.]

Areas of the site impacted by this change

[A list of areas reviewers and QA should pay attention to]

Tests

Put a link to the relevant PR in the bdd-automation repo

Screenshots

Before / after screenshots of UI changes are often helpful. Did this affect desktop and mobile?

Who can review your code?

Our current policy is that only mid and senior senior developers can merge pull requests into feature branches and master.

===

Before you ask for a code review

  • Does this PR contain a fully completed story or bug?
  • Have you read through your own changes in the PR?
  • Are automated tests and test data completed and passing?
  • Are manual test plans completed and reviewed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment