Skip to content

Instantly share code, notes, and snippets.

@johndrinkwater
Created November 12, 2018 13:22
Show Gist options
  • Save johndrinkwater/3b045d488e17e517882e364ad314b9b0 to your computer and use it in GitHub Desktop.
Save johndrinkwater/3b045d488e17e517882e364ad314b9b0 to your computer and use it in GitHub Desktop.
‘Fixing’ verbose volume updates in https://bugs.launchpad.net/recent-notifications
Before I realised recent-notifications had a denylist (dconf net.launchpad.indicator.notifications.blacklist ['indicator-sound']),
had created this patch to work around a bug in 15.10 indicator-sound:
bzr+ssh://bazaar.launchpad.net/+branch/recent-notifications/indicator/
```
--- src/notification.c 2015-10-23 21:51:59 +0000
+++ src/notification.c 2018-11-08 15:55:07 +0000
@@ -150,6 +150,10 @@
g_variant_unref(value);
value = NULL;
+ /* work-around bug in old indicator-sound setting X_CANONICAL_PRIVATE_SYNCHRONOUS to true */
+ if((g_strcmp0(self->priv->app_name, "indicator-sound") == 0)) {
+ self->priv->is_private = TRUE;
+ }
if((g_strcmp0(private_string, "volume") == 0) ||
(g_strcmp0(private_string, "brightness") == 0) ||
(g_strcmp0(private_string, "indicator-sound") == 0)) {
```
As the notifications for volume changes aren’t setting an application value for
x-canonical-private-synchronous, recent-notifications does not hide the notice.
```
method call time=1542028476.217358 sender=:1.49 -> destination=:1.67 serial=52 path=/org/freedesktop/Notifications; interface=org.freedesktop.Notifications; member=Notify
string "indicator-sound"
uint32 0
string "audio-volume-high"
string "Volume"
string ""
array [
]
array [
dict entry(
string "x-canonical-non-shaped-icon"
variant string "true"
)
dict entry(
string "x-canonical-value-bar-tint"
variant string "false"
)
dict entry(
string "x-canonical-private-synchronous"
variant string "true"
)
dict entry(
string "value"
variant int32 94
)
]
int32 -1
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment