Skip to content

Instantly share code, notes, and snippets.

@johnkodes
Created October 5, 2023 06:14
Show Gist options
  • Save johnkodes/afaa7b27239e63819bbbd9120a9deeb3 to your computer and use it in GitHub Desktop.
Save johnkodes/afaa7b27239e63819bbbd9120a9deeb3 to your computer and use it in GitHub Desktop.
Pull Request Template

Source: https://developers.soundcloud.com/blog/pr-templates-for-effective-pull-requests

Scope

closes TICKET-###

Implementation

With @pair

Screenshots

before after
desktop
mobile

How to Test

Emoji Guide

For reviewers: Emojis can be added to comments to call out blocking versus non-blocking feedback.

E.g: Praise, minor suggestions, or clarifying questions that don’t block merging the PR.

🟒 Nice refactor!

🟑 Why was the default value removed?

E.g: Blocking feedback must be addressed before merging.

πŸ”΄ This change will break something important

Blocking πŸ”΄ ❌ 🚨 RED
Non-blocking 🟑 πŸ’‘ πŸ€” πŸ’­ Yellow, thinking, etc
Praise 🟒 πŸ’š 😍 πŸ‘ πŸ™Œ Green, hearts, positive emojis, etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment