Skip to content

Instantly share code, notes, and snippets.

@jonahwilliams
Created December 14, 2022 01:08
Show Gist options
  • Save jonahwilliams/4c67b7e4bce0a9a5d9ec897bb41fd22a to your computer and use it in GitHub Desktop.
Save jonahwilliams/4c67b7e4bce0a9a5d9ec897bb41fd22a to your computer and use it in GitHub Desktop.
diff --git a/packages/flutter_tools/lib/src/asset.dart b/packages/flutter_tools/lib/src/asset.dart
index ea0104f8ef..44e5110df1 100644
--- a/packages/flutter_tools/lib/src/asset.dart
+++ b/packages/flutter_tools/lib/src/asset.dart
@@ -412,8 +412,7 @@ class ManifestAssetBundle implements AssetBundle {
// For all platforms, include the shaders unconditionally. They are
// small, and whether they're used is determined only by the app source
// code and not by the Flutter manifest.
- if (targetPlatform != TargetPlatform.web_javascript)
- ..._getMaterialShaders(),
+ ..._getMaterialShaders(),
];
for (final _Asset asset in materialAssets) {
final File assetFile = asset.lookupAssetFile(_fileSystem);
@@ -754,22 +753,18 @@ class ManifestAssetBundle implements AssetBundle {
}
}
- // TODO(jonahwilliams): re-enable this feature once
- // flutter web is using engine compiled canvaskit.
- if (targetPlatform != TargetPlatform.web_javascript) {
- for (final Uri shaderUri in flutterManifest.shaders) {
- _parseAssetFromFile(
- packageConfig,
- flutterManifest,
- assetBase,
- cache,
- result,
- shaderUri,
- packageName: packageName,
- attributedPackage: attributedPackage,
- assetKind: AssetKind.shader,
- );
- }
+ for (final Uri shaderUri in flutterManifest.shaders) {
+ _parseAssetFromFile(
+ packageConfig,
+ flutterManifest,
+ assetBase,
+ cache,
+ result,
+ shaderUri,
+ packageName: packageName,
+ attributedPackage: attributedPackage,
+ assetKind: AssetKind.shader,
+ );
}
// Add assets referenced in the fonts section of the manifest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment