Angular Controller that needs improvements. Here's the ReadProductFactory -> https://goo.gl/etvuqq

read-product.controller.js

(function () {
    
    'use strict';
    
    angular
        .module( 'app.purchases.products' )
        .controller( 'ReadProductController', ReadProductController );

    //Check out the description to go to ReadProductFactory
    ReadProductController.$inject = [ '$scope', 'ReadProductFactory' ];

    function ReadProductController( $scope, ReadProductFactory ) {

        /* jshint validthis: true */
        var vm = this;

        vm.products          = {};
        vm.product           = {};
        vm.getProductsList   = getProductsList;
        vm.getProductDetails = getProductDetails;

        function getProductsList( columnOrder, sortOrder ) {

            var data = {
                columnOrder: columnOrder,
                sortOrder: sortOrder
            };

            ReadProductFactory.listProducts( data, success, fail );

            //The following are the callbacks funcs but they repeat for the getProductDetails func too, should i set them global?
            function success( products ) {
                vm.products = products;
            }

            function fail( error ) {
                console.log( error );
            }
        }

        function getProductDetails( id ) {

            var data = {
                id: id
            };

            ReadProductFactory.detailProduct( data, success, fail );

            function success( product ) {
                vm.product = product;
            }

            function fail( error ) {
                console.log( error );
            }

        }

    }
    
})();