Skip to content

Instantly share code, notes, and snippets.

@jordpo
Last active July 13, 2020 20:19
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save jordpo/c3ab24b800d2fbebcde9b0a9bc1cdef2 to your computer and use it in GitHub Desktop.
Save jordpo/c3ab24b800d2fbebcde9b0a9bc1cdef2 to your computer and use it in GitHub Desktop.
Changeset Boolean Bug
import Controller from '@ember/controller';
import { EmberChangeset, Changeset } from 'ember-changeset';
class MyChangeset extends EmberChangeset {
// NOTE using the default safeSet for only type boolean fixes the issue
safeSet(obj, key, value) {
if (typeof value.value === 'boolean') (obj[key] = value);
return super.safeSet(obj, key, value);
}
}
import { action, computed } from '@ember/object';
export default class ApplicationController extends Controller {
appName = 'Ember Twiddle';
@computed()
get changeset() {
return Changeset({ isRunning: true }, function() {}, {}, { changeset: MyChangeset });
}
@action
toggleRunning() {
this.changeset.set('isRunning', !this.changeset.get('isRunning'));
}
}
<h1>Welcome to {{this.appName}}</h1>
<br>
<br>
{{this.changeset.isRunning}}
<br>
<br>
<button {{on 'click' this.toggleRunning}}>Run!</button>
<Input @value={{this.changeset.name}}/>
{
"version": "0.17.1",
"EmberENV": {
"FEATURES": {},
"_TEMPLATE_ONLY_GLIMMER_COMPONENTS": false,
"_APPLICATION_TEMPLATE_WRAPPER": true,
"_JQUERY_INTEGRATION": true
},
"options": {
"use_pods": false,
"enable-testing": false
},
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/3.5.1/jquery.js",
"ember": "3.18.1",
"ember-template-compiler": "3.18.1",
"ember-testing": "3.18.1"
},
"addons": {
"@glimmer/component": "1.0.0",
"ember-changeset": "3.7.1"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment