Skip to content

Instantly share code, notes, and snippets.

@jordy1611
Created September 3, 2020 19:18
Show Gist options
  • Save jordy1611/03279e49e989a8abfca7e7e72640e4ae to your computer and use it in GitHub Desktop.
Save jordy1611/03279e49e989a8abfca7e7e72640e4ae to your computer and use it in GitHub Desktop.

Peer Review For Rancid Tomatillos

Josh this is a great application! As usual your code's extremely clean and easy to follow. Think you followed the rubric almost perfectly and I look the overall look of the project. I'm learning a lot just from reviewing your code. I

Pros

  • I really like how many components you have for the comments. Makes the actual rendering super clean.
  • It's very well organized
  • Good use of PropTypes
  • Not directly related to comments but the errorPage component is a good idea
  • Your workflow is very well documented and descripted
  • You have a lot of tests

Cons (Hard to find any, had to be a bit nitpicky)

  • Can always use more tests
  • If you set some props to variables in the component it's easier to read. In this context it isn't necessary but if you're passing down a lot of different, fairly complex date down to a component accessing a variable comment rather than props.comment could be just a little easier.

Overall

This is a fantastic project. I apologize for the lack of constructive feedback. You did a lot of things better than I did in my project so it's a struggle to find things to improve on! The best part of the whole project is how organized everything is. Really easy to read and understand. I didn't get lost or confused at any point reviewing your code eventhough you wrote some complex functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment