Joseph Ravenwolfe joseph-ravenwolfe

## request.md

      
              1 file
            
          
              0 forks
            
          
              0 comments
            
          
              0 stars
            
          
                joseph-ravenwolfe
                / request.md
            
            
              Created
              November 11, 2015 22:40
                — forked from nilbus/request.md
            
              
                Proposed changes to tcrayford/Values
              
          
    This gem is great. Thanks for releasing it!
We're running into 2 issues using Values, however.

Inheritance from other classes is impossible
No support for optional arguments to ValueClass.with

What I'm suggesting is a significant deviation from current usage and would require a major version release. That said, I think the benefits are worth it. Please review these ideas, and let me know if you would consider accepting future Pull Requests for these changes into the project, providing that the changes are simple and elegant enough to stay in line with the project's goal for simplicity. If not, we'll fork and release under a different name.
Inheritance

  
## client.rb
# What we are going to do is retrieve all of the users.
#
# Then loop through all of the users. For each user that
# we loop through, we will get all of their clients.
#
# Then we will loop through each of that user's clients
# and send that client an email.
#
# We will send the client object into daily_email and
# let daily_mail get whatever information it needs
	# What we are going to do is retrieve all of the users.
	#
	# Then loop through all of the users. For each user that
	# we loop through, we will get all of their clients.
	#
	# Then we will loop through each of that user's clients
	# and send that client an email.
	#
	# We will send the client object into daily_email and
	# let daily_mail get whatever information it needs