-
-
Save jpcima/cda8d83462ca27b0782a0d7e42d368da to your computer and use it in GitHub Desktop.
This code is only used on Linux but we Could offer it
A comment with surge in it is a good idea. I’ve been using the git log to know the differences but that’s hard on inspection
Thank you for doing this!
I modified the code at the call sites of addAnimation
.
At least in Surge's context, the menus seem fine to me.
Since I'm not entirely comfortable with anything of Vstgui, does this code seem logical to you ?
Yes it seems logical to me. And this fork of vstgui is only used for surge so it is almost definitely the correct one. Do we still want the animation on the decorView?
I am happy to apply this and walk it through the (somewhat complicated) build and branch process if that's OK with you. Let me know.
Do we still want the animation on the decorView?
Not sure what you mean here. decorView
animation is disabled.
It's the one that occurs on the menu opened. (and, note: it must not show at alpha 0.0, or nothing is seen)
I am happy to apply this and walk it through the (somewhat complicated) build and branch process if that's OK with you.
You can go ahead. If it's about being credited for the commit, I don't care, take it as yours.
I can easily add you as credited on the commit. OK I'll walk it through. Thanks!
Ok, I undertood what you ask to do. I will find where are these other animations located.
A thing: should this pseudo-fix be guarded by
#if LINUX
and left reserved for this OS?Also, should I leave a comment mark to indicate this modif is a thing of ours? as
/// Surge ///
or something.