Skip to content

Instantly share code, notes, and snippets.

@jrussett

jrussett/hotswap_break_network_failures.md

Last active February 21, 2018 00:20
Show Gist options
  • Save jrussett/d2aec8f54aaa71c2be8fa58a4acb8318 to your computer and use it in GitHub Desktop.
Save jrussett/d2aec8f54aaa71c2be8fa58a4acb8318 to your computer and use it in GitHub Desktop.
Download ZIP
Hotswap failures
Raw
hotswap_break_network_failures.md

No longer cause issues after being run in CI

  • rspec ./spec/gocli/integration/calculated_vm_properties_spec.rb:91 # calculated vm properties when deploying with default CPI deploys vms with size calculated from vm block
  • rspec ./spec/gocli/integration/cli_deploy_uploading_spec.rb:25 # cli: deploy uploading with a remote release uploads the release from the remote url in the manifest
  • rspec ./spec/gocli/integration/cli_deploy_uploading_spec.rb:36 # cli: deploy uploading with a remote release does not upload the same release twice
  • rspec ./spec/gocli/integration/cli_deploy_uploading_spec.rb:52 # cli: deploy uploading with a remote release fails when the sha1 does not match
  • rspec ./spec/gocli/integration/cli_deploy_uploading_spec.rb:60 # cli: deploy uploading with a remote release allows multiple digests in the sha1 field
  • rspec ./spec/gocli/integration/cli_ignore_spec.rb:14 # ignore/unignore-instance changes the ignore value of vms correctly

Other issues + Notes:

  • rspec ./spec/gocli/integration/cli_deployment_process_spec.rb:237 # cli: deployment process bosh deploy when switching to cpi config for existing deployment deploys to multiple cpis

    • Known issue; vm is not deleted therefore we have no way of getting the disk. Need DK to decide from the product perspective if it would be better to have bosh kill the VM or for users to be responsible for deleting danging VMs

  • rspec ./spec/gocli/integration/cli_events_spec.rb:6 # cli: events displays deployment events

    • See above, we don't know how to deal with failing jobs/situations where we should detach disks from a product standpoint yet.

  • rspec ./spec/gocli/integration/cli_ignore_spec.rb:661 # ignore/unignore-instance when starting/stopping/restarting/recreating instances when not specifying an instance group name should change the state of all instances except the ignored ones

    • something about not being able to attach a disk that is already attached when trying to stop specific instance group, while stopping a whole deployment works without issues...

  • rspec ./spec/gocli/integration/deploy_spec.rb:329 # deploy when dns is enabled it supports running pre-start scripts should append the logs to the previous pre-start logs

    • Test doesn't make sense in a hotswap context; updating release and uploading with hotswap will create new vm to replace vm with old release

  • rspec ./spec/gocli/integration/deploy_spec.rb:460 # deploy when dns is enabled it supports running post-deploy scripts when the post-deploy scripts are valid does not run post-deploy scripts on stopped vms

  • rspec ./spec/gocli/integration/deploy_spec.rb:54 # deploy with dry run flag does not interfere with a successful deployment later

  • rspec ./spec/gocli/integration/deploy_spec.rb:731 # deploy when dns is enabled when deployment manifest has local templates properties defined should not update the job when template properties are the same

  • rspec ./spec/gocli/integration/global_networking/availability_zones_spec.rb:529 # availability zones when job is placed in an availability zone that has cloud properties. when adding azs to jobs with persistent disks updates instances when az cloud properties change and deployment is re-deployed

  • rspec ./spec/gocli/integration/global_networking/changing_cloud_config_spec.rb:104 # Changing cloud config no changes when redeploying a network after rename should not recreate vms when there are no changes

  • rspec ./spec/gocli/integration/global_networking/ip_reservations_spec.rb:437 # global networking when allocating dynamic IPs gives VMs the same IP on deploy --recreate

    • Doesn't make sense for hotswap, --recreate will notget rid of old vms

  • rspec ./spec/gocli/integration/global_networking/ip_reservations_spec.rb:549 # global networking when allocating dynamic IPs releases IP when subnet range is changed to no longer include it

    • Hotswap doesn't currently ahve a way to clean up vms therefore this test will not pass as the vm from the first subnet still exists

  • rspec ./spec/gocli/integration/global_networking/ip_reservations_spec.rb:584 # global networking when allocating dynamic IPs when using two networks when range does not include one of IPs redeploys VM updating IP that does not belong to range and keeping another IP

    • Hotswap doesn't get rid of old vms, compilation vm is trying to be created using the IP that the first compilation VM

  • rspec ./spec/gocli/integration/global_networking/ip_reservations_spec.rb:646 # global networking when allocating dynamic IPs using legacy network configuration (no cloud config) gives VMs the same IP on deploy --recreate

    • This makes no sense using the hotswap strategy; VMs will not have the same IPs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment