Created
December 2, 2019 10:44
-
-
Save jubnzv/5d09accfeb87ab72c437917fc457b3c3 to your computer and use it in GitHub Desktop.
cppcheck report
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cppcheck: unusedFunction check can't be used with '-j' option. Disabling unusedFunction check. | |
| app/src/controllers/shortcutSettings/ShortcutSettingsController.cpp:7:29: warning: Member variable 'ShortcutSettingsController::view' is not initialized in the constructor. [uninitMemberVar] | |
| ShortcutSettingsController::ShortcutSettingsController(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/controllers/shortcutSettings/ShortcutSettingsController.cpp:7:29: warning: Member variable 'ShortcutSettingsController::model' is not initialized in the constructor. [uninitMemberVar] | |
| ShortcutSettingsController::ShortcutSettingsController(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/ClipboardBranch.cpp:104:42: performance: Function parameter 'parent_id' should be passed by const reference. [passedByValue] | |
| void ClipboardBranch::addBranch( QString parent_id, QMap<QString, QString> branch_fields) | |
| ^ | |
| app/src/libraries/ClipboardBranch.cpp:124:69: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| QMap<QString, QString> ClipboardBranch::getBranchFieldsById(QString id) | |
| ^ | |
| app/src/controllers/attachTable/AttachTableController.cpp:165:46: performance: Function parameter 'attachType' should be passed by const reference. [passedByValue] | |
| void AttachTableController::addSmart(QString attachType) | |
| ^ | |
| app/src/controllers/attachTable/AttachTableController.cpp:269:65: performance: Function parameter 'attachType' should be passed by const reference. [passedByValue] | |
| QStringList AttachTableController::selectFilesForAdding(QString attachType) | |
| ^ | |
| app/src/controllers/attachTable/AttachTableController.cpp:415:109: performance: Function parameter 'attachType' should be passed by const reference. [passedByValue] | |
| void AttachTableController::saveAttachToUserPlace(QString fromFullFileName, QString toFullFileName, QString attachType, bool isAttachCrypt) | |
| ^ | |
| app/src/libraries/DiskHelper.cpp:189:86: performance: Function parameter 'fileMask' should be passed by const reference. [passedByValue] | |
| QMap<QString, QByteArray> DiskHelper::getFilesFromDirectory(QString dirName, QString fileMask) | |
| ^ | |
| app/src/libraries/Downloader.cpp:24:3: performance: Variable 'saveDirectory' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| saveDirectory=""; | |
| ^ | |
| app/src/libraries/Downloader.cpp:104:43: performance: Function parameter 'iDir' should be passed by const reference. [passedByValue] | |
| void Downloader::setSaveDirectory(QString iDir) | |
| ^ | |
| app/src/libraries/Downloader.cpp:117:48: performance: Function parameter 'iReferencesList' should be passed by const reference. [passedByValue] | |
| void Downloader::setReferencesList(QStringList iReferencesList) | |
| ^ | |
| app/src/libraries/Downloader.cpp:417:44: performance: Function parameter 'text' should be passed by const reference. [passedByValue] | |
| void Downloader::addErrorLog(const QString text) | |
| ^ | |
| app/src/controllers/recordTable/RecordTableController.cpp:794:60: performance: Prefer prefix ++/-- operators for non-primitive types. [postfixOperator] | |
| for(it=itemsForDelete.begin(); it!=itemsForDelete.end(); it++) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:26:19: warning: Member variable 'GlobalParameters::pointTreeScreen' is not initialized in the constructor. [uninitMemberVar] | |
| GlobalParameters::GlobalParameters(QObject *pobj) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:26:19: warning: Member variable 'GlobalParameters::pointRecordTableScreen' is not initialized in the constructor. [uninitMemberVar] | |
| GlobalParameters::GlobalParameters(QObject *pobj) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:26:19: warning: Member variable 'GlobalParameters::pointFindScreen' is not initialized in the constructor. [uninitMemberVar] | |
| GlobalParameters::GlobalParameters(QObject *pobj) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:26:19: warning: Member variable 'GlobalParameters::pointMetaEditor' is not initialized in the constructor. [uninitMemberVar] | |
| GlobalParameters::GlobalParameters(QObject *pobj) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:26:19: warning: Member variable 'GlobalParameters::pointStatusBar' is not initialized in the constructor. [uninitMemberVar] | |
| GlobalParameters::GlobalParameters(QObject *pobj) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:26:19: warning: Member variable 'GlobalParameters::windowSwitcher' is not initialized in the constructor. [uninitMemberVar] | |
| GlobalParameters::GlobalParameters(QObject *pobj) | |
| ^ | |
| app/src/libraries/IconSelectDialog.cpp:197:50: performance: Function parameter 'iSectionName' should be passed by const reference. [passedByValue] | |
| void IconSelectDialog::setDefaultSection(QString iSectionName) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:38:51: performance: Function parameter 'file' should be passed by const reference. [passedByValue] | |
| void GlobalParameters::setMainProgramFile(QString file) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:299:53: performance: Function parameter 'dirName' should be passed by const reference. [passedByValue] | |
| void GlobalParameters::createStyleSheetFile(QString dirName) | |
| ^ | |
| app/src/libraries/GlobalParameters.cpp:570:47: performance: Function parameter 'hash' should be passed by const reference. [passedByValue] | |
| void GlobalParameters::setCryptKey(QByteArray hash) | |
| ^ | |
| app/src/libraries/PeriodicCheckBase.h:13:8: style: The function 'isStartEnabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| bool isStartEnabled(); | |
| ^ | |
| app/src/libraries/TimerMonitoring.h:26:16: note: Virtual function in base class | |
| virtual bool isStartEnabled()=0; | |
| ^ | |
| app/src/libraries/PeriodicCheckBase.h:13:8: note: Function in derived class | |
| bool isStartEnabled(); | |
| ^ | |
| app/src/libraries/PeriodicCheckBase.h:14:8: style: The function 'timerEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| void timerEvent(QTimerEvent *event); | |
| ^ | |
| app/src/libraries/TimerMonitoring.h:27:16: note: Virtual function in base class | |
| virtual void timerEvent(QTimerEvent *)=0; | |
| ^ | |
| app/src/libraries/PeriodicCheckBase.h:14:8: note: Function in derived class | |
| void timerEvent(QTimerEvent *event); | |
| ^ | |
| app/src/libraries/PeriodicSyncro.h:13:8: style: The function 'isStartEnabled' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| bool isStartEnabled(); | |
| ^ | |
| app/src/libraries/TimerMonitoring.h:26:16: note: Virtual function in base class | |
| virtual bool isStartEnabled()=0; | |
| ^ | |
| app/src/libraries/PeriodicSyncro.h:13:8: note: Function in derived class | |
| bool isStartEnabled(); | |
| ^ | |
| app/src/libraries/PeriodicSyncro.h:14:8: style: The function 'timerEvent' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| void timerEvent(QTimerEvent *event); | |
| ^ | |
| app/src/libraries/TimerMonitoring.h:27:16: note: Virtual function in base class | |
| virtual void timerEvent(QTimerEvent *)=0; | |
| ^ | |
| app/src/libraries/PeriodicSyncro.h:14:8: note: Function in derived class | |
| void timerEvent(QTimerEvent *event); | |
| ^ | |
| app/src/libraries/TimerMonitoring.cpp:7:18: warning: Member variable 'TimerMonitoring::delay' is not initialized in the constructor. [uninitMemberVar] | |
| TimerMonitoring::TimerMonitoring(void) | |
| ^ | |
| app/src/libraries/TimerMonitoring.cpp:7:18: warning: Member variable 'TimerMonitoring::timerId' is not initialized in the constructor. [uninitMemberVar] | |
| TimerMonitoring::TimerMonitoring(void) | |
| ^ | |
| app/src/libraries/TrashMonitoring.cpp:12:18: warning: Member variable 'TrashMonitoring::dirSize' is not initialized in the constructor. [uninitMemberVar] | |
| TrashMonitoring::TrashMonitoring(void) | |
| ^ | |
| app/src/libraries/TrashMonitoring.cpp:66:39: performance: Function parameter 'filename' should be passed by const reference. [passedByValue] | |
| void TrashMonitoring::addFile(QString filename) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:54:48: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| QString CryptService::encryptString(QByteArray key, QString line) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:88:48: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| QString CryptService::decryptString(QByteArray key, QString line) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:140:54: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| QByteArray CryptService::encryptByteArray(QByteArray key, QByteArray data) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:165:54: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| QByteArray CryptService::decryptByteArray(QByteArray key, QByteArray data) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:190:62: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| QByteArray CryptService::encryptStringToByteArray(QByteArray key, QString line) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:215:61: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| QString CryptService::decryptStringFromByteArray(QByteArray key, QByteArray data) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:244:43: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| void CryptService::encryptFile(QByteArray key, QString fileName) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:244:56: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] | |
| void CryptService::encryptFile(QByteArray key, QString fileName) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:251:43: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| void CryptService::decryptFile(QByteArray key, QString fileName) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:251:56: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] | |
| void CryptService::decryptFile(QByteArray key, QString fileName) | |
| ^ | |
| app/src/libraries/crypt/CryptService.cpp:257:47: performance: Function parameter 'key' should be passed by const reference. [passedByValue] | |
| void CryptService::encDecFileSmart(QByteArray key, QString fileName, int mode) | |
| ^ | |
| app/src/libraries/ShortcutManager.cpp:400:62: performance: Function parameter 'actionName' should be passed by const reference. [passedByValue] | |
| QString ShortcutManager::getDefaultKeySequenceAsText(QString actionName) | |
| ^ | |
| app/src/libraries/crypt/Password.cpp:172:44: performance: Function parameter 'password' should be passed by const reference. [passedByValue] | |
| void Password::setCryptKeyToMemory(QString password) | |
| ^ | |
| app/src/libraries/crypt/Password.cpp:247:44: performance: Function parameter 'password' should be passed by const reference. [passedByValue] | |
| void Password::smartSaveMiddleHash(QString password) | |
| ^ | |
| app/src/libraries/crypt/Password.cpp:280:51: performance: Function parameter 'middleHash' should be passed by const reference. [passedByValue] | |
| void Password::saveMiddleHashCheckData(QByteArray middleHash) | |
| ^ | |
| app/src/libraries/qtSingleApplication/qtlockedfile.h:77:5: style: Class 'QtLockedFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| QtLockedFile(const QString &name); | |
| ^ | |
| app/src/libraries/crypt/Pbkdf2Qt.cpp:98:15: style: The scope of the variable 'r' can be reduced. [variableScope] | |
| unsigned int r; | |
| ^ | |
| app/src/libraries/qtSingleApplication/qtlockedfile.cpp:93:5: performance: Variable 'wmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| wmutex = 0; | |
| ^ | |
| app/src/libraries/qtSingleApplication/qtlockedfile.cpp:94:5: performance: Variable 'rmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| rmutex = 0; | |
| ^ | |
| app/src/libraries/qtSingleApplication/qtlockedfile.cpp:110:5: performance: Variable 'wmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| wmutex = 0; | |
| ^ | |
| app/src/libraries/qtSingleApplication/qtlockedfile.cpp:111:5: performance: Variable 'rmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| rmutex = 0; | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:123:12: warning: Member variable 'RC5Simple::rc5_s' is not initialized in the constructor. [uninitMemberVar] | |
| RC5Simple::RC5Simple(bool enableRandomInit) | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:231:12: style: Local variable 'i' shadows outer variable [shadowVariable] | |
| for(int i=0; i<RC5_C; i++) | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:222:8: note: Shadowed declaration | |
| int i, j, k; | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:231:12: note: Shadow variable | |
| for(int i=0; i<RC5_C; i++) | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:240:12: style: Local variable 'i' shadows outer variable [shadowVariable] | |
| for(int i=0; i<RC5_T; i++) | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:222:8: note: Shadowed declaration | |
| int i, j, k; | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:240:12: note: Shadow variable | |
| for(int i=0; i<RC5_T; i++) | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:253:12: style: Local variable 'i' shadows outer variable [shadowVariable] | |
| for(int i=0; i<RC5_T; i++) | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:222:8: note: Shadowed declaration | |
| int i, j, k; | |
| ^ | |
| app/src/libraries/crypt/RC5Simple.cpp:253:12: note: Shadow variable | |
| for(int i=0; i<RC5_T; i++) | |
| ^ | |
| app/src/libraries/qtSingleApplication/qtsingleapplication.h:80:5: style: Class 'QtSingleApplication' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| QtSingleApplication(Display* dpy, Qt::HANDLE visual = 0, Qt::HANDLE colormap = 0); | |
| ^ | |
| app/src/libraries/qtSingleApplication5/qtlockedfile.h:72:5: style: Class 'QtLockedFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| QtLockedFile(const QString &name); | |
| ^ | |
| app/src/libraries/qtSingleApplication5/qtlockedfile.cpp:86:5: performance: Variable 'wmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| wmutex = 0; | |
| ^ | |
| app/src/libraries/qtSingleApplication5/qtlockedfile.cpp:87:5: performance: Variable 'rmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| rmutex = 0; | |
| ^ | |
| app/src/libraries/qtSingleApplication5/qtlockedfile.cpp:103:5: performance: Variable 'wmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| wmutex = 0; | |
| ^ | |
| app/src/libraries/qtSingleApplication5/qtlockedfile.cpp:104:5: performance: Variable 'rmutex' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| rmutex = 0; | |
| ^ | |
| app/src/libraries/qtSingleApplication5/qtsingleapplication.h:76:5: style: Class 'QtSingleApplication' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| QtSingleApplication(Display* dpy, Qt::HANDLE visual = 0, Qt::HANDLE colormap = 0); | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTableCell.h:17:3: style: Class 'EditorAbsTableCell' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| EditorAbsTableCell(QString init_value); | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTableCell.cpp:17:48: performance: Function parameter 'init_value' should be passed by const reference. [passedByValue] | |
| EditorAbsTableCell::EditorAbsTableCell(QString init_value) | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTableCell.cpp:25:45: performance: Function parameter 'init_value' should be passed by const reference. [passedByValue] | |
| void EditorAbsTableCell::set_value(QString init_value) | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTableCell.cpp:38:70: performance: Function parameter 'propValue' should be passed by const reference. [passedByValue] | |
| void EditorAbsTableCell::set_html_property(QString propName, QString propValue) | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.h:14:5: style: Class 'EditorConfig' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| EditorConfig(QString config_file_name, QWidget *parent=nullptr); | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTable.cpp:310:39: style: Local variable 'i' shadows outer variable [shadowVariable] | |
| QMapIterator<QString, QString> i(cellProperty); | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTable.cpp:286:33: note: Shadowed declaration | |
| QMapIterator<QString, QString> i(htmlProperty); | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTable.cpp:310:39: note: Shadow variable | |
| QMapIterator<QString, QString> i(cellProperty); | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTable.cpp:25:54: performance: Function parameter 'tableText' should be passed by const reference. [passedByValue] | |
| EditorAbsTable::EditorAbsTable(int x, int y, QString tableText, QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTable.cpp:41:54: performance: Function parameter 'tableText' should be passed by const reference. [passedByValue] | |
| void EditorAbsTable::set_table(int x, int y, QString tableText) | |
| ^ | |
| app/src/libraries/wyedit/EditorAbsTable.cpp:97:21: style: Variable 'cellEndPosition' is assigned a value that is never used. [unreadVariable] | |
| int cellEndPosition=0; | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:829:61: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| QString name, | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:830:61: performance: Function parameter 'fromType' should be passed by const reference. [passedByValue] | |
| QString fromType, | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:831:61: performance: Function parameter 'fromValue' should be passed by const reference. [passedByValue] | |
| QString fromValue, | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:832:61: performance: Function parameter 'toType' should be passed by const reference. [passedByValue] | |
| QString toType, | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:833:61: performance: Function parameter 'toValue' should be passed by const reference. [passedByValue] | |
| QString toValue) | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:852:59: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| QString name, | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:853:59: performance: Function parameter 'fromValue' should be passed by const reference. [passedByValue] | |
| QString fromValue, | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:1174:68: performance: Function parameter 'optionName' should be passed by const reference. [passedByValue] | |
| QStringList EditorConfig::remove_option(QStringList table, QString optionName) | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:26:22: style: Variable 'file_name' is assigned a value that is never used. [unreadVariable] | |
| QString file_name=fileinfo.fileName(); | |
| ^ | |
| app/src/libraries/wyedit/EditorConfig.cpp:27:22: style: Variable 'file_dir' is assigned a value that is never used. [unreadVariable] | |
| QString file_dir =fileinfo.path(); | |
| ^ | |
| app/src/libraries/wyedit/Editor.cpp:51:3: performance: Variable 'initDataConfigFileName' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| initDataConfigFileName=""; | |
| ^ | |
| app/src/libraries/wyedit/formatters/ImageFormatter.h:27:48: performance: Function parameter 'html' should be passed by const reference. [passedByValue] | |
| void downloadImagesSuccessfull(const QString html, | |
| ^ | |
| app/src/libraries/wyedit/formatters/ImageFormatter.h:36:39: performance: Function parameter 'html' should be passed by const reference. [passedByValue] | |
| void onDownloadImages(const QString html); | |
| ^ | |
| app/src/libraries/wyedit/EditorTextArea.h:44:37: performance: Function parameter 'href' should be passed by const reference. [passedByValue] | |
| void downloadImages(const QString href); | |
| ^ | |
| app/src/libraries/wyedit/EditorTextArea.h:59:50: performance: Function parameter 'html' should be passed by const reference. [passedByValue] | |
| void onDownloadImagesSuccessfull(const QString html, | |
| ^ | |
| app/src/libraries/wyedit/Editor.cpp:95:41: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| void Editor::initConfigFileName(QString name) | |
| ^ | |
| app/src/libraries/wyedit/Editor.cpp:113:46: performance: Function parameter 'toolNames' should be passed by const reference. [passedByValue] | |
| void Editor::initDisableToolList(QStringList toolNames) | |
| ^ | |
| app/src/libraries/wyedit/Editor.cpp:720:34: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] | |
| void Editor::setFileName(QString fileName) | |
| ^ | |
| app/src/libraries/wyedit/Editor.cpp:1502:49: performance: Function parameter 'value' should be passed by const reference. [passedByValue] | |
| void Editor::setMiscField(QString name, QString value) | |
| ^ | |
| app/src/libraries/wyedit/EditorCursorPositionDetector.cpp:13:31: warning: Member variable 'EditorCursorPositionDetector::textArea' is not initialized in the constructor. [uninitMemberVar] | |
| EditorCursorPositionDetector::EditorCursorPositionDetector() | |
| ^ | |
| app/src/libraries/wyedit/formatters/Formatter.cpp:8:12: warning: Member variable 'Formatter::editor' is not initialized in the constructor. [uninitMemberVar] | |
| Formatter::Formatter(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/formatters/Formatter.cpp:8:12: warning: Member variable 'Formatter::editorConfig' is not initialized in the constructor. [uninitMemberVar] | |
| Formatter::Formatter(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/formatters/Formatter.cpp:8:12: warning: Member variable 'Formatter::textArea' is not initialized in the constructor. [uninitMemberVar] | |
| Formatter::Formatter(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::bold' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::italic' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::underline' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::strikeout' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::monospace' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::superscript' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::subscript' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::code' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::clear' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::textOnly' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::fixBreakSymbol' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::undo' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::redo' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::numericList' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::dotList' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::indentPlus' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::indentMinus' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::alignLeft' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::alignCenter' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::alignRight' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::alignWidth' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::settings' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::fontSelect' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::fontSize' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::fontColor' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::backgroundColor' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::reference' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::showHtml' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::findText' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::showFormatting' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::createTable' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::tableRemoveRow' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::tableRemoveCol' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::tableAddRow' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::tableAddCol' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::tableMergeCells' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::tableSplitCell' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::tableProperties' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::insertImageFromFile' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::insertHorizontalLine' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::mathExpression' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::expandEditArea' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::expandToolsLines' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::save' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::back' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::findInBase' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::showText' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:13:16: warning: Member variable 'EditorToolBar::toAttach' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolBar::EditorToolBar(QWidget *parent) : QWidget(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorTextArea.cpp:285:6: style: The scope of the variable 'analysePoint' can be reduced. [variableScope] | |
| int analysePoint=0; | |
| ^ | |
| app/src/libraries/wyedit/EditorTextArea.cpp:557:64: performance: Function parameter 'html' should be passed by const reference. [passedByValue] | |
| void EditorTextArea::onDownloadImagesSuccessfull(const QString html, | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBarAssistant.cpp:19:60: performance: Function parameter 'iDisableToolList' should be passed by const reference. [passedByValue] | |
| QStringList iDisableToolList) : EditorToolBar(parent) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBarAssistant.cpp:131:57: performance: Function parameter 'fontFamily' should be passed by const reference. [passedByValue] | |
| void EditorToolBarAssistant::onChangeFontFamily(QString fontFamily) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:25:48: performance: Function parameter 'toolsLine' should be passed by const reference. [passedByValue] | |
| void EditorToolBar::initToolsLine1(QStringList toolsLine) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:34:48: performance: Function parameter 'toolsLine' should be passed by const reference. [passedByValue] | |
| void EditorToolBar::initToolsLine2(QStringList toolsLine) | |
| ^ | |
| app/src/libraries/wyedit/EditorToolBar.cpp:43:53: performance: Function parameter 'toolNames' should be passed by const reference. [passedByValue] | |
| void EditorToolBar::initDisableToolList(QStringList toolNames) | |
| ^ | |
| app/src/libraries/wyedit/EditorTextArea.cpp:285:18: style: Variable 'analysePoint' is assigned a value that is never used. [unreadVariable] | |
| int analysePoint=0; | |
| ^ | |
| app/src/libraries/wyedit/formatters/ImageFormatter.cpp:393:19: style: Local variable 'msgBox' shadows outer variable [shadowVariable] | |
| QMessageBox msgBox; | |
| ^ | |
| app/src/libraries/wyedit/formatters/ImageFormatter.cpp:290:15: note: Shadowed declaration | |
| QMessageBox msgBox; | |
| ^ | |
| app/src/libraries/wyedit/formatters/ImageFormatter.cpp:393:19: note: Shadow variable | |
| QMessageBox msgBox; | |
| ^ | |
| app/src/libraries/wyedit/formatters/ImageFormatter.cpp:279:53: performance: Function parameter 'html' should be passed by const reference. [passedByValue] | |
| void ImageFormatter::onDownloadImages(const QString html) | |
| ^ | |
| app/src/libraries/wyedit/formatters/MathExpressionFormatter.cpp:144:58: performance: Function parameter 'iMathExpressionText' should be passed by const reference. [passedByValue] | |
| void MathExpressionFormatter::editMathExpression(QString iMathExpressionText) | |
| ^ | |
| app/src/libraries/wyedit/formatters/MathExpressionFormatter.cpp:203:92: performance: Function parameter 'iFileName' should be passed by const reference. [passedByValue] | |
| void MathExpressionFormatter::createGifFromMathExpression(QString iMathExpression, QString iFileName, bool removeTeXFileToTrash) | |
| ^ | |
| app/src/libraries/wyedit/formatters/MathExpressionFormatter.cpp:255:70: performance: Function parameter 'iMathExpressionText' should be passed by const reference. [passedByValue] | |
| void MathExpressionFormatter::insertMathExpressionToTextArea(QString iMathExpressionText) | |
| ^ | |
| app/src/libraries/wyedit/mvc/controllers/editorToolbarSettings/EditorToolbarAvailableCommandsController.cpp:4:43: warning: Member variable 'EditorToolbarAvailableCommandsController::view' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolbarAvailableCommandsController::EditorToolbarAvailableCommandsController(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/mvc/controllers/editorToolbarSettings/EditorToolbarAvailableCommandsController.cpp:4:43: warning: Member variable 'EditorToolbarAvailableCommandsController::model' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolbarAvailableCommandsController::EditorToolbarAvailableCommandsController(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/mvc/controllers/editorToolbarSettings/EditorToolbarUsedCommandsController.cpp:7:38: warning: Member variable 'EditorToolbarUsedCommandsController::view' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolbarUsedCommandsController::EditorToolbarUsedCommandsController(GlobalParameters::EditorToolbar tb, QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/mvc/controllers/editorToolbarSettings/EditorToolbarUsedCommandsController.cpp:7:38: warning: Member variable 'EditorToolbarUsedCommandsController::model' is not initialized in the constructor. [uninitMemberVar] | |
| EditorToolbarUsedCommandsController::EditorToolbarUsedCommandsController(GlobalParameters::EditorToolbar tb, QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/libraries/wyedit/mvc/models/editorToolbarSettings/EditorToolbarUsedCommandsModel.h:21:5: style: Class 'EditorToolbarUsedCommandsModel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| EditorToolbarUsedCommandsModel(GlobalParameters::EditorToolbar tb, QObject *parent = nullptr); | |
| ^ | |
| app/src/libraries/wyedit/mvc/controllers/editorToolbarSettings/EditorToolbarUsedCommandsController.h:21:5: style: Class 'EditorToolbarUsedCommandsController' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| EditorToolbarUsedCommandsController(GlobalParameters::EditorToolbar tb, QObject *parent = nullptr); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TableFormatter.cpp:271:11: style: The scope of the variable 'pageWidthPix' can be reduced. [variableScope] | |
| qreal pageWidthPix=1; | |
| ^ | |
| app/src/libraries/wyedit/formatters/TableFormatter.cpp:271:23: style: Variable 'pageWidthPix' is assigned a value that is never used. [unreadVariable] | |
| qreal pageWidthPix=1; | |
| ^ | |
| app/src/models/actionLog/ActionLogModel.h:18:3: style: Class 'ActionLogModel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| ActionLogModel(QObject *parent); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:1286:16: style: Redundant initialization for 'textCursor'. The initialized value is overwritten before it is read. [redundantInitialization] | |
| textCursor = textArea->textCursor(); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:1285:28: note: textCursor is initialized | |
| QTextCursor textCursor = textArea->textCursor(); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:1286:16: note: textCursor is overwritten | |
| textCursor = textArea->textCursor(); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:1441:22: style: Redundant initialization for 'currentColor'. The initialized value is overwritten before it is read. [redundantInitialization] | |
| currentColor = textArea->textBackgroundColor(); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:1428:25: note: currentColor is initialized | |
| QColor currentColor = textArea->textBackgroundColor(); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:1441:22: note: currentColor is overwritten | |
| currentColor = textArea->textBackgroundColor(); | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:371:22: style: Variable 'stopCursorPos' is assigned a value that is never used. [unreadVariable] | |
| stopCursorPos=tempCursorPos; | |
| ^ | |
| app/src/libraries/wyedit/formatters/TypefaceFormatter.cpp:974:22: style: Variable 'stopCursorPos' is assigned a value that is never used. [unreadVariable] | |
| stopCursorPos=tempCursorPos; | |
| ^ | |
| app/src/models/appConfig/AppConfigUpdater.cpp:46:65: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| QString name, | |
| ^ | |
| app/src/models/appConfig/AppConfigUpdater.cpp:47:65: performance: Function parameter 'fromType' should be passed by const reference. [passedByValue] | |
| QString fromType, | |
| ^ | |
| app/src/models/appConfig/AppConfigUpdater.cpp:48:65: performance: Function parameter 'fromValue' should be passed by const reference. [passedByValue] | |
| QString fromValue, | |
| ^ | |
| app/src/models/appConfig/AppConfigUpdater.cpp:49:65: performance: Function parameter 'toType' should be passed by const reference. [passedByValue] | |
| QString toType, | |
| ^ | |
| app/src/models/appConfig/AppConfigUpdater.cpp:50:65: performance: Function parameter 'toValue' should be passed by const reference. [passedByValue] | |
| QString toValue) | |
| ^ | |
| app/src/main.cpp:318:5: style: Obsolete function 'qInstallMsgHandler' called. It is recommended to use 'qInstallMessageHandler' instead. [qInstallMsgHandlerCalled] | |
| qInstallMsgHandler(myMessageOutput); | |
| ^ | |
| app/src/models/attachTable/Attach.h:22:3: style: Class 'Attach' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| Attach(AttachTableData *iParentTable); | |
| ^ | |
| app/src/models/attachTable/AttachTableData.h:19:3: style: Class 'AttachTableData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| AttachTableData(Record *iRecord); | |
| ^ | |
| app/src/models/attachTable/AttachTableModel.h:37:3: style: Class 'AttachTableModel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| AttachTableModel(QObject *parent); | |
| ^ | |
| app/src/main.h:88:21: style: Local variable 'pMainWindow' shadows outer variable [shadowVariable] | |
| extern QObject *pMainWindow; | |
| ^ | |
| app/src/main.cpp:71:10: note: Shadowed declaration | |
| QObject *pMainWindow; | |
| ^ | |
| app/src/main.h:88:21: note: Shadow variable | |
| extern QObject *pMainWindow; | |
| ^ | |
| app/src/main.cpp:693:13: style: Local variable 'i' shadows outer variable [shadowVariable] | |
| for(int i=0; i<iconsFileList.size(); ++i) | |
| ^ | |
| app/src/main.cpp:668:11: note: Shadowed declaration | |
| for(int i=0; i<subdirList.size(); ++i) | |
| ^ | |
| app/src/main.cpp:693:13: note: Shadow variable | |
| for(int i=0; i<iconsFileList.size(); ++i) | |
| ^ | |
| app/src/main.cpp:105:28: performance: Function parameter 'message' should be passed by const reference. [passedByValue] | |
| void criticalError(QString message) | |
| ^ | |
| app/src/models/attachTable/Attach.h:34:50: performance: Function parameter 'type' should be passed by const reference. [passedByValue] | |
| static QString constructFileName(const QString type, const QString id, const QString fileName); | |
| ^ | |
| app/src/models/attachTable/Attach.h:34:70: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| static QString constructFileName(const QString type, const QString id, const QString fileName); | |
| ^ | |
| app/src/models/attachTable/Attach.h:34:88: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] | |
| static QString constructFileName(const QString type, const QString id, const QString fileName); | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:156:43: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| Attach AttachTableData::getAttach(QString id) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:182:44: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| void AttachTableData::modifyAttach(QString id, Attach iAttach) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:182:55: performance: Function parameter 'iAttach' should be passed by const reference. [passedByValue] | |
| void AttachTableData::modifyAttach(QString id, Attach iAttach) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:194:44: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| void AttachTableData::deleteAttach(QString id) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:221:41: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| int AttachTableData::getRowById(QString id) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:245:50: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| QString AttachTableData::getFileNameById(QString id) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:264:55: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| QString AttachTableData::getInnerFileNameById(QString id) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:308:59: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| QString AttachTableData::getFullInnerFileNameById(QString id) | |
| ^ | |
| app/src/models/attachTable/AttachTableData.cpp:327:63: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| QString AttachTableData::getAbsoluteInnerFileNameById(QString id) | |
| ^ | |
| app/src/models/attachTable/Attach.cpp:390:49: performance: Function parameter 'type' should be passed by const reference. [passedByValue] | |
| QString Attach::constructFileName(const QString type, const QString id, const QString fileName) | |
| ^ | |
| app/src/models/attachTable/Attach.cpp:390:69: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| QString Attach::constructFileName(const QString type, const QString id, const QString fileName) | |
| ^ | |
| app/src/models/attachTable/Attach.cpp:390:87: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] | |
| QString Attach::constructFileName(const QString type, const QString id, const QString fileName) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:14:12: warning: Member variable 'AppConfig::conf' is not initialized in the constructor. [uninitMemberVar] | |
| AppConfig::AppConfig(QObject *pobj) | |
| ^ | |
| app/src/models/dataBaseConfig/DataBaseConfig.cpp:24:17: warning: Member variable 'DataBaseConfig::conf' is not initialized in the constructor. [uninitMemberVar] | |
| DataBaseConfig::DataBaseConfig(QObject *pobj) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:239:47: performance: Function parameter 'list' should be passed by const reference. [passedByValue] | |
| void AppConfig::set_vspl_size_list(QList<int> list) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:251:47: performance: Function parameter 'list' should be passed by const reference. [passedByValue] | |
| void AppConfig::set_hspl_size_list(QList<int> list) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:263:55: performance: Function parameter 'list' should be passed by const reference. [passedByValue] | |
| void AppConfig::set_findsplitter_size_list(QList<int> list) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:270:54: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| QList<int> AppConfig::get_splitter_size_list(QString name) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:284:48: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| void AppConfig::set_splitter_size_list(QString name, QList<int> list) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:358:54: performance: Function parameter 'fieldName' should be passed by const reference. [passedByValue] | |
| bool AppConfig::get_findscreen_find_in_field(QString fieldName) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:364:54: performance: Function parameter 'fieldName' should be passed by const reference. [passedByValue] | |
| void AppConfig::set_findscreen_find_in_field(QString fieldName, bool isChecked) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:924:57: performance: Function parameter 'removeName' should be passed by const reference. [passedByValue] | |
| QStringList AppConfig::removeParameterFromTable(QString removeName, QStringList table) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:949:54: performance: Function parameter 'parameterName' should be passed by const reference. [passedByValue] | |
| QString AppConfig::getParameterTypeFromTable(QString parameterName, QStringList table) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:966:55: performance: Function parameter 'parameterName' should be passed by const reference. [passedByValue] | |
| QString AppConfig::getParameterValueFromTable(QString parameterName, QStringList table) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:983:56: performance: Function parameter 'replaceName' should be passed by const reference. [passedByValue] | |
| QStringList AppConfig::replaceParameterInTable(QString replaceName, QString replaceType, QString replaceValue, QStringList table) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:983:77: performance: Function parameter 'replaceType' should be passed by const reference. [passedByValue] | |
| QStringList AppConfig::replaceParameterInTable(QString replaceName, QString replaceType, QString replaceValue, QStringList table) | |
| ^ | |
| app/src/models/appConfig/AppConfig.cpp:983:98: performance: Function parameter 'replaceValue' should be passed by const reference. [passedByValue] | |
| QStringList AppConfig::replaceParameterInTable(QString replaceName, QString replaceType, QString replaceValue, QStringList table) | |
| ^ | |
| app/src/models/recordTable/Record.cpp:30:3: performance: Variable 'fieldList' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| fieldList=obj.fieldList; | |
| ^ | |
| app/src/models/recordTable/Record.cpp:31:3: performance: Variable 'text' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| text=obj.text; | |
| ^ | |
| app/src/models/recordTable/Record.cpp:32:3: performance: Variable 'pictureFiles' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| pictureFiles=obj.pictureFiles; | |
| ^ | |
| app/src/models/recordTable/Record.cpp:33:3: performance: Variable 'attachTableData' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| attachTableData=obj.attachTableData; | |
| ^ | |
| app/src/models/recordTable/RecordTableData.cpp:528:48: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| void RecordTableData::deleteRecordById(QString id) | |
| ^ | |
| app/src/models/recordTable/RecordTableData.cpp:556:46: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| bool RecordTableData::isRecordExists(QString id) | |
| ^ | |
| app/src/models/recordTable/RecordTableData.cpp:576:41: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| int RecordTableData::getPosById(QString id) | |
| ^ | |
| app/src/models/recordTable/Record.cpp:258:44: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| QString Record::getCalculableField(QString name) const | |
| ^ | |
| app/src/models/recordTable/Record.cpp:852:41: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] | |
| QString Record::getFullFileName(QString fileName) const | |
| ^ | |
| app/src/models/shortcutSettings/ShortcutSettingsModel.cpp:9:5: performance: Variable 'copyShortcutManager' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| copyShortcutManager=shortcutManager; | |
| ^ | |
| app/src/models/tree/TreeItem.h:126:10: style: Unused private function: 'TreeItem::removeChildrenLink' [unusedPrivateFunction] | |
| bool removeChildrenLink(int position, int count); | |
| ^ | |
| app/src/models/tree/TreeItem.cpp:21:3: performance: Variable 'fieldsTable' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| fieldsTable = data; | |
| ^ | |
| app/src/models/tree/TreeItem.h:18:5: style: Class 'TreeItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| TreeItem(const QMap<QString, QString> &data, TreeItem *parent = nullptr); | |
| ^ | |
| app/src/models/tree/TreeItem.cpp:477:64: performance: Function parameter 'fieldName' should be passed by const reference. [passedByValue] | |
| QList<QStringList> TreeItem::getAllChildrenPathAsField(QString fieldName) | |
| ^ | |
| app/src/models/tree/TreeModel.cpp:15:12: warning: Member variable 'TreeModel::rootItem' is not initialized in the constructor. [uninitMemberVar] | |
| TreeModel::TreeModel(QObject *parent) : QAbstractItemModel(parent) | |
| ^ | |
| app/src/views/actionLog/ActionLogView.cpp:16:16: warning: Member variable 'ActionLogView::controller' is not initialized in the constructor. [uninitMemberVar] | |
| ActionLogView::ActionLogView(QWidget *parent) : QTableView(parent) | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Main.h:28:7: style: The function 'applyChanges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigPage.h:15:15: note: Virtual function in base class | |
| virtual int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Main.h:28:7: note: Function in derived class | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Crypt.h:23:7: style: The function 'applyChanges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigPage.h:15:15: note: Virtual function in base class | |
| virtual int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Crypt.h:23:7: note: Function in derived class | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Misc.h:20:7: style: The function 'applyChanges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigPage.h:15:15: note: Virtual function in base class | |
| virtual int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Misc.h:20:7: note: Function in derived class | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Synchro.h:21:7: style: The function 'applyChanges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigPage.h:15:15: note: Virtual function in base class | |
| virtual int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Synchro.h:21:7: note: Function in derived class | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_RecordTable.h:17:7: style: The function 'applyChanges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigPage.h:15:15: note: Virtual function in base class | |
| virtual int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_RecordTable.h:17:7: note: Function in derived class | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Attach.h:24:7: style: The function 'applyChanges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigPage.h:15:15: note: Virtual function in base class | |
| virtual int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Attach.h:24:7: note: Function in derived class | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Keyboard.h:21:7: style: The function 'applyChanges' overrides a function in a base class but is not marked with a 'override' specifier. [missingOverride] | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigPage.h:15:15: note: Virtual function in base class | |
| virtual int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_Keyboard.h:21:7: note: Function in derived class | |
| int applyChanges(void); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigDialog.cpp:52:42: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| void AppConfigDialog::changePage(QString name) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:31:3: performance: Variable 'xmlFileName' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| xmlFileName=""; | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:111:34: style: Condition 'updateSubVersionFrom1To2()==false' is always false [knownConditionTrueFalse] | |
| if(updateSubVersionFrom1To2()==false) // Смена формата с 1.1 на 1.2 | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:823:43: style: C-style pointer casting [cstyleCast] | |
| pasted_branch_id=pasteSubbranch(parent, (ClipboardBranch *)subbranch); | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:839:43: style: C-style pointer casting [cstyleCast] | |
| pasted_branch_id=pasteSubbranch(parent, (ClipboardBranch *)subbranch); | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:45:41: performance: Function parameter 'fileName' should be passed by const reference. [passedByValue] | |
| void KnowTreeModel::initFromXML(QString fileName) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:238:74: performance: Function parameter 'exportDir' should be passed by const reference. [passedByValue] | |
| bool KnowTreeModel::exportBranchToDirectory(TreeItem *startItem, QString exportDir) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:302:82: performance: Function parameter 'exportDir' should be passed by const reference. [passedByValue] | |
| void KnowTreeModel::exportRelatedDataAndDecryptIfNeed(QDomDocument &doc, QString exportDir) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:318:92: performance: Function parameter 'exportDir' should be passed by const reference. [passedByValue] | |
| void KnowTreeModel::exportRelatedDataAndDecryptIfNeedRecurse(QDomElement &element, QString exportDir) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:403:79: performance: Function parameter 'importDir' should be passed by const reference. [passedByValue] | |
| QString KnowTreeModel::importBranchFromDirectory(TreeItem *startItem, QString importDir) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:469:58: performance: Function parameter 'importDir' should be passed by const reference. [passedByValue] | |
| QString importDir, | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1003:44: performance: Function parameter 'findId' should be passed by const reference. [passedByValue] | |
| bool KnowTreeModel::isItemIdExists(QString findId) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1012:67: performance: Function parameter 'findId' should be passed by const reference. [passedByValue] | |
| bool KnowTreeModel::isItemIdExistsRecurse(TreeItem *item, QString findId, int mode) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1043:46: performance: Function parameter 'findId' should be passed by const reference. [passedByValue] | |
| bool KnowTreeModel::isRecordIdExists(QString findId) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1083:47: performance: Function parameter 'findDir' should be passed by const reference. [passedByValue] | |
| bool KnowTreeModel::isRecordDirExists(QString findDir) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1092:70: performance: Function parameter 'findDir' should be passed by const reference. [passedByValue] | |
| bool KnowTreeModel::isRecordDirExistsRecurse(TreeItem *item, QString findDir, int mode) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1243:46: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| TreeItem *KnowTreeModel::getItemById(QString id) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1253:69: performance: Function parameter 'id' should be passed by const reference. [passedByValue] | |
| TreeItem *KnowTreeModel::getItemByIdRecurse(TreeItem *item, QString id, int mode) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1281:50: performance: Function parameter 'recordId' should be passed by const reference. [passedByValue] | |
| QStringList KnowTreeModel::getRecordPath(QString recordId) | |
| ^ | |
| app/src/models/tree/KnowTreeModel.cpp:1198:21: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] | |
| subbranch_list=one_line.subbranches_id; | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_RecordTable.cpp:218:41: style: Argument '(int)insertFieldWidth' to function number is always 100 [constArgument] | |
| newFieldsWidth << QString::number( (int)insertFieldWidth ); | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_RecordTable.cpp:206:30: note: Assignment 'insertFieldWidth=100.0', assigned value is 100.0 | |
| float insertFieldWidth=100.0; | |
| ^ | |
| app/src/views/appConfigWindow/AppConfigPage_RecordTable.cpp:218:41: note: Argument '(int)insertFieldWidth' to function number is always 100 | |
| newFieldsWidth << QString::number( (int)insertFieldWidth ); | |
| ^ | |
| app/src/views/appConfigWindow/ConfigDialog.cpp:82:70: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| QListWidgetItem *ConfigDialog::addWidget(QWidget *inswidget, QString name) | |
| ^ | |
| app/src/views/consoleEmulator/ConsoleEmulator.cpp:108:48: performance: Function parameter 'text' should be passed by const reference. [passedByValue] | |
| void ConsoleEmulator::addConsoleOutput(QString text) | |
| ^ | |
| app/src/views/dialog/OverTextToolButton.cpp:9:3: performance: Variable 'overText' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| overText=""; | |
| ^ | |
| app/src/views/dialog/OverTextToolButton.cpp:13:46: performance: Function parameter 'iText' should be passed by const reference. [passedByValue] | |
| void OverTextToolButton::setOverText(QString iText) | |
| ^ | |
| app/src/views/consoleEmulator/ExecuteCommand.cpp:19:17: warning: Member variable 'ExecuteCommand::process' is not initialized in the constructor. [uninitMemberVar] | |
| ExecuteCommand::ExecuteCommand(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/views/consoleEmulator/ExecuteCommand.cpp:19:17: warning: Member variable 'ExecuteCommand::isError' is not initialized in the constructor. [uninitMemberVar] | |
| ExecuteCommand::ExecuteCommand(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/views/consoleEmulator/ExecuteCommand.cpp:19:17: warning: Member variable 'ExecuteCommand::isManualClose' is not initialized in the constructor. [uninitMemberVar] | |
| ExecuteCommand::ExecuteCommand(QObject *parent) : QObject(parent) | |
| ^ | |
| app/src/views/consoleEmulator/ExecuteCommand.cpp:21:2: performance: Variable 'command' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| command=""; | |
| ^ | |
| app/src/views/consoleEmulator/ExecuteCommand.cpp:70:41: performance: Function parameter 'cmd' should be passed by const reference. [passedByValue] | |
| void ExecuteCommand::setCommand(QString cmd) | |
| ^ | |
| app/src/views/consoleEmulator/ExecuteCommand.cpp:76:45: performance: Function parameter 'title' should be passed by const reference. [passedByValue] | |
| void ExecuteCommand::setWindowTitle(QString title) | |
| ^ | |
| app/src/views/consoleEmulator/ExecuteCommand.cpp:82:45: performance: Function parameter 'text' should be passed by const reference. [passedByValue] | |
| void ExecuteCommand::setMessageText(QString text) | |
| ^ | |
| app/src/views/enterPassword/EnterPassword.cpp:22:2: performance: Variable 'password' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| password=""; | |
| ^ | |
| app/src/views/enterPassword/EnterPassword.cpp:23:2: performance: Variable 'previousPassword' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| previousPassword=""; | |
| ^ | |
| app/src/views/enterPassword/EnterPassword.h:22:2: style: Class 'EnterPassword' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| EnterPassword(int imode, QWidget *parent=nullptr); | |
| ^ | |
| app/src/views/findInBaseScreen/FindTableWidget.cpp:185:56: performance: Function parameter 'iOverdrawMessage' should be passed by const reference. [passedByValue] | |
| void FindTableWidget::setOverdrawMessage(const QString iOverdrawMessage) | |
| ^ | |
| app/src/views/printPreview/PreviewView.h:13:5: style: Class 'PreviewView' has a constructor with 1 argument that is not explicit. [noExplicitConstructor] | |
| PreviewView(QTextDocument *document); | |
| ^ | |
| app/src/views/findInBaseScreen/FindScreen.cpp:632:7: style: The scope of the variable 'findFlag' can be reduced. [variableScope] | |
| int findFlag=0; | |
| ^ | |
| app/src/views/findInBaseScreen/FindTableWidget.h:24:41: performance: Function parameter 'iOverdrawMessage' should be passed by const reference. [passedByValue] | |
| void setOverdrawMessage(const QString iOverdrawMessage); // Установка надписи, которая появляется поверх виджета | |
| ^ | |
| app/src/views/findInBaseScreen/FindScreen.cpp:368:34: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] | |
| if(value==true)findEnableFlag=1; | |
| ^ | |
| app/src/views/findInBaseScreen/FindScreen.cpp:596:32: style: Consider using std::accumulate algorithm instead of a raw loop. [useStlAlgorithm] | |
| if(value==true)findFlag=1; | |
| ^ | |
| app/src/views/findInBaseScreen/FindScreen.cpp:632:15: style: Variable 'findFlag' is assigned a value that is never used. [unreadVariable] | |
| int findFlag=0; | |
| ^ | |
| app/src/views/record/InfoFieldEnter.cpp:118:50: performance: Function parameter 'expand' should be passed by const reference. [passedByValue] | |
| void InfoFieldEnter::expandInfoOnDisplay(QString expand) | |
| ^ | |
| app/src/views/record/InfoFieldEnter.cpp:168:45: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| bool InfoFieldEnter::checkFieldName(QString name) | |
| ^ | |
| app/src/views/record/InfoFieldEnter.cpp:180:42: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| QString InfoFieldEnter::getField(QString name) | |
| ^ | |
| app/src/views/record/InfoFieldEnter.cpp:196:39: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| void InfoFieldEnter::setField(QString name,QString value) | |
| ^ | |
| app/src/views/record/MetaEditor.cpp:206:35: performance: Function parameter 'n' should be passed by const reference. [passedByValue] | |
| void MetaEditor::setField(QString n, QString v) | |
| ^ | |
| app/src/views/record/MetaEditor.cpp:206:46: performance: Function parameter 'v' should be passed by const reference. [passedByValue] | |
| void MetaEditor::setField(QString n, QString v) | |
| ^ | |
| app/src/views/record/MetaEditor.cpp:244:38: performance: Function parameter 'path' should be passed by const reference. [passedByValue] | |
| void MetaEditor::setTreePath(QString path) | |
| ^ | |
| app/src/views/mainWindow/MainWindow.cpp:529:12: style: Local variable 'menu' shadows outer variable [shadowVariable] | |
| QMenu *menu = new QMenu(tr("&Preferences"), this); | |
| ^ | |
| app/src/views/mainWindow/MainWindow.cpp:510:10: note: Shadowed declaration | |
| QMenu *menu = new QMenu(tr("&Tools"), this); | |
| ^ | |
| app/src/views/mainWindow/MainWindow.cpp:529:12: note: Shadow variable | |
| QMenu *menu = new QMenu(tr("&Preferences"), this); | |
| ^ | |
| app/src/views/mainWindow/MainWindow.cpp:209:46: style: Parameter 'manager' can be declared with const [constParameter] | |
| void MainWindow::commitData(QSessionManager& manager) | |
| ^ | |
| app/src/views/recordTable/RecordTablePrint.cpp:146:47: performance: Function parameter 'title' should be passed by const reference. [passedByValue] | |
| void RecordTablePrint::setTitleToHtml(QString title) | |
| ^ | |
| app/src/views/recordTable/RecordTableScreen.cpp:565:45: performance: Function parameter 'path' should be passed by const reference. [passedByValue] | |
| void RecordTableScreen::setTreePath(QString path) | |
| ^ | |
| app/src/views/recordTable/RecordTableView.cpp:198:19: style: Variable 'deselectRecord' is assigned a value that is never used. [unreadVariable] | |
| deselectRecord=deselected.indexes().at(0); | |
| ^ | |
| app/src/views/waitClock/WaitClock.cpp:12:2: performance: Variable 'kadr_00' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| kadr_00=QIcon(":/resource/pic/waitclock_00.svg").pixmap(32, 32); | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:39:3: performance: Variable 'lastKnowTreeModifyDateTime' is assigned in constructor body. Consider performing initialization in initialization list. [useInitializationList] | |
| lastKnowTreeModifyDateTime=QDateTime(); | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:300:21: style: Redundant condition: cryptFlag=="1". 'A || (!A && B)' is equivalent to 'A || B' [redundantCondition] | |
| if(cryptFlag!="1" || | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:1130:64: style: C-style pointer casting [cstyleCast] | |
| pasted_branch_id=knowTreeModel->pasteNewSiblingBranch(index, (ClipboardBranch *)branch); | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:1132:62: style: C-style pointer casting [cstyleCast] | |
| pasted_branch_id=knowTreeModel->pasteNewChildBranch(index, (ClipboardBranch *)branch); | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:1456:41: style: Local variable 'i' shadows outer variable [shadowVariable] | |
| QMapIterator<QString, QAction *> i(actionList); | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:1436:35: note: Shadowed declaration | |
| QMapIterator<QString, QAction *> i(actionList); | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:1456:41: note: Shadow variable | |
| QMapIterator<QString, QAction *> i(actionList); | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:563:62: performance: Function parameter 'name' should be passed by const reference. [passedByValue] | |
| void TreeScreen::insBranchProcess(QModelIndex index, QString name, bool is_branch) | |
| ^ | |
| app/src/views/tree/TreeScreen.cpp:676:36: performance: Function parameter 'mode' should be passed by const reference. [passedByValue] | |
| void TreeScreen::delBranch(QString mode) | |
| ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment