-
-
Save jugglinmike/49625aa2c75976d0f00f9021452c1597 to your computer and use it in GitHub Desktop.
sw-migration-request.diff
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/request-end-to-end.https.html | |
| index 04fa30b..7b594aa 100644 | |
| --- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html | |
| +++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/request-end-to-end.https.html | |
| @@ -1,13 +1,8 @@ | |
| <!DOCTYPE html> | |
| -<!-- This test is prefixed with `chromium.` because the equivalent version | |
| - available in Web Platform Tests contains additional assertions which Chromium | |
| - currently fails. This test should be persisted only to preserve test coverage | |
| - until such time as the upstream version can be made to pass. See | |
| - https://crbug.com/595993 --> | |
| <title>Service Worker: FetchEvent.request passed to onfetch</title> | |
| -<script src="../resources/testharness.js"></script> | |
| -<script src="../resources/testharnessreport.js"></script> | |
| -<script src="resources/test-helpers.js"></script> | |
| +<script src="/resources/testharness.js"></script> | |
| +<script src="/resources/testharnessreport.js"></script> | |
| +<script src="resources/test-helpers.sub.js"></script> | |
| <script> | |
| 'use strict'; | |
| @@ -34,13 +29,9 @@ promise_test(t => { | |
| 'TypeError.') | |
| assert_equals(result.credentials, 'include', 'request.credentials'); | |
| assert_equals(result.redirect, 'manual', 'request.redirect'); | |
| - // TODO(falken): Chromium should fail this assertion but currently | |
| - // passes it. The equivalent WPT test instead asserts: | |
| - // assert_equals(result.headers['user-agent'], undefined); | |
| - // Once Chromium passes the WPT test assertion, this test file can be | |
| - // removed. | |
| - assert_equals(result.headers['user-agent'], navigator.userAgent, | |
| - 'User-Agent header'); | |
| + assert_equals(result.headers['user-agent'], undefined, | |
| + 'Default User-Agent header should not be passed to ' + | |
| + 'onfetch event.') | |
| assert_equals(result.append_header_error, 'TypeError', | |
| 'Appending a new header to the request must throw a ' + | |
| 'TypeError.') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment