Skip to content

Instantly share code, notes, and snippets.

Julian Descottes juliandescottes

Block or report user

Report or block juliandescottes

Hide content and notifications from this user.

Learn more about blocking users

Contact Support about this user’s behavior.

Learn more about reporting abuse

Report abuse
View GitHub Profile
View front_onFront_naming_proposal.md

API consistency between Front and TargetList

Fronts have onFront(type, callback), offFront(type, callback). The TargetList has listen(type, createCallback, destroyCallback) and unlisten(type, createCallback, destroyCallback).

The two APIs seem to care about similar lifecycles, so it would be great if the API had a similar shape. Having a single method with 2 callbacks means all consumers need to attach their listeners for creation and destruction at the same spot. It might not be flexible enough in all situations?

Proposal 1:

View debugger_server_setupInChild_usage.txt
DebuggerServer setupInChild is one of the methods relying on message manager.
I was trying to track down the current usage for this method, it seems only used in tests?
setupInChild usage:
- registerActor and unregisterActor in devtools/server/actors/utils/actor-registry-utils.js
actor-registry-utils usage:
- imported by actor-registry.js (actor)
- used in ActorActor::unregister and ActorRegistryActor::registerActor
View fluent_error_log.txt
console.error: "VariableReference@resource://gre/modules/Fluent.jsm:325:9
resolveExpression@resource://gre/modules/Fluent.jsm:283:14
resolveComplexPattern@resource://gre/modules/Fluent.jsm:443:18
formatPattern@resource://gre/modules/Fluent.jsm:700:19
getString@resource://devtools/client/shared/vendor/fluent-react.js:67:25
getString@resource://devtools/client/shared/vendor/fluent-react.js:231:21
getString@resource://devtools/client/shared/vendor/fluent-react.js:239:44
updateTitle@resource://devtools/client/aboutdebugging-new/src/components/App.js:64:11
componentDidUpdate@resource://devtools/client/aboutdebugging-new/src/components/App.js:56:10
commitLifeCycles@resource://devtools/client/shared/vendor/react-dom.js:12958:22
View netmonitor_wsactor_leak.diff
diff --git a/devtools/server/actors/network-monitor/websocket-actor.js b/devtools/server/actors/network-monitor/websocket-actor.js
--- a/devtools/server/actors/network-monitor/websocket-actor.js
+++ b/devtools/server/actors/network-monitor/websocket-actor.js
@@ -18,17 +18,17 @@ const webSocketEventService = Cc[
*
* @see devtools/shared/spec/websocket.js for documentation.
*/
const WebSocketActor = ActorClassWithSpec(webSocketSpec, {
initialize(conn, targetActor) {
Actor.prototype.initialize.call(this, conn);
View devtools_frametype_content_leak.log
0:00.48 INFO Checking for ssltunnel processes...
0:00.49 INFO Checking for xpcshell processes...
0:00.50 SUITE_START: mochitest-browser - running 1 tests
0:00.50 INFO Running manifest: devtools/client/testpanel/test/browser/browser.ini
pk12util: PKCS12 IMPORT SUCCESSFUL
0:00.90 INFO Increasing default timeout to 90 seconds
0:00.91 INFO MochitestServer : launching [u'/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/dist/bin/xpcshell', '-g', u'/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/dist/NightlyDebug.app/Contents/Resources', '-f', u'/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/dist/bin/components/httpd.js', '-e', "const _PROFILE_PATH = '/var/folders/pr/159qkz_52tx_4kz9h6m574j00000gn/T/tmpUNLLpa.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/_tests/testing/mochitest/server.js']
0:00
View puppeteer_summary.txt
FAIL packages/e2e-tests/specs/plugins/annotations.test.js (113.136s)
FAIL packages/e2e-tests/specs/preview.test.js (313.414s)
FAIL packages/e2e-tests/specs/adding-inline-tokens.test.js (102.706s)
FAIL packages/e2e-tests/specs/block-transforms.test.js (51.121s)
FAIL packages/e2e-tests/specs/links.test.js (47.827s)
FAIL packages/e2e-tests/specs/editor-modes.test.js (38.85s)
FAIL packages/e2e-tests/specs/writing-flow.test.js (29.454s)
FAIL packages/e2e-tests/specs/splitting-merging.test.js (18.514s)
FAIL packages/e2e-tests/specs/datepicker.test.js
FAIL packages/e2e-tests/specs/keyboard-navigable-blocks.test.js (6.582s)
View puppeteer_log_failure.log
jdescottes@kglazko-23706:~/Development/git/gutenberg$ npm run test-e2e
> gutenberg@5.4.0 pretest-e2e /Users/jdescottes/Development/git/gutenberg
> cross-env SCRIPT_DEBUG=false ./bin/reset-e2e-tests.sh
STATUS: Attempting to connect to WordPress...
STATUS: Resetting test database...
Starting gutenberg_mysql_1 ... done
Starting gutenberg_wordpress_e2e_tests_1 ... done
STATUS: Installing WordPress...
View remote_class_diagram.txt
┌─────────────────────────────────────────────────┐
│ │
1 ▼ │
┌───────────────┐ 1 ┌───────────────┐ 1..n┌───────────────┐
│ RemoteAgent │──────▶│ HttpServer │◀───────▶│ JsonHandler │
└───────────────┘ └───────────────┘ 1 └───────────────┘
│ 1 ┌────────────┐ 1
└───────────────▶│ Targets │◀─┐
View puppeteer_unit_tests_log.txt
CHROME=/Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/dist/Nightly.app/Contents/MacOS/firefox DUMPIO=true node test/test.js
WARN: running tests with /Users/jdescottes/Development/hg/fx-team-artifact/objdir.noindex/dist/Nightly.app/Contents/MacOS/firefox
Testing on Node v11.8.0
Running 1 worker(s):
*** You are running in headless mode.
1562175601845 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: mozillaAddons
1562175601845 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: telemetry
1562175601846 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: resource://pdf.js/
1562175601846 addons.webextension.screenshots@mozilla.org WARN Loading extension 'screenshots@mozilla.org': Reading manifest: Invalid extension permission: a
View intermittent_typing_test.js
// Content page script
window.value = "init-value";
document.querySelector("input").addEventListener("input", () => {
// Slow down the handler a bit
for (var i = 0 ; i < 1000; i++) {
console.log(i);
}
// Update the value that will be checked by the test
window.value = document.querySelector("input").value;
You can’t perform that action at this time.