Skip to content

Instantly share code, notes, and snippets.

@k88hudson

k88hudson/check-export-as.md

Last active March 5, 2018 17:59
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save k88hudson/0df060bbad3cc587c5ffbae96479fc90 to your computer and use it in GitHub Desktop.
Save k88hudson/0df060bbad3cc587c5ffbae96479fc90 to your computer and use it in GitHub Desktop.
Download ZIP
Checklist for AS exports
Raw
check-export-as.md

Reviewboard checklist

  • Check each file
  • Check if try was run, if there are test failures
  • Check more closely/ask additional questions if there changes that might have significant impact on:
    • accessibility
    • security
    • performance
  • Check if export files match git commit range
  • If new localization implementaion, check ID (Indonesia) locale is there
  • Check if comments on review board actually published

Run tests

  • ./mach build && ./mach package && ./mach test browser/extensions/activity-stream/ browser/components/newtab/ && ./mach test all_files_referenced | grep activity-stream

Manual QA checklist

  • Does the prerendered version work for default settings?
    • (⌘U to check the rendered output)
  • Does the non-prerendered version work?
    • (turn off search and refresh to trigger non-prerendered)
  • Test prerendered/non-prerendered with dev pref on
    • (Set browser.newtabpage.activity-stream.debug = true in about:config)
    • Refresh and check for warnings in console
  • Check (1) rtl lang (e.g. Hebrew) and (2) longer string language (e.g. German)
  • Check context menus
  • Check prefs pane
  • Check top sites placeholder hovering/editing
  • Check drag and drop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment