Skip to content

Instantly share code, notes, and snippets.

@kaborso
Last active December 31, 2015 18:38
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save kaborso/8027787 to your computer and use it in GitHub Desktop.
Save kaborso/8027787 to your computer and use it in GitHub Desktop.
  1. read CMD instruction from dockerfile rather than require user to write it again in maestro.yml
  • admittedly, having all the commands in one spot is easier to read
  • from readme -- "Note: Command is required by the Docker Python api and having to specify it here can cause problems with images that pre-define entrypoints and commands."
  1. support singular 'port' as well as plural in config section (like in require section)
  2. fix 'mount' (should actually mount a host directory)
  • ahh, maybe this will work: http://stackoverflow.com/questions/18208297/docker-remote-api-binds#18210059
    • does docker-py handle these options and, if so, can maestro pass them along?
      • looks like docker-py does, but I think maestro's not passing things along correctly
        • the readme's example should say 'binds' not 'bindings'
          • actually, maestro maps 'mounts' to 'binds'
      • this maestro code needs some TLC
        • why isn't 'volumes' just a list in the yaml?
          • why not only do the dictionary stuff in the code
          • why not use #values instead of items?
      • discovered my problem: I said "mount" instead of "mounts"
        • now I know a lot more about maestro than I did when I first came in
  1. fix 'command' (should support &&)
  • for now, how about '/bin/bash -c "your commands here"'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment