Skip to content

Instantly share code, notes, and snippets.

@karllhughes

karllhughes/tgn-pr-template.md

Last active April 12, 2018 16:44
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save karllhughes/7620f64ec96095d37af408cbce242200 to your computer and use it in GitHub Desktop.
Save karllhughes/7620f64ec96095d37af408cbce242200 to your computer and use it in GitHub Desktop.
Download ZIP
TGN PR Template
Raw
tgn-pr-template.md

Checklist for Reviewee:

  • Add a link to the relevant Trello card(s) and move the card into the "Testing" column.
  • Add appropriate unit and integration tests.
  • Plan for any Ghost Inspector tests (to be added after merging).
  • The CI has passed (check Codeship).
  • Manually check any new or changed functionality.
  • Manually check for accessiblity issues using WAVE.
  • Update/create any ADRs or API documentation if needed.
  • Attach a reviewer and included important notes in comments.

Checklist for Reviewer:

  • Manually check any new or changed functionality.
  • Unit and integration tests are sufficient and passing (check Codeship).
  • Ghost Inspector tests are planned if required.
  • Relevant ADRs and API documentation are updated.
  • Questions or feedback have been left in the comments.
  • Questions about code quality and improvements have been sufficiently addressed.
  • When merged, move the Trello card(s) into the "Develop" column.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment