Create a gist now

Instantly share code, notes, and snippets.

sleep vs. wait_until
def add_and_save_notes notes
fill_in("my_target_text_box":with => notes)
click_button "Save" # This makes an AJAX request and adds new row to the table upon successfully saving
sleep(3) #<-- This is BAD code. You should have the line below in place of this one.
#wait_until { has_text?(notes) } #<-- This is GOOD practice that enables test stability and hence faith in test results
def has_note? notes
describe "save notes" do
it "should add notes as new row to table upon successful save" do
notes = "sample notes"
@my_target_page. add_and_save_notes notes
@my_target_page.has_note?(notes).should be_true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment