Skip to content

Instantly share code, notes, and snippets.

@karthiks
Created August 25, 2012 15:42
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save karthiks/3467215 to your computer and use it in GitHub Desktop.
Save karthiks/3467215 to your computer and use it in GitHub Desktop.
sleep vs. wait_until
#my_target_page.rb
def add_and_save_notes notes
fill_in("my_target_text_box", :with => notes)
click_button "Save" # This makes an AJAX request and adds new row to the table upon successfully saving
sleep(3) #<-- This is BAD code. You should have the line below in place of this one.
#wait_until { has_text?(notes) } #<-- This is GOOD practice that enables test stability and hence faith in test results
end
def has_note? notes
has_text?(notes)
end
#my_target_spec.rb
describe "save notes" do
it "should add notes as new row to table upon successful save" do
notes = "sample notes"
@my_target_page. add_and_save_notes notes
@my_target_page.has_note?(notes).should be_true
end
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment