Skip to content

Instantly share code, notes, and snippets.

@katat
Last active August 11, 2020 06:49
Show Gist options
  • Save katat/689e7d9ea4b5c0b785fe6806fcfa8afa to your computer and use it in GitHub Desktop.
Save katat/689e7d9ea4b5c0b785fe6806fcfa8afa to your computer and use it in GitHub Desktop.
GrowFI milestone 2 review feedback

Milestone 2 review

The web app is integrated with the Synapse wallet in a form of Chrome extension, which in turn interacts with the contracts on CKB chain. It achieved all the key functions, such as creating liquidity pool / add liquidity to existing pool / exit from a liquidity pool / swap between UDTs and CKB. Although the UI is working, but I think it will need some polishments to improve the user experiences to be more intuitive.

The integration tests also demonstrates these key functions on UDTSwap are working as expected. There were some problems in the test setup documentation, but they did provide detailed steps for me to be able to setup my local environment to successfully execute these integration tests. I suggested them to encapsulate these complicated setup steps into a script, which they agreed. After some conversions with the team, they did improve the deployment script to be easy enough to run the integration test.

Overall, I think the UDTSwap works as expected as a prototype. It demonstrates DEFI apps can work on CKB as well. The outstanding issue, which Jan point out in the discord channel, is that currently the transaction requires a fixed protocol protection fees (61 CKB), which could be too expensive in a long run.

In my opinion, this protection fee issue is due to our current low transaction fee, which could encourage DOS attack to any Dapps for whatever reasons. If I understand correctly, for the time being, with the volume of transactions grows on CKB, and its native token price gradually raises and so is the mining fees, this protection fee would be deprecated at a certain point of time and replace with a minimum trade fee on the swap token.

If the goal of the grants is to demonstrate the ideas via prototypes and plant the seeds for growing the ecosystems, I think UDTSwap did a good job in implementing this DEFI contract/dapp (migrate UniSwap from Ethereum) on CKB, considering the difficulties in developing contract in C language under the current CKB programming model.

However, if this grant is meant to be production ready, then I think they have to be excelled at the code quality as the security is the first priority in this type of dapp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment