concrete5: Helpdesk Addon: Internaitonalization

c5HelpdeskInt8.txt

Well wrapped for t().
I suggest for the tiny adjustment

Found a couple minor stuff
/controllers/dashboard/helpdesk/search_article.php

On line 54

[code]$this->set('message', t('"'.$name.'" has been deleted'));
[/code]


/controllers/helpdesk/ticket.php
On line 120
[code]'ticketResponseDate'=> date('Y-m-d h:m:s'),[/code]
Perhaps, you could use 'DATE_APP_GENERIC_MDYT_FULL_SECONDS'

/elemtns/dashboard/install.php
On line 26
[code]
	echo '<img src="'.ASSETS_URL_IMAGES.'/icons/error.png" width="16" height="16"/> &nbsp; <strong>Helpdesk '.t('is not installed').'</strong>';
[/code]
Don't forget to wrap "Helpdesk"

[code]
	echo '<img src="'.ASSETS_URL_IMAGES.'/icons/error.png" width="16" height="16"/> &nbsp; <strong>'.t('Helpdesk is not installed').'</strong>';
[/code]


jobs/helpdesk_job.php

The return messages are not wrapped with t().

/single_page/helpdesk/knowledgebase.php
On line 30
[code]
	<p class="text-center instructions"><?php echo t('Login to track your existing support requests. If you have not created a ticket yet then you would need to <a href="'.BASE_URL.DIR_REL.'/index.php/register/"><b>register</b></a> or <a href="'.BASE_URL.DIR_REL.'/index.php/helpdesk/ticket/"><b>create a new ticket</b></a> to begin')?></p>
[/code]

... my suggestion

[code]
	<?php $registerURL = View::url('/register');
	$newticketURL = BASE_URL.DIR_REL.'/index.php/helpdesk/ticket/'; ?>
	<p class="text-center instructions"><?php echo t('Login to track your existing support requests. If you have not created a ticket yet then you would need to <a href="%$1"><b>register</b></a> or <a href="%$2"><b>create a new ticket</b></a> to begin', $register, $newticketURL )?></p>
[/code]

On line 71
[code]
	print '<div class="text-center no_results"><div class="alert alert-info"><i class="icon icon-frown"></i> '.t('Hmmmmm....we don\'t seem to have any articles matching your search.  Please try another term or place a support ticket!').'</div></div>';
[/code]
has no t().