Skip to content

Instantly share code, notes, and snippets.

@kben19
Last active August 8, 2021 03:49
Show Gist options
  • Save kben19/4c78fe125b942bc0b5a2b30f44708789 to your computer and use it in GitHub Desktop.
Save kben19/4c78fe125b942bc0b5a2b30f44708789 to your computer and use it in GitHub Desktop.
Bad code practice of defer on sql
db, err := sql.Open()
if err != nil {
log.Fatal(err)
}
tx, err := db.Begin()
if err != nil {
log.Fatal(err)
}
defer func() {
defer db.Close()
if err == nil {
tx.Commit()
return
}
tx.Rollback()
}()
rows, err := tx.Query("SELECT ...")
if err != nil {
return err
}
defer rows.Close()
defer func () {
err = rows.Err()
}
// Code here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment