Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Save kevinslin/5d1a6663638259e7dbd33b01975cc00f to your computer and use it in GitHub Desktop.
Save kevinslin/5d1a6663638259e7dbd33b01975cc00f to your computer and use it in GitHub Desktop.
Community PR Review Checklist

First Time Specifics

  • if its your first pull request to Dendron, watch out for the CLA bot that will ask you to agree to Dendron's CLA
  • if its your first pull request and you're on our Discord, add your discord handle so that we can award you the horticulturalist role when the PR is merged

Commit

  • make sure your branch names adhere to our branch style
  • make sure the commit message follows Dendron's commit style
  • if this pull request is addressing an existing issue, make sure to link this PR to the issue that it is resolving.

Code

  • code should follow Code Conventions
  • sticking to existing conventions instead of creating new ones

Tests

Docs

  • if your change reflects documentation changes, also submit a PR to dendron-site and mention the doc PR link in your current PR (NOTE: submit the PR against the dev branch of the dendron-site repo)

  • does this change introduce a new or better way of doing things that others need to be aware of? if so, an async should be created and a process added in Development or Packages

@PabloLION
Copy link

image
I think we should remove this line

make sure the commit message follows Dendron's commit style
if it is no longer active.

@PabloLION
Copy link

if its your first pull request and you're on our Discord, make sure that Kevin gives you the horticulturalist role by adding your discord as part of the description

image

@kevinslin
Copy link
Author

synced this PR guidance with the latest updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment