Skip to content

Instantly share code, notes, and snippets.

@kevr
Last active December 28, 2021 21:52
Show Gist options
  • Save kevr/199b6dd10649388b434a044a799143c4 to your computer and use it in GitHub Desktop.
Save kevr/199b6dd10649388b434a044a799143c4 to your computer and use it in GitHub Desktop.

diff(php..python)

Preface

Along with the development of the python port, we have modified a number of features. As locations for some of these features have changed, the Changes section should be reviewed to get ahold of the changes from a legacy PHP user's perspective.

Trusted Users should read the entirety of this document, as there have been several heavy-handed changes to the package request workflow.

Legend

There are a few terms which I'd like to define to increase understanding of these changes as they are listed:

  • self
    • Refers to a user viewing or doing something regarding their own account
  • /pkgbase/{name}/{action}
    • Refers to a POST action which can be triggered via the relevent package page at /{pkgbase,packages}/{name}.

Grouped changes explained in multiple items will always be prefixed with the same letter surrounded by braces. Example:

  • [A] Some feature that does something
  • [A] The same feature where another thing has changed

Changes

Overall

  • Pagers have all been modified. They still serve the same purpose, but they have slightly different display.

Package Requests

  • Normal users can now view and close their own requests
  • [A] Requests can no longer be accepted through manual closures
  • [A] Requests are now closed via their relevent actions
    • Deletion
      • Through /packages bulk delete action
      • Through /pkgbase/{name}/delete
    • Merge
      • Through /pkgbase/{name}/merge
    • Orphan
      • Through /packages bulk disown action
      • Through /pkgbase/{name}/disown
  • Deletion and merge requests (and their closures) are now autogenerated if no pre-existing request exists. This was done to increase tracking of package modifications performed by those with access to do so (TUs).
  • Deletion, merge and orphan request actions now close all (1 or more) requests pertaining to the action performed. This comes with the downside of multiple notifications sent out about a closure if more than one request (or no request) exists for them
  • Merge actions now automatically reject other pre-existing merge requests with a mismatched MergeBaseName column when a merge action is performed
  • The last /requests page no longer goes nowhere

Package Bulk Actions: /packages

  • The Merge into field has been removed. Merges now require being performed via the /pkgbase/{name}/merge action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment