I spend some of my free time on Bitcoin development to learn new things and contribute in the process.
If you like my work, you can donate: bc1q4k2umwjcnkv8h5ldq02apmwn8n64s52m73y8g0 (please drop me an email, if you contribute to avoid tax issues).
Why? Relying on less external dependencies is a good thing.
- [Idea]
- [Prototype PR]: 11 Jun 2020 - 22 Dec 2020
- [Adopted by fanquake] as bitcoin/bitcoin#20744
- PRs that should make it easier to merge the fanquake's PR:
- Help with review of #22937
- Additional attempts to help with 20744:
Why? GetDataDir()
function relies on the global state. This is hard to think about in general (for me). Moving this function to ArgsManager
and passing ArgsManager
to classes can have a similar (yet much smaller) benefit as tree-wide: De-globalize ChainstateManager.
- [issue: Remove gArgs]
- [PR] - Move
GetDataDir
toArgsManager
✓ - [PR] - Remove
GetDataDir(net_specific)
function ✓ - [PR] - Remove
gArgs
fromwallet.h
andwallet.cpp
✓ - [PR] - refactor: Remove
gArgs
fromwallet.h
andwallet.cpp
(2) ✓ - [PR] - refactor: Remove
gArgs
frombdb.h
andsqlite.h
✓
Why? .editorconfig
can help avoid some code formatting issues and thus less Cirrus CI runs may be needed to merge a Bitcoin Core PR.
- [PR]: Merged ✓
Why? Type hints are helpful to understand Python code better (subjectively). This may prove useful for new Bitcoin contributors.
- [PR]: Merged ✓
Why? It seems like a great feature to have and the work is sponsored by zkSNACKs 🙏
- PR: Rejected
Why? This work is sponsored by zkSNACKs 🙏 and I enjoy learning more about this stuff.
- I attempted to document the PR a bit: bitcoin/bitcoin#21245 (comment)
- Proposed minor improvements: bitcoin/bitcoin#21245 (comment)
- ... and attempted to polish the PR so that there's bigger chance the PR gets merged.
- Adopted #21245 by creating a new PR #22918 which is merged now.
PRs:
Github has a list of PRs where I did some review work.
https://github.com/rust-bitcoin/rust-miniscript/pulls?q=author%3Akiminuo+is%3Amerged some minor stuff :)
Hand-picked contributions to the privacy oriented Bitcoin wallet are here.