Skip to content

Instantly share code, notes, and snippets.

@kiminuo
Last active Sep 10, 2021
Embed
What would you like to do?
Bitcoin & Me

I spend some of my free time on Bitcoin development to learn new things and contribute in the process.

If you like my work, you can donate: bc1qxsm2k8j5qe586cj4lpurfvg23lzjj6mqvc62v2 (please drop me an email, if you contribute to avoid tax issues).

bitcoin/bitcoin

Replace boost::filesystem with std::filesystem

Why? Relying on less external dependencies is a good thing.

GetDataDir & ArgsManager

Why? GetDataDir() function relies on the global state. This is hard to think about in general (for me). Moving this function to ArgsManager and passing ArgsManager to classes can have a similar (yet much smaller) benefit as tree-wide: De-globalize ChainstateManager.

  • [issue: Remove gArgs]
  • [PR] - Move GetDataDir to ArgsManager
  • [PR] - Remove GetDataDir(net_specific) function ✓
  • [PR] - Remove gArgs from wallet.h and wallet.cpp
  • [PR] - refactor: Remove gArgs from wallet.h and wallet.cpp (2)

Add EditorConfig file

Why? .editorconfig can help avoid some code formatting issues and thus less Cirrus CI runs may be needed to merge a Bitcoin Core PR.

  • [PR]: Merged ✓

Type hints & Python scripts

Why? Type hints are helpful to understand Python code better (subjectively). This may prove useful for new Bitcoin contributors.

  • [PR]: Merged ✓

Feerate histogram

Why? It seems like a great feature to have and the work is sponsored by zkSNACKs 🙏

  • PR: Not merged

rpc: Add level 3 verbosity to getblock RPC call.

Why? This work is sponsored by zkSNACKs 🙏 and I enjoy learning more about this stuff.

Status: Not merged so far

Reviews

Github has a list of PRs where I did some review work.

rust-bitcoin/rust-miniscript

https://github.com/rust-bitcoin/rust-miniscript/pulls?q=author%3Akiminuo+is%3Amerged some minor stuff :)

zkSnacks/WasabiWallet

Hand-picked contributions to the privacy oriented Bitcoin wallet are here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment